This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-daemon.git
The following commit(s) were added to refs/heads/master by this push:
new 49969bf Fix IDE warnings
49969bf is described below
commit 49969bfbe4c1500af6627f6e1c7ed1ce3d384e86
Author: Mark Thomas <[email protected]>
AuthorDate: Mon Nov 17 15:29:41 2025 +0000
Fix IDE warnings
---
src/samples/AloneService.java | 2 +-
src/samples/ServiceDaemon.java | 2 +-
.../org/apache/commons/daemon/ProcrunDaemon.java | 26 ++++++++++------------
3 files changed, 14 insertions(+), 16 deletions(-)
diff --git a/src/samples/AloneService.java b/src/samples/AloneService.java
index b5cb1f6..834ca42 100644
--- a/src/samples/AloneService.java
+++ b/src/samples/AloneService.java
@@ -83,7 +83,7 @@ public class AloneService {
String name = (String) e.nextElement();
System.err.println("ServiceDaemon: starting: " + name + " : " +
prop.getProperty(name));
try {
- proc[i] = Runtime.getRuntime().exec(prop.getProperty(name));
+ proc[i] = Runtime.getRuntime().exec(new String[]
{prop.getProperty(name)});
} catch (Exception ex) {
System.err.println("Exception: " + ex);
}
diff --git a/src/samples/ServiceDaemon.java b/src/samples/ServiceDaemon.java
index b44b6be..dd8b8b9 100644
--- a/src/samples/ServiceDaemon.java
+++ b/src/samples/ServiceDaemon.java
@@ -91,7 +91,7 @@ public class ServiceDaemon implements Daemon {
String name = (String) e.nextElement();
System.err.println("ServiceDaemon: starting: " + name + " : " +
prop.getProperty(name));
try {
- proc[i] = Runtime.getRuntime().exec(prop.getProperty(name));
+ proc[i] = Runtime.getRuntime().exec(new String[]
{prop.getProperty(name)});
} catch (Exception ex) {
System.err.println("Exception: " + ex);
}
diff --git a/src/test/java/org/apache/commons/daemon/ProcrunDaemon.java
b/src/test/java/org/apache/commons/daemon/ProcrunDaemon.java
index 57fdc0f..2d21744 100644
--- a/src/test/java/org/apache/commons/daemon/ProcrunDaemon.java
+++ b/src/test/java/org/apache/commons/daemon/ProcrunDaemon.java
@@ -33,25 +33,23 @@ class ProcrunDaemon {
*/
public static void server() {
System.out.println("TestServ");
- ServerSocket serverSocket = null;
- try {
- serverSocket = new ServerSocket(4444, 2);
+ try (ServerSocket serverSocket = new ServerSocket(4444, 2)) {
+ /* Wait for clients */
+ for (;;) {
+ Socket clientSocket = null;
+ try {
+ clientSocket = serverSocket.accept();
+ ProcessClient(clientSocket);
+ } catch (IOException e) {
+ System.out.println("Accept or Client failed: 4444");
+ System.exit(-1);
+ }
+ }
} catch (IOException e) {
System.out.println("Could not listen on port: 4444");
System.exit(-1);
}
- /* Wait fo clients */
- for (;;) {
- Socket clientSocket = null;
- try {
- clientSocket = serverSocket.accept();
- ProcessClient(clientSocket);
- } catch (IOException e) {
- System.out.println("Accept or Client failed: 4444");
- System.exit(-1);
- }
- }
}
public static void ProcessClient(Socket clientSocket) {
