This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-jxpath.git
commit 1e0c38115d0e41a8474b17cdb41dd7a72cc3b372 Author: Gary Gregory <[email protected]> AuthorDate: Sun Nov 16 10:33:29 2025 -0500 Reuse String.isEmpty() --- src/main/java/org/apache/commons/jxpath/ri/NamespaceResolver.java | 2 +- .../java/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.java | 3 ++- .../java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/apache/commons/jxpath/ri/NamespaceResolver.java b/src/main/java/org/apache/commons/jxpath/ri/NamespaceResolver.java index 64c0cb0f..8e0e2f22 100644 --- a/src/main/java/org/apache/commons/jxpath/ri/NamespaceResolver.java +++ b/src/main/java/org/apache/commons/jxpath/ri/NamespaceResolver.java @@ -48,7 +48,7 @@ public class NamespaceResolver implements Cloneable, Serializable { final String uri = nsPointer.getNamespaceURI(); if (uri.equals(namespaceURI)) { final String prefix = nsPointer.getName().getName(); - if (!"".equals(prefix)) { + if (!prefix.isEmpty()) { return prefix; } } diff --git a/src/main/java/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.java b/src/main/java/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.java index da541f5a..43375e25 100644 --- a/src/main/java/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.java +++ b/src/main/java/org/apache/commons/jxpath/ri/model/dom/DOMNodePointer.java @@ -36,6 +36,7 @@ import org.apache.commons.jxpath.ri.model.NodeIterator; import org.apache.commons.jxpath.ri.model.NodePointer; import org.apache.commons.jxpath.ri.model.beans.NullPointer; import org.apache.commons.jxpath.util.TypeUtils; +import org.apache.commons.lang3.StringUtils; import org.w3c.dom.Attr; import org.w3c.dom.Comment; import org.w3c.dom.Document; @@ -136,7 +137,7 @@ public class DOMNodePointer extends NodePointer { aNode = aNode.getParentNode(); } } - return "".equals(uri) ? null : uri; + return StringUtils.isEmpty(uri) ? null : uri; } /** diff --git a/src/main/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java b/src/main/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java index 285503ff..96e7d117 100644 --- a/src/main/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java +++ b/src/main/java/org/apache/commons/jxpath/ri/model/jdom/JDOMNodePointer.java @@ -117,7 +117,7 @@ public class JDOMNodePointer extends NodePointer { if (node instanceof Element) { final Element element = (Element) node; String ns = element.getNamespaceURI(); - if ("".equals(ns)) { + if (ns.isEmpty()) { ns = null; } return ns;
