This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-text.git
The following commit(s) were added to refs/heads/master by this push:
new 0211ac68 Sort members
0211ac68 is described below
commit 0211ac6868f7329256a093de6b87c67c393cb424
Author: Gary Gregory <[email protected]>
AuthorDate: Fri Nov 14 13:59:25 2025 -0500
Sort members
---
.../apache/commons/text/StringSubstitutorTest.java | 14 +++----
.../text/similarity/HammingDistanceTest.java | 48 +++++++++++-----------
.../text/similarity/JaroWinklerDistanceTest.java | 20 ++++-----
.../text/similarity/JaroWinklerSimilarityTest.java | 28 ++++++-------
4 files changed, 55 insertions(+), 55 deletions(-)
diff --git a/src/test/java/org/apache/commons/text/StringSubstitutorTest.java
b/src/test/java/org/apache/commons/text/StringSubstitutorTest.java
index 3692653f..75f112ba 100644
--- a/src/test/java/org/apache/commons/text/StringSubstitutorTest.java
+++ b/src/test/java/org/apache/commons/text/StringSubstitutorTest.java
@@ -228,6 +228,13 @@ public class StringSubstitutorTest {
assertTrue(target.getVariableSuffixMatcher().toString().endsWith("['s']"),
target.getValueDelimiterMatcher().toString());
}
+ @Test
+ void testDetectsCyclicSubstitution() {
+ final Map<String, String> map = new HashMap<>();
+ map.put("name", "<name>");
+ assertThrows(IllegalStateException.class, () ->
StringSubstitutor.replace("Hi <name>!", map, "<", ">"));
+ }
+
/**
* Tests get set.
*/
@@ -1078,11 +1085,4 @@ public class StringSubstitutorTest {
assertEqualsCharSeq("value $${escaped}", replace(sub, org));
}
- @Test
- void testDetectsCyclicSubstitution() {
- final Map<String, String> map = new HashMap<>();
- map.put("name", "<name>");
- assertThrows(IllegalStateException.class, () ->
StringSubstitutor.replace("Hi <name>!", map, "<", ">"));
- }
-
}
diff --git
a/src/test/java/org/apache/commons/text/similarity/HammingDistanceTest.java
b/src/test/java/org/apache/commons/text/similarity/HammingDistanceTest.java
index 918a7bed..0b8e5e13 100644
--- a/src/test/java/org/apache/commons/text/similarity/HammingDistanceTest.java
+++ b/src/test/java/org/apache/commons/text/similarity/HammingDistanceTest.java
@@ -36,42 +36,42 @@ class HammingDistanceTest {
distance = new HammingDistance();
}
- @ParameterizedTest
-
@MethodSource("org.apache.commons.text.similarity.SimilarityInputTest#similarityInputsEquals()")
- void testHammingDistance(final Class<?> cls) {
- assertEquals(0, distance.apply(SimilarityInputTest.build(cls, ""),
SimilarityInputTest.build(cls, "")));
- assertEquals(0, distance.apply(SimilarityInputTest.build(cls,
"pappa"), SimilarityInputTest.build(cls, "pappa")));
- assertEquals(1, distance.apply(SimilarityInputTest.build(cls,
"papaa"), SimilarityInputTest.build(cls, "pappa")));
- assertEquals(3, distance.apply(SimilarityInputTest.build(cls,
"karolin"), SimilarityInputTest.build(cls, "kathrin")));
- assertEquals(3, distance.apply(SimilarityInputTest.build(cls,
"karolin"), SimilarityInputTest.build(cls, "kerstin")));
- assertEquals(2, distance.apply(SimilarityInputTest.build(cls,
"1011101"), SimilarityInputTest.build(cls, "1001001")));
- assertEquals(3, distance.apply(SimilarityInputTest.build(cls,
"2173896"), SimilarityInputTest.build(cls, "2233796")));
- assertEquals(2, distance.apply(SimilarityInputTest.build(cls, "ATCG"),
SimilarityInputTest.build(cls, "ACCC")));
+ @Test
+ void testApply_DifferentSimilarityInputLength() {
+ assertThrows(IllegalArgumentException.class, () -> distance.apply(new
SimilarityCharacterInput("a"), new SimilarityCharacterInput("ab")));
}
@Test
- void testHammingDistance_nullLeftValue() {
- assertThrows(IllegalArgumentException.class, () ->
distance.apply(null, ""));
- }
+ void testApply_NullSimilarityInput() {
+ assertThrows(IllegalArgumentException.class, () -> distance.apply(null,
new SimilarityCharacterInput("a")));
+ }
@Test
- void testHammingDistance_nullRightValue() {
- assertThrows(IllegalArgumentException.class, () -> distance.apply("",
null));
+ void testApply_SimilarityInputNull() {
+ assertThrows(IllegalArgumentException.class, () -> distance.apply(new
SimilarityCharacterInput("a"), null));
}
- @Test
- void testApply_NullSimilarityInput() {
- assertThrows(IllegalArgumentException.class, () ->
distance.apply(null, new SimilarityCharacterInput("a")));
- }
+ @ParameterizedTest
+
@MethodSource("org.apache.commons.text.similarity.SimilarityInputTest#similarityInputsEquals()")
+ void testHammingDistance(final Class<?> cls) {
+ assertEquals(0,
distance.apply(SimilarityInputTest.build(cls, ""),
SimilarityInputTest.build(cls, "")));
+ assertEquals(0,
distance.apply(SimilarityInputTest.build(cls, "pappa"),
SimilarityInputTest.build(cls, "pappa")));
+ assertEquals(1,
distance.apply(SimilarityInputTest.build(cls, "papaa"),
SimilarityInputTest.build(cls, "pappa")));
+ assertEquals(3,
distance.apply(SimilarityInputTest.build(cls, "karolin"),
SimilarityInputTest.build(cls, "kathrin")));
+ assertEquals(3,
distance.apply(SimilarityInputTest.build(cls, "karolin"),
SimilarityInputTest.build(cls, "kerstin")));
+ assertEquals(2,
distance.apply(SimilarityInputTest.build(cls, "1011101"),
SimilarityInputTest.build(cls, "1001001")));
+ assertEquals(3,
distance.apply(SimilarityInputTest.build(cls, "2173896"),
SimilarityInputTest.build(cls, "2233796")));
+ assertEquals(2,
distance.apply(SimilarityInputTest.build(cls, "ATCG"),
SimilarityInputTest.build(cls, "ACCC")));
+ }
@Test
- void testApply_SimilarityInputNull() {
- assertThrows(IllegalArgumentException.class, () -> distance.apply(new
SimilarityCharacterInput("a"), null));
+ void testHammingDistance_nullLeftValue() {
+ assertThrows(IllegalArgumentException.class, () ->
distance.apply(null, ""));
}
@Test
- void testApply_DifferentSimilarityInputLength() {
- assertThrows(IllegalArgumentException.class, () -> distance.apply(new
SimilarityCharacterInput("a"), new SimilarityCharacterInput("ab")));
+ void testHammingDistance_nullRightValue() {
+ assertThrows(IllegalArgumentException.class, () -> distance.apply("",
null));
}
@Test
diff --git
a/src/test/java/org/apache/commons/text/similarity/JaroWinklerDistanceTest.java
b/src/test/java/org/apache/commons/text/similarity/JaroWinklerDistanceTest.java
index 412f1e72..509d58bb 100644
---
a/src/test/java/org/apache/commons/text/similarity/JaroWinklerDistanceTest.java
+++
b/src/test/java/org/apache/commons/text/similarity/JaroWinklerDistanceTest.java
@@ -36,6 +36,16 @@ class JaroWinklerDistanceTest {
distance = new JaroWinklerDistance();
}
+ @Test
+ void testApply_NullSimilarityInput() {
+ assertThrows(IllegalArgumentException.class, () ->
distance.apply(null, new SimilarityCharacterInput("a")));
+ }
+
+ @Test
+ void testApply_SimilarityInputNull() {
+ assertThrows(IllegalArgumentException.class, () -> distance.apply(new
SimilarityCharacterInput("a"), null));
+ }
+
@ParameterizedTest
@MethodSource("org.apache.commons.text.similarity.SimilarityInputTest#similarityInputsEquals()")
void testGetJaroWinklerDistance(final Class<?> cls) {
@@ -95,14 +105,4 @@ class JaroWinklerDistanceTest {
assertEquals(1 - 0.51111d, distance.apply("foo", " foo"), 0.00001d);
}
- @Test
- void testApply_NullSimilarityInput() {
- assertThrows(IllegalArgumentException.class, () ->
distance.apply(null, new SimilarityCharacterInput("a")));
- }
-
- @Test
- void testApply_SimilarityInputNull() {
- assertThrows(IllegalArgumentException.class, () -> distance.apply(new
SimilarityCharacterInput("a"), null));
- }
-
}
diff --git
a/src/test/java/org/apache/commons/text/similarity/JaroWinklerSimilarityTest.java
b/src/test/java/org/apache/commons/text/similarity/JaroWinklerSimilarityTest.java
index 0b1f9705..f2a362dc 100644
---
a/src/test/java/org/apache/commons/text/similarity/JaroWinklerSimilarityTest.java
+++
b/src/test/java/org/apache/commons/text/similarity/JaroWinklerSimilarityTest.java
@@ -78,6 +78,16 @@ class JaroWinklerSimilarityTest {
};
}
+ @Test
+ void testApply_NullSimilarityInput() {
+ assertThrows(IllegalArgumentException.class, () ->
similarity.apply(null, new SimilarityCharacterInput("a")));
+ }
+
+ @Test
+ void testApply_SimilarityInputNull() {
+ assertThrows(IllegalArgumentException.class, () ->
similarity.apply(new SimilarityCharacterInput("a"), null));
+ }
+
@ParameterizedTest
@MethodSource("org.apache.commons.text.similarity.SimilarityInputTest#similarityInputsEquals()")
void testGetJaroWinklerSimilarity(final Class<?> cls) {
@@ -111,10 +121,10 @@ class JaroWinklerSimilarityTest {
assertThrows(IllegalArgumentException.class, () ->
similarity.apply(null, "clear"));
}
- @Test
- void testGetJaroWinklerSimilarity_StringNull() {
- assertThrows(IllegalArgumentException.class, () -> similarity.apply("
", null));
- }
+ @Test
+ void testGetJaroWinklerSimilarity_StringNull() {
+ assertThrows(IllegalArgumentException.class, () ->
similarity.apply(" ", null));
+ }
@Test
void testGetJaroWinklerSimilarity_StringString() {
@@ -136,14 +146,4 @@ class JaroWinklerSimilarityTest {
assertEquals(0.911111d, similarity.apply(wrap("John Horn"), "John
Hopkins"), 0.00001d);
}
- @Test
- void testApply_NullSimilarityInput() {
- assertThrows(IllegalArgumentException.class, () ->
similarity.apply(null, new SimilarityCharacterInput("a")));
- }
-
- @Test
- void testApply_SimilarityInputNull() {
- assertThrows(IllegalArgumentException.class, () ->
similarity.apply(new SimilarityCharacterInput("a"), null));
- }
-
}
