This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-compress.git
The following commit(s) were added to refs/heads/master by this push: new 8b8ee8043 Reuse Arrays.fill() 8b8ee8043 is described below commit 8b8ee80431d8158cd832d94084b3aa0a31241bef Author: Gary D. Gregory <garydgreg...@gmail.com> AuthorDate: Sat Aug 16 08:37:24 2025 -0400 Reuse Arrays.fill() --- .../harmony/unpack200/bytecode/forms/LookupSwitchForm.java | 5 ++--- .../harmony/unpack200/bytecode/forms/TableSwitchForm.java | 13 +++---------- 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/forms/LookupSwitchForm.java b/src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/forms/LookupSwitchForm.java index 123283558..5112c9a9c 100644 --- a/src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/forms/LookupSwitchForm.java +++ b/src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/forms/LookupSwitchForm.java @@ -75,9 +75,8 @@ public void setByteCodeOperands(final ByteCode byteCode, final OperandManager op // opcode newRewrite[rewriteIndex++] = byteCode.getOpcode(); // padding - for (int index = 0; index < padLength; index++) { - newRewrite[rewriteIndex++] = 0; - } + Arrays.fill(newRewrite, rewriteIndex, rewriteIndex + padLength, 0); + rewriteIndex += padLength; // defaultbyte // This gets overwritten by fixUpByteCodeTargets newRewrite[rewriteIndex++] = -1; diff --git a/src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/forms/TableSwitchForm.java b/src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/forms/TableSwitchForm.java index 2ed5fc8a9..9f15175c6 100644 --- a/src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/forms/TableSwitchForm.java +++ b/src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/forms/TableSwitchForm.java @@ -81,9 +81,8 @@ public void setByteCodeOperands(final ByteCode byteCode, final OperandManager op // opcode newRewrite[rewriteIndex++] = byteCode.getOpcode(); // padding - for (int index = 0; index < padLength; index++) { - newRewrite[rewriteIndex++] = 0; - } + Arrays.fill(newRewrite, rewriteIndex, rewriteIndex + padLength, 0); + rewriteIndex += padLength; // defaultbyte // This gets overwritten by fixUpByteCodeTargets newRewrite[rewriteIndex++] = -1; @@ -100,13 +99,7 @@ public void setByteCodeOperands(final ByteCode byteCode, final OperandManager op rewriteIndex += 4; // jump offsets // The case_pcs will get overwritten by fixUpByteCodeTargets - for (int index = 0; index < caseCount; index++) { - // offset - newRewrite[rewriteIndex++] = -1; - newRewrite[rewriteIndex++] = -1; - newRewrite[rewriteIndex++] = -1; - newRewrite[rewriteIndex++] = -1; - } + Arrays.fill(newRewrite, rewriteIndex, rewriteIndex + (caseCount * 4), -1); byteCode.setRewrite(newRewrite); } }