(commons-codec) 04/08: Fix PMD UnusedFormalParameter in private constructor in org.apache.commons.codec.binary.Base16

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git

commit 3a7cdf5280bc1dd04839bf37862346eaa672b2ed
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Fri Jul 18 21:48:27 2025 -0400

    Fix PMD UnusedFormalParameter in private constructor in
    org.apache.commons.codec.binary.Base16
---
 src/changes/changes.xml                                   | 1 +
 src/main/java/org/apache/commons/codec/binary/Base16.java | 6 ++----
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 3e556abd..ec85c0cb 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -59,6 +59,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action type="fix" dev="ggregory" issue="CODEC-331" due-to="IlikeCode, 
Gary 
Gregory">org.apache.commons.codec.language.bm.Rule.parsePhonemeExpr(String) 
adds duplicate empty phoneme when input ends with |.</action>
       <action type="fix" dev="ggregory" issue="CODEC-331" due-to="IlikeCode, 
Gary 
Gregory">org.apache.commons.codec.language.DaitchMokotoffSoundex.cleanup(String)
 does not remove special characters like punctuation.</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD multiple 
UnnecessaryFullyQualifiedName in 
org.apache.commons.codec.binary.StringUtils.</action>
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD 
UnusedFormalParameter in private constructor in 
org.apache.commons.codec.binary.Base16.</action>
       <!-- ADD -->
       <action type="add" dev="ggregory" due-to="Gary Gregory">Add 
HmacUtils.hmac(Path).</action>      
       <action type="add" dev="ggregory" due-to="Gary Gregory">Add 
HmacUtils.hmacHex(Path).</action>      
diff --git a/src/main/java/org/apache/commons/codec/binary/Base16.java 
b/src/main/java/org/apache/commons/codec/binary/Base16.java
index 1cf1590b..30e52eca 100644
--- a/src/main/java/org/apache/commons/codec/binary/Base16.java
+++ b/src/main/java/org/apache/commons/codec/binary/Base16.java
@@ -122,12 +122,10 @@ public class Base16 extends BaseNCodec {
 
     /**
      * Constructs a Base16 codec used for decoding and encoding.
-     *
-     * @param lowerCase      if {@code true} then use a lower-case Base16 
alphabet.
      * @param encodeTable    the encode table.
      * @param decodingPolicy Decoding policy.
      */
-    private Base16(final boolean lowerCase, final byte[] encodeTable, final 
CodecPolicy decodingPolicy) {
+    private Base16(final byte[] encodeTable, final CodecPolicy decodingPolicy) 
{
         super(BYTES_PER_UNENCODED_BLOCK, BYTES_PER_ENCODED_BLOCK, 0, 0, 
PAD_DEFAULT, decodingPolicy);
         Objects.requireNonNull(encodeTable, "encodeTable");
         this.encodeTable = encodeTable;
@@ -141,7 +139,7 @@ public class Base16 extends BaseNCodec {
      * @param decodingPolicy Decoding policy.
      */
     public Base16(final boolean lowerCase, final CodecPolicy decodingPolicy) {
-        this(lowerCase, lowerCase ? LOWER_CASE_ENCODE_TABLE : 
UPPER_CASE_ENCODE_TABLE, decodingPolicy);
+        this(lowerCase ? LOWER_CASE_ENCODE_TABLE : UPPER_CASE_ENCODE_TABLE, 
decodingPolicy);
     }
 
     @Override