This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-pool.git
The following commit(s) were added to refs/heads/master by this push: new 12fde5f3 Reuse Suppliers.nul() in tests 12fde5f3 is described below commit 12fde5f3f9924f4557891b369b798d1220363ca6 Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Wed Jun 18 08:37:44 2025 -0400 Reuse Suppliers.nul() in tests --- .../java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java | 3 ++- src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/test/java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java b/src/test/java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java index 72322a86..980fcc7c 100644 --- a/src/test/java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java +++ b/src/test/java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java @@ -53,6 +53,7 @@ import javax.management.MBeanServer; import javax.management.ObjectName; import org.apache.commons.lang3.exception.ExceptionUtils; +import org.apache.commons.lang3.function.Suppliers; import org.apache.commons.pool3.AbstractTestKeyedObjectPool; import org.apache.commons.pool3.BaseKeyedPooledObjectFactory; import org.apache.commons.pool3.DestroyMode; @@ -2392,7 +2393,7 @@ class TestGenericKeyedObjectPool extends AbstractTestKeyedObjectPool { void testNPEOnFactoryNull() { // @formatter:off final DisconnectingWaiterFactory<String> factory = new DisconnectingWaiterFactory<>( - () -> null, // Override default to always return null from makeObject + Suppliers.nul(), // Override default to always return null from makeObject DisconnectingWaiterFactory.DEFAULT_DISCONNECTED_LIFECYCLE_ACTION, DisconnectingWaiterFactory.DEFAULT_DISCONNECTED_VALIDATION_ACTION ); diff --git a/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java b/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java index 74c10e4a..6317f1a3 100644 --- a/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java +++ b/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java @@ -52,6 +52,7 @@ import javax.management.MBeanServer; import javax.management.ObjectName; import org.apache.commons.lang3.ThreadUtils; +import org.apache.commons.lang3.function.Suppliers; import org.apache.commons.lang3.time.DurationUtils; import org.apache.commons.pool3.BasePooledObjectFactory; import org.apache.commons.pool3.ObjectPool; @@ -2653,7 +2654,7 @@ class TestGenericObjectPool extends TestBaseObjectPool { @Timeout(value = 1000, unit = TimeUnit.MILLISECONDS) void testNPEOnFactoryNull() throws InterruptedException { final DisconnectingWaiterFactory<String> factory = new DisconnectingWaiterFactory<>( - () -> null, // Override default to always return null from makeObject + Suppliers.nul(), // Override default to always return null from makeObject DisconnectingWaiterFactory.DEFAULT_DISCONNECTED_LIFECYCLE_ACTION, DisconnectingWaiterFactory.DEFAULT_DISCONNECTED_VALIDATION_ACTION); try (GenericObjectPool<Waiter, IllegalStateException> pool = new GenericObjectPool<>(factory)) {