(commons-lang) 02/02: Add missing test coverage for org.apache.commons.lang3.ArrayUtils.toPrimitive(Object)

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git

commit f690d2e9bbd87df24c90766e170de68e6d3940ba
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Mon Jun 16 11:54:55 2025 -0400

    Add missing test coverage for
    org.apache.commons.lang3.ArrayUtils.toPrimitive(Object)
    
    Split test for each API:
    - org.apache.commons.lang3.ArrayUtils.toString(Object)
    - org.apache.commons.lang3.ArrayUtils.toString(Object, String)
---
 .../org/apache/commons/lang3/ArrayUtilsTest.java   | 36 ++++++++++++----------
 1 file changed, 20 insertions(+), 16 deletions(-)

diff --git a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java 
b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
index 45afd31fe..658560d4e 100644
--- a/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
@@ -6676,27 +6676,28 @@ void testToPrimitive_short_short() {
     @Test
     void testToPrimitiveArray() {
         assertNull(ArrayUtils.toPrimitive((Object[]) null));
-        assertArrayEquals(new boolean[]{true}, ArrayUtils.toPrimitive(new 
Boolean[]{true}));
-        assertArrayEquals(new char[]{'a'}, ArrayUtils.toPrimitive(new 
Character[]{'a'}));
-        assertArrayEquals(new byte[]{1}, ArrayUtils.toPrimitive(new 
Byte[]{1}));
-        assertArrayEquals(new int[]{}, ArrayUtils.toPrimitive(new 
Integer[]{}));
-        assertArrayEquals(new short[]{2}, ArrayUtils.toPrimitive(new 
Short[]{2}));
-        assertArrayEquals(new long[]{2, 3}, ArrayUtils.toPrimitive(new 
Long[]{2L, 3L}));
-        assertArrayEquals(new float[]{3.14f}, ArrayUtils.toPrimitive(new 
Float[]{3.14f}), 0.1f);
-        assertArrayEquals(new double[]{2.718}, ArrayUtils.toPrimitive(new 
Double[]{2.718}), 0.1);
+        assertArrayEquals(new boolean[] { true }, ArrayUtils.toPrimitive(new 
Boolean[] { true }));
+        assertArrayEquals(new char[] { 'a' }, ArrayUtils.toPrimitive(new 
Character[] { 'a' }));
+        assertArrayEquals(new byte[] { 1 }, ArrayUtils.toPrimitive(new Byte[] 
{ 1 }));
+        assertArrayEquals(new int[] {}, ArrayUtils.toPrimitive(new Integer[] 
{}));
+        assertArrayEquals(new short[] { 2 }, ArrayUtils.toPrimitive(new 
Short[] { 2 }));
+        assertArrayEquals(new long[] { 2, 3 }, ArrayUtils.toPrimitive(new 
Long[] { 2L, 3L }));
+        assertArrayEquals(new float[] { 3.14f }, ArrayUtils.toPrimitive(new 
Float[] { 3.14f }), 0.1f);
+        assertArrayEquals(new double[] { 2.718 }, ArrayUtils.toPrimitive(new 
Double[] { 2.718 }), 0.1);
     }
 
     @Test
     void testToPrimitiveArrayViaObjectArray() {
         assertNull(ArrayUtils.toPrimitive((Object) null));
-        assertArrayEquals(new boolean[]{true}, (boolean[]) 
ArrayUtils.toPrimitive((Object) new Boolean[]{true}));
-        assertArrayEquals(new char[]{'a'}, (char[]) 
ArrayUtils.toPrimitive((Object) new Character[]{'a'}));
-        assertArrayEquals(new byte[]{1}, (byte[]) 
ArrayUtils.toPrimitive((Object) new Byte[]{1}));
-        assertArrayEquals(new int[]{}, (int[]) ArrayUtils.toPrimitive((Object) 
new Integer[]{}));
-        assertArrayEquals(new short[]{2}, (short[]) 
ArrayUtils.toPrimitive((Object) new Short[]{2}));
-        assertArrayEquals(new long[]{2, 3}, (long[]) 
ArrayUtils.toPrimitive((Object) new Long[]{2L, 3L}));
-        assertArrayEquals(new float[]{3.14f}, (float[]) 
ArrayUtils.toPrimitive((Object) new Float[]{3.14f}), 0.1f);
-        assertArrayEquals(new double[]{2.718}, (double[]) 
ArrayUtils.toPrimitive((Object) new Double[]{2.718}), 0.1);
+        assertArrayEquals(new boolean[] { true }, (boolean[]) 
ArrayUtils.toPrimitive((Object) new Boolean[] { true }));
+        assertArrayEquals(new char[] { 'a' }, (char[]) 
ArrayUtils.toPrimitive((Object) new Character[] { 'a' }));
+        assertArrayEquals(new byte[] { 1 }, (byte[]) 
ArrayUtils.toPrimitive((Object) new Byte[] { 1 }));
+        assertArrayEquals(new int[] {}, (int[]) 
ArrayUtils.toPrimitive((Object) new Integer[] {}));
+        assertArrayEquals(new short[] { 2 }, (short[]) 
ArrayUtils.toPrimitive((Object) new Short[] { 2 }));
+        assertArrayEquals(new long[] { 2, 3 }, (long[]) 
ArrayUtils.toPrimitive((Object) new Long[] { 2L, 3L }));
+        assertArrayEquals(new float[] { 3.14f }, (float[]) 
ArrayUtils.toPrimitive((Object) new Float[] { 3.14f }), 0.1f);
+        assertArrayEquals(new double[] { 2.718 }, (double[]) 
ArrayUtils.toPrimitive((Object) new Double[] { 2.718 }), 0.1);
+        assertArrayEquals(new String[] { "a" }, (String[]) 
ArrayUtils.toPrimitive(new String[] { "a" }));
     }
 
     @Test
@@ -6706,7 +6707,10 @@ void testToString() {
         assertEquals("{}", ArrayUtils.toString(new String[0]));
         assertEquals("{<null>}", ArrayUtils.toString(new String[]{null}));
         assertEquals("{pink,blue}", ArrayUtils.toString(new String[]{"pink", 
"blue"}));
+    }
 
+    @Test
+    void testToStringDefault() {
         assertEquals("<empty>", ArrayUtils.toString(null, "<empty>"));
         assertEquals("{}", ArrayUtils.toString(new Object[0], "<empty>"));
         assertEquals("{}", ArrayUtils.toString(new String[0], "<empty>"));