This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git
commit a32cab8566e0c4c7767a655ff4d03938a26e0525 Author: Gary D. Gregory <garydgreg...@gmail.com> AuthorDate: Sun Jun 15 14:10:07 2025 -0400 Add missing test coverage for org.apache.commons.lang3.reflect.TypeUtils.parameterizeWithOwner(Type, Class<?>, Map<TypeVariable<?>, Type>) --- .../java/org/apache/commons/lang3/reflect/TypeUtilsTest.java | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java b/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java index 899b42ddd..b81bc1732 100644 --- a/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java @@ -1015,6 +1015,13 @@ void testParameterizeWithOwner3ArgsNullPointerException() { assertThrows(NullPointerException.class, () -> TypeUtils.parameterizeWithOwner(owner, null, String.class)); final Map<TypeVariable<?>, Type> nullTypeVariableMap = null; assertThrows(NullPointerException.class, () -> TypeUtils.parameterizeWithOwner(owner, That.class, nullTypeVariableMap)); + final Map<TypeVariable<?>, Type> typeVariableMap1 = new HashMap<>(); + typeVariableMap1.put(Comparable.class.getTypeParameters()[0], String.class); + assertEquals(Comparable.class, TypeUtils.parameterizeWithOwner(null, Comparable.class, typeVariableMap1).getRawType()); + final Map<TypeVariable<?>, Type> typeVariableMap2 = new HashMap<>(); + typeVariableMap2.put(MyInnerClass.class.getTypeParameters()[0], String.class); + assertEquals(MyInnerClass.class, TypeUtils.parameterizeWithOwner(null, MyInnerClass.class, typeVariableMap2).getRawType()); + assertEquals(MyInnerClass.class, TypeUtils.parameterizeWithOwner(owner, MyInnerClass.class, typeVariableMap2).getRawType()); } @Test @@ -1026,7 +1033,6 @@ void testParameterizeWithOwnerVarArgsNullPointerException() { @Test void testToLongString() { assertEquals(getClass().getName() + ":B", TypeUtils.toLongString(getClass().getTypeParameters()[0])); - assertThrows(NullPointerException.class, () -> TypeUtils.toLongString(null)); } @@ -1050,7 +1056,6 @@ void testTypesSatisfyVariables() throws NoSuchMethodException { typeVarAssigns.clear(); typeVarAssigns.put(getClass().getMethod("stub3").getTypeParameters()[0], Integer.class); assertTrue(TypeUtils.typesSatisfyVariables(typeVarAssigns)); - assertThrows(NullPointerException.class, () -> TypeUtils.typesSatisfyVariables(null)); }