This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-jelly.git
commit 2d2119cd2ca7860db00227b8c1441e61365ed0e3 Author: Gary D. Gregory <garydgreg...@gmail.com> AuthorDate: Fri Jun 13 11:27:51 2025 -0400 Use final --- .../org/apache/commons/jelly/tags/jface/ActionTag.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/jelly-tags/jface/src/main/java/org/apache/commons/jelly/tags/jface/ActionTag.java b/jelly-tags/jface/src/main/java/org/apache/commons/jelly/tags/jface/ActionTag.java index a30dc8b7..d45038d1 100644 --- a/jelly-tags/jface/src/main/java/org/apache/commons/jelly/tags/jface/ActionTag.java +++ b/jelly-tags/jface/src/main/java/org/apache/commons/jelly/tags/jface/ActionTag.java @@ -38,11 +38,11 @@ public class ActionTag extends UseBeanTag { */ final class ActionImpl extends Action { @Override - public void runWithEvent(Event event) { + public void runWithEvent(final Event event) { try { context.setVariable(var, event); invokeBody(output); - } catch (Exception e) { + } catch (final Exception e) { log.error( "Caught exception: " + e @@ -56,12 +56,12 @@ public class ActionTag extends UseBeanTag { /** The Log to which logging calls will be made. */ private static final Log log = LogFactory.getLog(ActionTag.class); private XMLOutput output; - private String var = "event"; + private final String var = "event"; /** * @param arg0 */ - public ActionTag(Class arg0) { + public ActionTag(final Class arg0) { super(arg0); } @@ -69,7 +69,7 @@ public class ActionTag extends UseBeanTag { * @return IContributionManager */ protected IContributionManager getParentContributionManager() { - MenuManagerTag tag = + final MenuManagerTag tag = (MenuManagerTag) findAncestorWithClass(MenuManagerTag.class); if (tag != null) { return tag.getMenuManager(); @@ -81,15 +81,15 @@ public class ActionTag extends UseBeanTag { * @see org.apache.commons.jelly.Tag#doTag(org.apache.commons.jelly.XMLOutput) */ @Override - public void doTag(XMLOutput output) + public void doTag(final XMLOutput output) throws MissingAttributeException, JellyTagException { - Map attributes = getAttributes(); + final Map attributes = getAttributes(); - Action action = new ActionImpl(); + final Action action = new ActionImpl(); setBeanProperties(action, attributes); - IContributionManager cm = getParentContributionManager(); + final IContributionManager cm = getParentContributionManager(); if (cm != null) { cm.add(action); }