This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch POOL_2_X
in repository https://gitbox.apache.org/repos/asf/commons-pool.git

commit c4526a424d3b061e61f767c8d9cb90dd7021c782
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Tue Jun 10 14:09:24 2025 -0400

    Use assertThrows()
---
 .../commons/pool2/impl/TestGenericObjectPool.java   | 21 +++------------------
 1 file changed, 3 insertions(+), 18 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java 
b/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java
index 1760676e..e518ed22 100644
--- a/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java
+++ b/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java
@@ -2453,24 +2453,9 @@ class TestGenericObjectPool extends TestBaseObjectPool {
             pool.setMinIdle(1);
             // Disconnect the factory - will always return null in this state
             factory.disconnect();
-            try {
-                pool.borrowObject();
-                fail("Expecting NullPointerException");
-            } catch (final NullPointerException ex) {
-                // expected
-            }
-            try {
-                pool.addObject();
-                fail("Expecting NullPointerException");
-            } catch (final NullPointerException ex2) {
-                // expected
-            }
-            try {
-                pool.ensureMinIdle();
-                fail("Expecting NullPointerException");
-            } catch (final NullPointerException ex3) {
-                // expected
-            }
+            assertThrows(NullPointerException.class, pool::borrowObject);
+            assertThrows(NullPointerException.class, pool::addObject);
+            assertThrows(NullPointerException.class, pool::ensureMinIdle);
         }
     }
 

Reply via email to