This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-exec.git
The following commit(s) were added to refs/heads/master by this push:
new 8babb7c3 Use JUnit 5 convention for class visibility
8babb7c3 is described below
commit 8babb7c32b513810688f8e1b43e0cbf115ef7798
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Jun 8 14:41:24 2025 -0400
Use JUnit 5 convention for class visibility
---
src/test/java/org/apache/commons/exec/CommandLineTest.java | 2 +-
src/test/java/org/apache/commons/exec/DefaultExecutorTest.java | 2 +-
src/test/java/org/apache/commons/exec/LogOutputStreamTest.java | 2 +-
src/test/java/org/apache/commons/exec/OSTest.java | 2 +-
src/test/java/org/apache/commons/exec/PumpStreamHandlerTest.java | 2 +-
src/test/java/org/apache/commons/exec/StandAloneTest.java | 2 +-
src/test/java/org/apache/commons/exec/TimeoutObserverTest.java | 2 +-
src/test/java/org/apache/commons/exec/TutorialTest.java | 2 +-
.../java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java | 2 +-
src/test/java/org/apache/commons/exec/issues/Exec33Test.java | 2 +-
src/test/java/org/apache/commons/exec/issues/Exec34Test.java | 2 +-
src/test/java/org/apache/commons/exec/issues/Exec36Test.java | 2 +-
src/test/java/org/apache/commons/exec/issues/Exec41Test.java | 2 +-
src/test/java/org/apache/commons/exec/issues/Exec44Test.java | 2 +-
src/test/java/org/apache/commons/exec/issues/Exec49Test.java | 2 +-
src/test/java/org/apache/commons/exec/issues/Exec57Test.java | 2 +-
src/test/java/org/apache/commons/exec/issues/Exec60Test.java | 2 +-
src/test/java/org/apache/commons/exec/issues/Exec62Test.java | 2 +-
src/test/java/org/apache/commons/exec/issues/Exec65Test.java | 2 +-
.../org/apache/commons/exec/launcher/CommandLauncherFactoryTest.java | 2 +-
.../java/org/apache/commons/exec/launcher/CommandLauncherImplTest.java | 2 +-
.../org/apache/commons/exec/launcher/Java13CommandLauncherTest.java | 2 +-
.../java/org/apache/commons/exec/launcher/OS2CommandLauncherTest.java | 2 +-
.../java/org/apache/commons/exec/launcher/VmsCommandLauncherTest.java | 2 +-
.../java/org/apache/commons/exec/launcher/WinNTCommandLauncherTest.java | 2 +-
src/test/java/org/apache/commons/exec/util/MapUtilTest.java | 2 +-
src/test/java/org/apache/commons/exec/util/StringUtilTest.java | 2 +-
27 files changed, 27 insertions(+), 27 deletions(-)
diff --git a/src/test/java/org/apache/commons/exec/CommandLineTest.java
b/src/test/java/org/apache/commons/exec/CommandLineTest.java
index bd65231b..8ab44b0c 100644
--- a/src/test/java/org/apache/commons/exec/CommandLineTest.java
+++ b/src/test/java/org/apache/commons/exec/CommandLineTest.java
@@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test;
/**
*/
-public class CommandLineTest {
+class CommandLineTest {
@Test
void testAddArgument() {
diff --git a/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java
b/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java
index 24f08132..e28cf1a5 100644
--- a/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java
+++ b/src/test/java/org/apache/commons/exec/DefaultExecutorTest.java
@@ -56,7 +56,7 @@ import org.junitpioneer.jupiter.SetSystemProperty;
//turn on debug mode and throw an exception for each encountered problem
@SetSystemProperty(key = "org.apache.commons.exec.lenient", value = "false")
@SetSystemProperty(key = "org.apache.commons.exec.debug", value = "true")
-public class DefaultExecutorTest {
+class DefaultExecutorTest {
/** Maximum time to wait (15s) */
private static final int WAITFOR_TIMEOUT = 15_000;
diff --git a/src/test/java/org/apache/commons/exec/LogOutputStreamTest.java
b/src/test/java/org/apache/commons/exec/LogOutputStreamTest.java
index 4b9171f0..a158013d 100644
--- a/src/test/java/org/apache/commons/exec/LogOutputStreamTest.java
+++ b/src/test/java/org/apache/commons/exec/LogOutputStreamTest.java
@@ -38,7 +38,7 @@ import org.junitpioneer.jupiter.SetSystemProperty;
// turn on debug mode and throw an exception for each encountered problem
@SetSystemProperty(key = "org.apache.commons.exec.lenient", value = "false")
@SetSystemProperty(key = "org.apache.commons.exec.debug", value = "true")
-public class LogOutputStreamTest {
+class LogOutputStreamTest {
private static final class SystemLogOutputStream extends LogOutputStream {
diff --git a/src/test/java/org/apache/commons/exec/OSTest.java
b/src/test/java/org/apache/commons/exec/OSTest.java
index a9043d55..43cb1a64 100644
--- a/src/test/java/org/apache/commons/exec/OSTest.java
+++ b/src/test/java/org/apache/commons/exec/OSTest.java
@@ -28,7 +28,7 @@ import org.junit.jupiter.api.condition.EnabledOnOs;
/**
* Tests {@link OS}.
*/
-public class OSTest {
+class OSTest {
@Test
void testIsArch() {
diff --git a/src/test/java/org/apache/commons/exec/PumpStreamHandlerTest.java
b/src/test/java/org/apache/commons/exec/PumpStreamHandlerTest.java
index e122d7b7..ef6f6336 100644
--- a/src/test/java/org/apache/commons/exec/PumpStreamHandlerTest.java
+++ b/src/test/java/org/apache/commons/exec/PumpStreamHandlerTest.java
@@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests {@link PumpStreamHandler}.
*/
-public class PumpStreamHandlerTest {
+class PumpStreamHandlerTest {
@Test
void testSetStopTimeout() {
diff --git a/src/test/java/org/apache/commons/exec/StandAloneTest.java
b/src/test/java/org/apache/commons/exec/StandAloneTest.java
index a0c7209e..e0ffbf2f 100644
--- a/src/test/java/org/apache/commons/exec/StandAloneTest.java
+++ b/src/test/java/org/apache/commons/exec/StandAloneTest.java
@@ -35,7 +35,7 @@ import org.junitpioneer.jupiter.SetSystemProperty;
*/
@SetSystemProperty(key = "org.apache.commons.exec.lenient", value = "false")
@SetSystemProperty(key = "org.apache.commons.exec.debug", value = "true")
-public class StandAloneTest {
+class StandAloneTest {
@Test
@DisabledOnOs(org.junit.jupiter.api.condition.OS.WINDOWS)
diff --git a/src/test/java/org/apache/commons/exec/TimeoutObserverTest.java
b/src/test/java/org/apache/commons/exec/TimeoutObserverTest.java
index 9cc3af43..429dc6f9 100644
--- a/src/test/java/org/apache/commons/exec/TimeoutObserverTest.java
+++ b/src/test/java/org/apache/commons/exec/TimeoutObserverTest.java
@@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests {@link TimeoutObserver}.
*/
-public class TimeoutObserverTest {
+class TimeoutObserverTest {
static class TimeoutObserverFixture implements TimeoutObserver {
diff --git a/src/test/java/org/apache/commons/exec/TutorialTest.java
b/src/test/java/org/apache/commons/exec/TutorialTest.java
index 4c4fa76a..a24e7127 100644
--- a/src/test/java/org/apache/commons/exec/TutorialTest.java
+++ b/src/test/java/org/apache/commons/exec/TutorialTest.java
@@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test;
* <li>with the {@code exitValue} returned from the print script
* </ul>
*/
-public class TutorialTest {
+class TutorialTest {
private final class PrintResultHandler extends DefaultExecuteResultHandler
{
diff --git
a/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java
b/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java
index 62c6ad7e..0bc9bfdd 100644
---
a/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java
+++
b/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java
@@ -38,7 +38,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests {@link EnvironmentUtils}.
*/
-public class EnvironmentUtilsTest {
+class EnvironmentUtilsTest {
/**
* Accessing environment variables is case-sensitive or not depending on
the operating system but the values of the environment variable are always
diff --git a/src/test/java/org/apache/commons/exec/issues/Exec33Test.java
b/src/test/java/org/apache/commons/exec/issues/Exec33Test.java
index 297dece9..24bc9df4 100644
--- a/src/test/java/org/apache/commons/exec/issues/Exec33Test.java
+++ b/src/test/java/org/apache/commons/exec/issues/Exec33Test.java
@@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test;
*
* PumpStreamHandler hangs if System.in is redirect to process input stream.
*/
-public class Exec33Test {
+class Exec33Test {
private final Executor exec = DefaultExecutor.builder().get();
private final File testDir = new File("src/test/scripts");
diff --git a/src/test/java/org/apache/commons/exec/issues/Exec34Test.java
b/src/test/java/org/apache/commons/exec/issues/Exec34Test.java
index 659c4e60..68fd79a3 100644
--- a/src/test/java/org/apache/commons/exec/issues/Exec34Test.java
+++ b/src/test/java/org/apache/commons/exec/issues/Exec34Test.java
@@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test;
/**
* EXEC-34 https://issues.apache.org/jira/browse/EXEC-34
*/
-public class Exec34Test {
+class Exec34Test {
private final Executor exec = DefaultExecutor.builder().get();
private final File testDir = new File("src/test/scripts");
diff --git a/src/test/java/org/apache/commons/exec/issues/Exec36Test.java
b/src/test/java/org/apache/commons/exec/issues/Exec36Test.java
index d396d66b..543f666f 100644
--- a/src/test/java/org/apache/commons/exec/issues/Exec36Test.java
+++ b/src/test/java/org/apache/commons/exec/issues/Exec36Test.java
@@ -42,7 +42,7 @@ import org.junit.jupiter.api.condition.DisabledOnOs;
/**
* Test EXEC-36 see https://issues.apache.org/jira/browse/EXEC-36
*/
-public class Exec36Test {
+class Exec36Test {
private final Executor exec = DefaultExecutor.builder().get();
private final File testDir = new File("src/test/scripts");
diff --git a/src/test/java/org/apache/commons/exec/issues/Exec41Test.java
b/src/test/java/org/apache/commons/exec/issues/Exec41Test.java
index 24dbc464..22e705c6 100644
--- a/src/test/java/org/apache/commons/exec/issues/Exec41Test.java
+++ b/src/test/java/org/apache/commons/exec/issues/Exec41Test.java
@@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test;
/**
* Test the patch for EXEC-41 (https://issues.apache.org/jira/browse/EXEC-41).
*/
-public class Exec41Test {
+class Exec41Test {
private final File testDir = new File("src/test/scripts");
private final File pingScript = TestUtil.resolveScriptFileForOS(testDir +
"/ping");
diff --git a/src/test/java/org/apache/commons/exec/issues/Exec44Test.java
b/src/test/java/org/apache/commons/exec/issues/Exec44Test.java
index 468c7c39..80e83352 100644
--- a/src/test/java/org/apache/commons/exec/issues/Exec44Test.java
+++ b/src/test/java/org/apache/commons/exec/issues/Exec44Test.java
@@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test;
/**
* Test EXEC-44 (https://issues.apache.org/jira/browse/EXEC-44).
*/
-public class Exec44Test {
+class Exec44Test {
private final Executor exec = DefaultExecutor.builder().get();
private final File testDir = new File("src/test/scripts");
diff --git a/src/test/java/org/apache/commons/exec/issues/Exec49Test.java
b/src/test/java/org/apache/commons/exec/issues/Exec49Test.java
index 4c094cc2..ff4c9c46 100644
--- a/src/test/java/org/apache/commons/exec/issues/Exec49Test.java
+++ b/src/test/java/org/apache/commons/exec/issues/Exec49Test.java
@@ -35,7 +35,7 @@ import org.junit.jupiter.api.condition.DisabledOnOs;
/**
* Test EXEC-44 (https://issues.apache.org/jira/browse/EXEC-44).
*/
-public class Exec49Test {
+class Exec49Test {
private static final Duration WAIT = Duration.ofSeconds(10);
private final Executor exec = DefaultExecutor.builder().get();
diff --git a/src/test/java/org/apache/commons/exec/issues/Exec57Test.java
b/src/test/java/org/apache/commons/exec/issues/Exec57Test.java
index a34a5ee3..7c945b1e 100644
--- a/src/test/java/org/apache/commons/exec/issues/Exec57Test.java
+++ b/src/test/java/org/apache/commons/exec/issues/Exec57Test.java
@@ -34,7 +34,7 @@ import org.junit.jupiter.api.condition.DisabledOnOs;
/**
* Test EXEC-57 (https://issues.apache.org/jira/browse/EXEC-57).
*/
-public class Exec57Test extends AbstractExecTest {
+class Exec57Test extends AbstractExecTest {
/**
* DefaultExecutor.execute() does not return even if child process
terminated - in this case the child process hangs because the grand children is
connected
diff --git a/src/test/java/org/apache/commons/exec/issues/Exec60Test.java
b/src/test/java/org/apache/commons/exec/issues/Exec60Test.java
index ab49202f..e0380d7b 100644
--- a/src/test/java/org/apache/commons/exec/issues/Exec60Test.java
+++ b/src/test/java/org/apache/commons/exec/issues/Exec60Test.java
@@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test;
/**
* Test EXEC-60 (https://issues.apache.org/jira/browse/EXEC-60).
*/
-public class Exec60Test extends AbstractExecTest {
+class Exec60Test extends AbstractExecTest {
private final Executor exec = DefaultExecutor.builder().get();
private final File pingScript = resolveTestScript("ping");
diff --git a/src/test/java/org/apache/commons/exec/issues/Exec62Test.java
b/src/test/java/org/apache/commons/exec/issues/Exec62Test.java
index 713dc65a..794c3b05 100644
--- a/src/test/java/org/apache/commons/exec/issues/Exec62Test.java
+++ b/src/test/java/org/apache/commons/exec/issues/Exec62Test.java
@@ -41,7 +41,7 @@ import org.junit.jupiter.api.condition.DisabledOnOs;
/**
* @see <a href="https://issues.apache.org/jira/browse/EXEC-62";>EXEC-62</a>
*/
-public class Exec62Test {
+class Exec62Test {
private Path outputFile;
private void execute(final String scriptName) throws Exception {
diff --git a/src/test/java/org/apache/commons/exec/issues/Exec65Test.java
b/src/test/java/org/apache/commons/exec/issues/Exec65Test.java
index ca17a7db..0b7f05bd 100644
--- a/src/test/java/org/apache/commons/exec/issues/Exec65Test.java
+++ b/src/test/java/org/apache/commons/exec/issues/Exec65Test.java
@@ -43,7 +43,7 @@ import org.junit.jupiter.api.condition.EnabledOnOs;
*
* @see <a href="https://issues.apache.org/jira/browse/EXEC-65";>EXEC-65</a>
*/
-public class Exec65Test extends AbstractExecTest {
+class Exec65Test extends AbstractExecTest {
/**
* This test currently only works for macOS X
diff --git
a/src/test/java/org/apache/commons/exec/launcher/CommandLauncherFactoryTest.java
b/src/test/java/org/apache/commons/exec/launcher/CommandLauncherFactoryTest.java
index 7a3e290f..f31a3c3a 100644
---
a/src/test/java/org/apache/commons/exec/launcher/CommandLauncherFactoryTest.java
+++
b/src/test/java/org/apache/commons/exec/launcher/CommandLauncherFactoryTest.java
@@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test;
/**
* Tests {@link CommandLauncherFactory}.
*/
-public class CommandLauncherFactoryTest {
+class CommandLauncherFactoryTest {
@Test
void testCreateVMLauncher() throws Exception {
diff --git
a/src/test/java/org/apache/commons/exec/launcher/CommandLauncherImplTest.java
b/src/test/java/org/apache/commons/exec/launcher/CommandLauncherImplTest.java
index 4ddf6693..798f3363 100644
---
a/src/test/java/org/apache/commons/exec/launcher/CommandLauncherImplTest.java
+++
b/src/test/java/org/apache/commons/exec/launcher/CommandLauncherImplTest.java
@@ -25,7 +25,7 @@ import java.util.Map;
import org.apache.commons.exec.CommandLine;
-public class CommandLauncherImplTest extends
AbstractCommandLauncherTest<CommandLauncherImpl> {
+class CommandLauncherImplTest extends
AbstractCommandLauncherTest<CommandLauncherImpl> {
static class CommandLauncherImplFixture extends CommandLauncherImpl {
diff --git
a/src/test/java/org/apache/commons/exec/launcher/Java13CommandLauncherTest.java
b/src/test/java/org/apache/commons/exec/launcher/Java13CommandLauncherTest.java
index 85546db5..89a87648 100644
---
a/src/test/java/org/apache/commons/exec/launcher/Java13CommandLauncherTest.java
+++
b/src/test/java/org/apache/commons/exec/launcher/Java13CommandLauncherTest.java
@@ -19,7 +19,7 @@
package org.apache.commons.exec.launcher;
-public class Java13CommandLauncherTest extends
AbstractCommandLauncherTest<Java13CommandLauncher> {
+class Java13CommandLauncherTest extends
AbstractCommandLauncherTest<Java13CommandLauncher> {
@Override
Java13CommandLauncher createCommandLauncher() {
diff --git
a/src/test/java/org/apache/commons/exec/launcher/OS2CommandLauncherTest.java
b/src/test/java/org/apache/commons/exec/launcher/OS2CommandLauncherTest.java
index 7c13b8e1..73c9500f 100644
--- a/src/test/java/org/apache/commons/exec/launcher/OS2CommandLauncherTest.java
+++ b/src/test/java/org/apache/commons/exec/launcher/OS2CommandLauncherTest.java
@@ -19,7 +19,7 @@
package org.apache.commons.exec.launcher;
-public class OS2CommandLauncherTest extends
AbstractCommandLauncherTest<OS2CommandLauncher> {
+class OS2CommandLauncherTest extends
AbstractCommandLauncherTest<OS2CommandLauncher> {
@Override
OS2CommandLauncher createCommandLauncher() {
diff --git
a/src/test/java/org/apache/commons/exec/launcher/VmsCommandLauncherTest.java
b/src/test/java/org/apache/commons/exec/launcher/VmsCommandLauncherTest.java
index 0674465f..a6b0fd47 100644
--- a/src/test/java/org/apache/commons/exec/launcher/VmsCommandLauncherTest.java
+++ b/src/test/java/org/apache/commons/exec/launcher/VmsCommandLauncherTest.java
@@ -30,7 +30,7 @@ import java.util.Map;
import org.apache.commons.exec.CommandLine;
import org.junit.jupiter.api.Test;
-public class VmsCommandLauncherTest extends
AbstractCommandLauncherTest<VmsCommandLauncher> {
+class VmsCommandLauncherTest extends
AbstractCommandLauncherTest<VmsCommandLauncher> {
@Override
VmsCommandLauncher createCommandLauncher() {
diff --git
a/src/test/java/org/apache/commons/exec/launcher/WinNTCommandLauncherTest.java
b/src/test/java/org/apache/commons/exec/launcher/WinNTCommandLauncherTest.java
index 5e31ce2c..993e7cc0 100644
---
a/src/test/java/org/apache/commons/exec/launcher/WinNTCommandLauncherTest.java
+++
b/src/test/java/org/apache/commons/exec/launcher/WinNTCommandLauncherTest.java
@@ -19,7 +19,7 @@
package org.apache.commons.exec.launcher;
-public class WinNTCommandLauncherTest extends
AbstractCommandLauncherTest<WinNTCommandLauncher> {
+class WinNTCommandLauncherTest extends
AbstractCommandLauncherTest<WinNTCommandLauncher> {
@Override
WinNTCommandLauncher createCommandLauncher() {
diff --git a/src/test/java/org/apache/commons/exec/util/MapUtilTest.java
b/src/test/java/org/apache/commons/exec/util/MapUtilTest.java
index 91e09243..15e5fe19 100644
--- a/src/test/java/org/apache/commons/exec/util/MapUtilTest.java
+++ b/src/test/java/org/apache/commons/exec/util/MapUtilTest.java
@@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test;
/**
*/
-public class MapUtilTest {
+class MapUtilTest {
/**
* Test copying of map
diff --git a/src/test/java/org/apache/commons/exec/util/StringUtilTest.java
b/src/test/java/org/apache/commons/exec/util/StringUtilTest.java
index 070a3907..5ca3f90b 100644
--- a/src/test/java/org/apache/commons/exec/util/StringUtilTest.java
+++ b/src/test/java/org/apache/commons/exec/util/StringUtilTest.java
@@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test;
/**
*/
-public class StringUtilTest {
+class StringUtilTest {
/**
* Test a default string substitution, e.g. all placeholders are expanded.
*/
