This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-crypto.git
The following commit(s) were added to refs/heads/master by this push: new 1e63f4b4 Use JUnit 5 convention for class visibility 1e63f4b4 is described below commit 1e63f4b4fbb27f7dba23fde33cb68b921edb8f6e Author: Gary D. Gregory <garydgreg...@gmail.com> AuthorDate: Sun Jun 8 14:13:18 2025 -0400 Use JUnit 5 convention for class visibility --- src/test/java/org/apache/commons/crypto/CryptoTest.java | 2 +- src/test/java/org/apache/commons/crypto/NativeCodeLoaderTest.java | 2 +- src/test/java/org/apache/commons/crypto/OsInfoTest.java | 2 +- .../java/org/apache/commons/crypto/cipher/CryptoCipherFactoryTest.java | 2 +- src/test/java/org/apache/commons/crypto/cipher/CryptoCipherTest.java | 2 +- src/test/java/org/apache/commons/crypto/cipher/GcmCipherTest.java | 2 +- src/test/java/org/apache/commons/crypto/cipher/JceCipherTest.java | 2 +- src/test/java/org/apache/commons/crypto/cipher/OpenSslCipherTest.java | 2 +- .../java/org/apache/commons/crypto/cipher/OpenSslCommonModeTest.java | 2 +- .../org/apache/commons/crypto/jna/CbcNoPaddingCipherJnaStreamTest.java | 2 +- .../apache/commons/crypto/jna/CbcPkcs5PaddingCipherJnaStreamTest.java | 2 +- src/test/java/org/apache/commons/crypto/jna/CtrCryptoJnaStreamTest.java | 2 +- .../org/apache/commons/crypto/jna/CtrNoPaddingCipherJnaStreamTest.java | 2 +- src/test/java/org/apache/commons/crypto/jna/OpenSslJnaCipherTest.java | 2 +- .../java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRandomTest.java | 2 +- src/test/java/org/apache/commons/crypto/jna/OpenSslJnaTest.java | 2 +- src/test/java/org/apache/commons/crypto/jna/OpenSslNativeJnaTest.java | 2 +- .../apache/commons/crypto/jna/PositionedCryptoInputStreamJnaTest.java | 2 +- .../java/org/apache/commons/crypto/random/CryptoRandomFactoryTest.java | 2 +- .../java/org/apache/commons/crypto/random/JavaCryptoRandomTest.java | 2 +- .../java/org/apache/commons/crypto/random/OpenSslCryptoRandomTest.java | 2 +- src/test/java/org/apache/commons/crypto/random/OsCryptoRandomTest.java | 2 +- .../org/apache/commons/crypto/stream/CbcNoPaddingCipherStreamTest.java | 2 +- .../apache/commons/crypto/stream/CbcPkcs5PaddingCipherStreamTest.java | 2 +- src/test/java/org/apache/commons/crypto/stream/CtrCryptoStreamTest.java | 2 +- .../org/apache/commons/crypto/stream/CtrNoPaddingCipherStreamTest.java | 2 +- .../java/org/apache/commons/crypto/stream/input/ChannelInputTest.java | 2 +- .../java/org/apache/commons/crypto/stream/output/StreamOutputTest.java | 2 +- src/test/java/org/apache/commons/crypto/utils/EnumTest.java | 2 +- src/test/java/org/apache/commons/crypto/utils/UtilsTest.java | 2 +- 30 files changed, 30 insertions(+), 30 deletions(-) diff --git a/src/test/java/org/apache/commons/crypto/CryptoTest.java b/src/test/java/org/apache/commons/crypto/CryptoTest.java index 812b6dab..44f0bbbe 100644 --- a/src/test/java/org/apache/commons/crypto/CryptoTest.java +++ b/src/test/java/org/apache/commons/crypto/CryptoTest.java @@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test; -public class CryptoTest { +class CryptoTest { // If defined, then fail if the version does not match major/minor bits private static final String EXPECTED_VERSION_PROPERTY = "CryptoTest.expectedVersion"; diff --git a/src/test/java/org/apache/commons/crypto/NativeCodeLoaderTest.java b/src/test/java/org/apache/commons/crypto/NativeCodeLoaderTest.java index ff2abca2..313d0aeb 100644 --- a/src/test/java/org/apache/commons/crypto/NativeCodeLoaderTest.java +++ b/src/test/java/org/apache/commons/crypto/NativeCodeLoaderTest.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; -public class NativeCodeLoaderTest { +class NativeCodeLoaderTest { @Test void test() { diff --git a/src/test/java/org/apache/commons/crypto/OsInfoTest.java b/src/test/java/org/apache/commons/crypto/OsInfoTest.java index 4a5da730..5f6b83b9 100644 --- a/src/test/java/org/apache/commons/crypto/OsInfoTest.java +++ b/src/test/java/org/apache/commons/crypto/OsInfoTest.java @@ -21,7 +21,7 @@ import org.junit.jupiter.api.Test; -public class OsInfoTest { +class OsInfoTest { private static final String EXPECTED_PATH_PROPERTY = "OsInfoTest.expectedPath"; @Test diff --git a/src/test/java/org/apache/commons/crypto/cipher/CryptoCipherFactoryTest.java b/src/test/java/org/apache/commons/crypto/cipher/CryptoCipherFactoryTest.java index 2a232489..2224c442 100644 --- a/src/test/java/org/apache/commons/crypto/cipher/CryptoCipherFactoryTest.java +++ b/src/test/java/org/apache/commons/crypto/cipher/CryptoCipherFactoryTest.java @@ -27,7 +27,7 @@ import org.apache.commons.crypto.utils.AES; import org.junit.jupiter.api.Test; -public class CryptoCipherFactoryTest { +class CryptoCipherFactoryTest { @Test void testDefaultCipher() throws GeneralSecurityException, IOException { diff --git a/src/test/java/org/apache/commons/crypto/cipher/CryptoCipherTest.java b/src/test/java/org/apache/commons/crypto/cipher/CryptoCipherTest.java index 8d53f8ed..c8530914 100644 --- a/src/test/java/org/apache/commons/crypto/cipher/CryptoCipherTest.java +++ b/src/test/java/org/apache/commons/crypto/cipher/CryptoCipherTest.java @@ -27,7 +27,7 @@ /** * Tests default methods. */ -public class CryptoCipherTest { +class CryptoCipherTest { @Test void testUpdateAADByteArray() { diff --git a/src/test/java/org/apache/commons/crypto/cipher/GcmCipherTest.java b/src/test/java/org/apache/commons/crypto/cipher/GcmCipherTest.java index 1ad0f03d..9602cfe6 100644 --- a/src/test/java/org/apache/commons/crypto/cipher/GcmCipherTest.java +++ b/src/test/java/org/apache/commons/crypto/cipher/GcmCipherTest.java @@ -38,7 +38,7 @@ import jakarta.xml.bind.DatatypeConverter; -public class GcmCipherTest { +class GcmCipherTest { private static final String GCM_NO_PADDING = "AES/GCM/NoPadding"; Properties props; diff --git a/src/test/java/org/apache/commons/crypto/cipher/JceCipherTest.java b/src/test/java/org/apache/commons/crypto/cipher/JceCipherTest.java index 67f6c104..2d8c61ed 100644 --- a/src/test/java/org/apache/commons/crypto/cipher/JceCipherTest.java +++ b/src/test/java/org/apache/commons/crypto/cipher/JceCipherTest.java @@ -27,7 +27,7 @@ import org.apache.commons.crypto.utils.AES; import org.junit.jupiter.api.BeforeAll; -public class JceCipherTest extends AbstractCipherTest { +class JceCipherTest extends AbstractCipherTest { private static final int MAX_KEY_LEN_LOWER_BOUND = 256; diff --git a/src/test/java/org/apache/commons/crypto/cipher/OpenSslCipherTest.java b/src/test/java/org/apache/commons/crypto/cipher/OpenSslCipherTest.java index fb5f416d..5799a267 100644 --- a/src/test/java/org/apache/commons/crypto/cipher/OpenSslCipherTest.java +++ b/src/test/java/org/apache/commons/crypto/cipher/OpenSslCipherTest.java @@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Timeout; -public class OpenSslCipherTest extends AbstractCipherTest { +class OpenSslCipherTest extends AbstractCipherTest { private ByteBuffer dummyBuffer() { return ByteBuffer.allocateDirect(8); diff --git a/src/test/java/org/apache/commons/crypto/cipher/OpenSslCommonModeTest.java b/src/test/java/org/apache/commons/crypto/cipher/OpenSslCommonModeTest.java index 7d943b1c..6daf8f22 100644 --- a/src/test/java/org/apache/commons/crypto/cipher/OpenSslCommonModeTest.java +++ b/src/test/java/org/apache/commons/crypto/cipher/OpenSslCommonModeTest.java @@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test; -public class OpenSslCommonModeTest { +class OpenSslCommonModeTest { @Test void testUpdateAAD() { diff --git a/src/test/java/org/apache/commons/crypto/jna/CbcNoPaddingCipherJnaStreamTest.java b/src/test/java/org/apache/commons/crypto/jna/CbcNoPaddingCipherJnaStreamTest.java index 69439e37..02505180 100644 --- a/src/test/java/org/apache/commons/crypto/jna/CbcNoPaddingCipherJnaStreamTest.java +++ b/src/test/java/org/apache/commons/crypto/jna/CbcNoPaddingCipherJnaStreamTest.java @@ -19,7 +19,7 @@ import org.apache.commons.crypto.utils.AES; -public class CbcNoPaddingCipherJnaStreamTest extends AbstractCipherJnaStreamTest { +class CbcNoPaddingCipherJnaStreamTest extends AbstractCipherJnaStreamTest { @Override public void setUp() { diff --git a/src/test/java/org/apache/commons/crypto/jna/CbcPkcs5PaddingCipherJnaStreamTest.java b/src/test/java/org/apache/commons/crypto/jna/CbcPkcs5PaddingCipherJnaStreamTest.java index 2d78e2a8..58c690b4 100644 --- a/src/test/java/org/apache/commons/crypto/jna/CbcPkcs5PaddingCipherJnaStreamTest.java +++ b/src/test/java/org/apache/commons/crypto/jna/CbcPkcs5PaddingCipherJnaStreamTest.java @@ -19,7 +19,7 @@ import org.apache.commons.crypto.utils.AES; -public class CbcPkcs5PaddingCipherJnaStreamTest extends AbstractCipherJnaStreamTest { +class CbcPkcs5PaddingCipherJnaStreamTest extends AbstractCipherJnaStreamTest { @Override public void setUp() { diff --git a/src/test/java/org/apache/commons/crypto/jna/CtrCryptoJnaStreamTest.java b/src/test/java/org/apache/commons/crypto/jna/CtrCryptoJnaStreamTest.java index 917552cc..52a48a69 100644 --- a/src/test/java/org/apache/commons/crypto/jna/CtrCryptoJnaStreamTest.java +++ b/src/test/java/org/apache/commons/crypto/jna/CtrCryptoJnaStreamTest.java @@ -19,7 +19,7 @@ import org.apache.commons.crypto.utils.AES; -public class CtrCryptoJnaStreamTest extends AbstractCipherJnaStreamTest { +class CtrCryptoJnaStreamTest extends AbstractCipherJnaStreamTest { @Override public void setUp() { diff --git a/src/test/java/org/apache/commons/crypto/jna/CtrNoPaddingCipherJnaStreamTest.java b/src/test/java/org/apache/commons/crypto/jna/CtrNoPaddingCipherJnaStreamTest.java index 123cd7c1..54ca8e28 100644 --- a/src/test/java/org/apache/commons/crypto/jna/CtrNoPaddingCipherJnaStreamTest.java +++ b/src/test/java/org/apache/commons/crypto/jna/CtrNoPaddingCipherJnaStreamTest.java @@ -19,7 +19,7 @@ import org.apache.commons.crypto.utils.AES; -public class CtrNoPaddingCipherJnaStreamTest extends AbstractCipherJnaStreamTest { +class CtrNoPaddingCipherJnaStreamTest extends AbstractCipherJnaStreamTest { @Override public void setUp() { diff --git a/src/test/java/org/apache/commons/crypto/jna/OpenSslJnaCipherTest.java b/src/test/java/org/apache/commons/crypto/jna/OpenSslJnaCipherTest.java index 9b1380c2..5e6c103f 100644 --- a/src/test/java/org/apache/commons/crypto/jna/OpenSslJnaCipherTest.java +++ b/src/test/java/org/apache/commons/crypto/jna/OpenSslJnaCipherTest.java @@ -22,7 +22,7 @@ import org.apache.commons.crypto.cipher.AbstractCipherTest; -public class OpenSslJnaCipherTest extends AbstractCipherTest { +class OpenSslJnaCipherTest extends AbstractCipherTest { @Override public void init() { diff --git a/src/test/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRandomTest.java b/src/test/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRandomTest.java index 96ef918f..242c2f5e 100644 --- a/src/test/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRandomTest.java +++ b/src/test/java/org/apache/commons/crypto/jna/OpenSslJnaCryptoRandomTest.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Assumptions; import org.junit.jupiter.api.BeforeEach; -public class OpenSslJnaCryptoRandomTest extends AbstractRandomTest { +class OpenSslJnaCryptoRandomTest extends AbstractRandomTest { @Override public CryptoRandom getCryptoRandom() throws GeneralSecurityException { diff --git a/src/test/java/org/apache/commons/crypto/jna/OpenSslJnaTest.java b/src/test/java/org/apache/commons/crypto/jna/OpenSslJnaTest.java index 46ba7398..590a0d0d 100644 --- a/src/test/java/org/apache/commons/crypto/jna/OpenSslJnaTest.java +++ b/src/test/java/org/apache/commons/crypto/jna/OpenSslJnaTest.java @@ -21,7 +21,7 @@ import org.junit.jupiter.api.Test; -public class OpenSslJnaTest { +class OpenSslJnaTest { // If defined, then fail if the version does not match major/minor bits private static final String EXPECTED_VERSION_PROPERTY = "OpenSslJnaTest.expectedVersion"; diff --git a/src/test/java/org/apache/commons/crypto/jna/OpenSslNativeJnaTest.java b/src/test/java/org/apache/commons/crypto/jna/OpenSslNativeJnaTest.java index c6dc0286..bf334f50 100644 --- a/src/test/java/org/apache/commons/crypto/jna/OpenSslNativeJnaTest.java +++ b/src/test/java/org/apache/commons/crypto/jna/OpenSslNativeJnaTest.java @@ -23,7 +23,7 @@ import org.junit.jupiter.api.Test; import org.junit.jupiter.api.TestReporter; -public class OpenSslNativeJnaTest { +class OpenSslNativeJnaTest { @Test void test(final TestReporter reporter) { diff --git a/src/test/java/org/apache/commons/crypto/jna/PositionedCryptoInputStreamJnaTest.java b/src/test/java/org/apache/commons/crypto/jna/PositionedCryptoInputStreamJnaTest.java index 66c4f84e..cba5ebde 100644 --- a/src/test/java/org/apache/commons/crypto/jna/PositionedCryptoInputStreamJnaTest.java +++ b/src/test/java/org/apache/commons/crypto/jna/PositionedCryptoInputStreamJnaTest.java @@ -24,7 +24,7 @@ /** */ -public class PositionedCryptoInputStreamJnaTest extends PositionedCryptoInputStreamTest { +class PositionedCryptoInputStreamJnaTest extends PositionedCryptoInputStreamTest { @BeforeEach public void init() { diff --git a/src/test/java/org/apache/commons/crypto/random/CryptoRandomFactoryTest.java b/src/test/java/org/apache/commons/crypto/random/CryptoRandomFactoryTest.java index e09159c8..81e4bbc6 100644 --- a/src/test/java/org/apache/commons/crypto/random/CryptoRandomFactoryTest.java +++ b/src/test/java/org/apache/commons/crypto/random/CryptoRandomFactoryTest.java @@ -30,7 +30,7 @@ import org.apache.commons.lang3.SystemProperties; import org.junit.jupiter.api.Test; -public class CryptoRandomFactoryTest { +class CryptoRandomFactoryTest { @Test void testAbstractRandom() { diff --git a/src/test/java/org/apache/commons/crypto/random/JavaCryptoRandomTest.java b/src/test/java/org/apache/commons/crypto/random/JavaCryptoRandomTest.java index 359d669a..0a26b3ad 100644 --- a/src/test/java/org/apache/commons/crypto/random/JavaCryptoRandomTest.java +++ b/src/test/java/org/apache/commons/crypto/random/JavaCryptoRandomTest.java @@ -22,7 +22,7 @@ import java.security.GeneralSecurityException; import java.util.Properties; -public class JavaCryptoRandomTest extends AbstractRandomTest { +class JavaCryptoRandomTest extends AbstractRandomTest { @Override public CryptoRandom getCryptoRandom() throws GeneralSecurityException { diff --git a/src/test/java/org/apache/commons/crypto/random/OpenSslCryptoRandomTest.java b/src/test/java/org/apache/commons/crypto/random/OpenSslCryptoRandomTest.java index 09dac85a..558ac2ca 100644 --- a/src/test/java/org/apache/commons/crypto/random/OpenSslCryptoRandomTest.java +++ b/src/test/java/org/apache/commons/crypto/random/OpenSslCryptoRandomTest.java @@ -26,7 +26,7 @@ import org.apache.commons.crypto.Crypto; import org.junit.jupiter.api.BeforeAll; -public class OpenSslCryptoRandomTest extends AbstractRandomTest { +class OpenSslCryptoRandomTest extends AbstractRandomTest { @BeforeAll public static void beforeAll() { diff --git a/src/test/java/org/apache/commons/crypto/random/OsCryptoRandomTest.java b/src/test/java/org/apache/commons/crypto/random/OsCryptoRandomTest.java index d6a09f3d..6d3d3d9d 100644 --- a/src/test/java/org/apache/commons/crypto/random/OsCryptoRandomTest.java +++ b/src/test/java/org/apache/commons/crypto/random/OsCryptoRandomTest.java @@ -30,7 +30,7 @@ import org.apache.commons.lang3.SystemProperties; import org.junit.jupiter.api.Test; -public class OsCryptoRandomTest extends AbstractRandomTest { +class OsCryptoRandomTest extends AbstractRandomTest { @Override public CryptoRandom getCryptoRandom() throws GeneralSecurityException { diff --git a/src/test/java/org/apache/commons/crypto/stream/CbcNoPaddingCipherStreamTest.java b/src/test/java/org/apache/commons/crypto/stream/CbcNoPaddingCipherStreamTest.java index 3aa6deef..df212062 100644 --- a/src/test/java/org/apache/commons/crypto/stream/CbcNoPaddingCipherStreamTest.java +++ b/src/test/java/org/apache/commons/crypto/stream/CbcNoPaddingCipherStreamTest.java @@ -19,7 +19,7 @@ import org.apache.commons.crypto.utils.AES; -public class CbcNoPaddingCipherStreamTest extends AbstractCipherStreamTest { +class CbcNoPaddingCipherStreamTest extends AbstractCipherStreamTest { @Override public void setUp() { diff --git a/src/test/java/org/apache/commons/crypto/stream/CbcPkcs5PaddingCipherStreamTest.java b/src/test/java/org/apache/commons/crypto/stream/CbcPkcs5PaddingCipherStreamTest.java index 57a0445b..fd0104cf 100644 --- a/src/test/java/org/apache/commons/crypto/stream/CbcPkcs5PaddingCipherStreamTest.java +++ b/src/test/java/org/apache/commons/crypto/stream/CbcPkcs5PaddingCipherStreamTest.java @@ -19,7 +19,7 @@ import org.apache.commons.crypto.utils.AES; -public class CbcPkcs5PaddingCipherStreamTest extends AbstractCipherStreamTest { +class CbcPkcs5PaddingCipherStreamTest extends AbstractCipherStreamTest { @Override public void setUp() { diff --git a/src/test/java/org/apache/commons/crypto/stream/CtrCryptoStreamTest.java b/src/test/java/org/apache/commons/crypto/stream/CtrCryptoStreamTest.java index 83409c9c..e2c89766 100644 --- a/src/test/java/org/apache/commons/crypto/stream/CtrCryptoStreamTest.java +++ b/src/test/java/org/apache/commons/crypto/stream/CtrCryptoStreamTest.java @@ -43,7 +43,7 @@ import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Timeout; -public class CtrCryptoStreamTest extends AbstractCipherStreamTest { +class CtrCryptoStreamTest extends AbstractCipherStreamTest { protected void doDecryptTest(final String cipherClass, final boolean withChannel) throws IOException { diff --git a/src/test/java/org/apache/commons/crypto/stream/CtrNoPaddingCipherStreamTest.java b/src/test/java/org/apache/commons/crypto/stream/CtrNoPaddingCipherStreamTest.java index 0c0c7f93..09c8aa8a 100644 --- a/src/test/java/org/apache/commons/crypto/stream/CtrNoPaddingCipherStreamTest.java +++ b/src/test/java/org/apache/commons/crypto/stream/CtrNoPaddingCipherStreamTest.java @@ -19,7 +19,7 @@ import org.apache.commons.crypto.utils.AES; -public class CtrNoPaddingCipherStreamTest extends AbstractCipherStreamTest { +class CtrNoPaddingCipherStreamTest extends AbstractCipherStreamTest { @Override public void setUp() { diff --git a/src/test/java/org/apache/commons/crypto/stream/input/ChannelInputTest.java b/src/test/java/org/apache/commons/crypto/stream/input/ChannelInputTest.java index ebdd25a9..b44bf37c 100644 --- a/src/test/java/org/apache/commons/crypto/stream/input/ChannelInputTest.java +++ b/src/test/java/org/apache/commons/crypto/stream/input/ChannelInputTest.java @@ -29,7 +29,7 @@ /** * Tests {@link ChannelInput}. */ -public class ChannelInputTest { +class ChannelInputTest { @Test void testSkipWithSkipBuffer() throws IOException { diff --git a/src/test/java/org/apache/commons/crypto/stream/output/StreamOutputTest.java b/src/test/java/org/apache/commons/crypto/stream/output/StreamOutputTest.java index 9973b1b3..6181e7b0 100644 --- a/src/test/java/org/apache/commons/crypto/stream/output/StreamOutputTest.java +++ b/src/test/java/org/apache/commons/crypto/stream/output/StreamOutputTest.java @@ -28,7 +28,7 @@ /** * Tests {@link StreamOutput}. */ -public class StreamOutputTest { +class StreamOutputTest { @Test void testGetOut() throws IOException { diff --git a/src/test/java/org/apache/commons/crypto/utils/EnumTest.java b/src/test/java/org/apache/commons/crypto/utils/EnumTest.java index bc6d58a9..ffcb408b 100644 --- a/src/test/java/org/apache/commons/crypto/utils/EnumTest.java +++ b/src/test/java/org/apache/commons/crypto/utils/EnumTest.java @@ -31,7 +31,7 @@ /** * Test the enums used to define the internal implementation classes */ -public class EnumTest { +class EnumTest { private void checkImplClass(final CipherProvider value) { final Class<? extends CryptoCipher> implClass = value.getImplClass(); diff --git a/src/test/java/org/apache/commons/crypto/utils/UtilsTest.java b/src/test/java/org/apache/commons/crypto/utils/UtilsTest.java index 0ec7f912..9f952dc1 100644 --- a/src/test/java/org/apache/commons/crypto/utils/UtilsTest.java +++ b/src/test/java/org/apache/commons/crypto/utils/UtilsTest.java @@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test; -public class UtilsTest { +class UtilsTest { @Test void testGetProperties() { final Properties props = new Properties();