This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-codec.git
The following commit(s) were added to refs/heads/master by this push: new 6cb7d153 Use JUnit 5 convention for test method visibility 6cb7d153 is described below commit 6cb7d153cd8be2938d0e528a71a880c677d7a1ac Author: Gary D. Gregory <garydgreg...@gmail.com> AuthorDate: Sat Jun 7 10:03:46 2025 -0400 Use JUnit 5 convention for test method visibility --- .../org/apache/commons/codec/ResourcesTest.java | 2 +- .../codec/binary/Base32InputStreamTest.java | 6 ++-- .../codec/binary/Base32OutputStreamTest.java | 2 +- .../apache/commons/codec/binary/Base64Test.java | 2 +- .../commons/codec/binary/BaseNCodecTest.java | 28 ++++++++--------- .../org/apache/commons/codec/binary/HexTest.java | 4 +-- .../commons/codec/digest/HmacAlgorithmsTest.java | 36 +++++++++++----------- .../codec/digest/MessageDigestAlgorithmsTest.java | 18 +++++------ .../commons/codec/digest/Sha512CryptTest.java | 2 +- .../codec/language/ColognePhoneticTest.java | 2 +- .../codec/language/DaitchMokotoffSoundexTest.java | 2 +- .../apache/commons/codec/language/SoundexTest.java | 4 +-- .../codec/language/bm/BeiderMorseEncoderTest.java | 2 +- .../codec/language/bm/LanguageGuessingTest.java | 2 +- .../codec/language/bm/PhoneticEngineTest.java | 4 +-- .../apache/commons/codec/net/PercentCodecTest.java | 2 +- 16 files changed, 59 insertions(+), 59 deletions(-) diff --git a/src/test/java/org/apache/commons/codec/ResourcesTest.java b/src/test/java/org/apache/commons/codec/ResourcesTest.java index eccd7415..6e521d52 100644 --- a/src/test/java/org/apache/commons/codec/ResourcesTest.java +++ b/src/test/java/org/apache/commons/codec/ResourcesTest.java @@ -36,7 +36,7 @@ public class ResourcesTest { @ParameterizedTest @MethodSource("getResourceNames") - public void testGetInputStream(final String resName) throws IOException { + void testGetInputStream(final String resName) throws IOException { try (InputStream in = Resources.getInputStream(resName)) { // empty } diff --git a/src/test/java/org/apache/commons/codec/binary/Base32InputStreamTest.java b/src/test/java/org/apache/commons/codec/binary/Base32InputStreamTest.java index 75c7847b..d3f04e44 100644 --- a/src/test/java/org/apache/commons/codec/binary/Base32InputStreamTest.java +++ b/src/test/java/org/apache/commons/codec/binary/Base32InputStreamTest.java @@ -78,7 +78,7 @@ public class Base32InputStreamTest { // * @throws Exception for some failure scenarios. // */ // @Test - // public void testCodec101() throws Exception { + // void testCodec101() throws Exception { // byte[] codec101 = StringUtils.getBytesUtf8(Base32TestData.CODEC_101_MULTIPLE_OF_3); // ByteArrayInputStream bais = new ByteArrayInputStream(codec101); // Base32InputStream in = new Base32InputStream(bais); @@ -106,7 +106,7 @@ public class Base32InputStreamTest { * for some failure scenarios. */ // @Test - // public void testInputStreamReader() throws Exception { + // void testInputStreamReader() throws Exception { // byte[] codec101 = StringUtils.getBytesUtf8(Base32TestData.CODEC_101_MULTIPLE_OF_3); // ByteArrayInputStream bais = new ByteArrayInputStream(codec101); // Base32InputStream in = new Base32InputStream(bais); @@ -123,7 +123,7 @@ public class Base32InputStreamTest { * for some failure scenarios. */ // @Test - // public void testCodec98NPE() throws Exception { + // void testCodec98NPE() throws Exception { // byte[] codec98 = StringUtils.getBytesUtf8(Base32TestData.CODEC_98_NPE); // ByteArrayInputStream data = new ByteArrayInputStream(codec98); // Base32InputStream stream = new Base32InputStream(data); diff --git a/src/test/java/org/apache/commons/codec/binary/Base32OutputStreamTest.java b/src/test/java/org/apache/commons/codec/binary/Base32OutputStreamTest.java index cd913b20..276a9256 100644 --- a/src/test/java/org/apache/commons/codec/binary/Base32OutputStreamTest.java +++ b/src/test/java/org/apache/commons/codec/binary/Base32OutputStreamTest.java @@ -44,7 +44,7 @@ public class Base32OutputStreamTest { // * @throws Exception for some failure scenarios. // */ // @Test -// public void testCodec98NPE() throws Exception { +// void testCodec98NPE() throws Exception { // byte[] codec98 = StringUtils.getBytesUtf8(Base32TestData.CODEC_98_NPE); // byte[] codec98_1024 = new byte[1024]; // System.arraycopy(codec98, 0, codec98_1024, 0, codec98.length); diff --git a/src/test/java/org/apache/commons/codec/binary/Base64Test.java b/src/test/java/org/apache/commons/codec/binary/Base64Test.java index 2a25e076..06c87737 100644 --- a/src/test/java/org/apache/commons/codec/binary/Base64Test.java +++ b/src/test/java/org/apache/commons/codec/binary/Base64Test.java @@ -309,7 +309,7 @@ public class Base64Test { * Tests <a href="https://issues.apache.org/jira/browse/CODEC-263">CODEC-263</a>. */ @Test - public void testCodec263() { + void testCodec263() { Base64.decodeBase64("publishMessage"); assertTrue(Base64.isBase64("publishMessage")); } diff --git a/src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java b/src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java index df33700a..4aca07c0 100644 --- a/src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java +++ b/src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java @@ -200,7 +200,7 @@ public class BaseNCodecTest { } // @Test -// public void testGetEncodedLength() { +// void testGetEncodedLength() { // fail("Not yet implemented"); // } @@ -272,47 +272,47 @@ public class BaseNCodecTest { // // @Test -// public void testEncodeObject() { +// void testEncodeObject() { // fail("Not yet implemented"); // } // // @Test -// public void testEncodeToString() { +// void testEncodeToString() { // fail("Not yet implemented"); // } // // @Test -// public void testDecodeObject() { +// void testDecodeObject() { // fail("Not yet implemented"); // } // // @Test -// public void testDecodeString() { +// void testDecodeString() { // fail("Not yet implemented"); // } // // @Test -// public void testDecodeByteArray() { +// void testDecodeByteArray() { // fail("Not yet implemented"); // } // // @Test -// public void testEncodeByteArray() { +// void testEncodeByteArray() { // fail("Not yet implemented"); // } // // @Test -// public void testEncodeAsString() { +// void testEncodeAsString() { // fail("Not yet implemented"); // } // // @Test -// public void testEncodeByteArrayIntInt() { +// void testEncodeByteArrayIntInt() { // fail("Not yet implemented"); // } // // @Test -// public void testDecodeByteArrayIntInt() { +// void testDecodeByteArrayIntInt() { // fail("Not yet implemented"); // } // @@ -343,22 +343,22 @@ public class BaseNCodecTest { } // @Test -// public void testHasData() { +// void testHasData() { // fail("Not yet implemented"); // } // // @Test -// public void testAvail() { +// void testAvail() { // fail("Not yet implemented"); // } // // @Test -// public void testEnsureBufferSize() { +// void testEnsureBufferSize() { // fail("Not yet implemented"); // } // // @Test -// public void testReadResults() { +// void testReadResults() { // fail("Not yet implemented"); // } // diff --git a/src/test/java/org/apache/commons/codec/binary/HexTest.java b/src/test/java/org/apache/commons/codec/binary/HexTest.java index 625dc77d..4556f8e3 100644 --- a/src/test/java/org/apache/commons/codec/binary/HexTest.java +++ b/src/test/java/org/apache/commons/codec/binary/HexTest.java @@ -187,7 +187,7 @@ public class HexTest { @ParameterizedTest @MethodSource("org.apache.commons.codec.CharsetsTest#getAvailableCharsetNames()") - public void testCustomCharset(final String name) throws UnsupportedEncodingException, DecoderException { + void testCustomCharset(final String name) throws UnsupportedEncodingException, DecoderException { testCharset(name, "testCustomCharset"); } @@ -666,7 +666,7 @@ public class HexTest { @ParameterizedTest @MethodSource("org.apache.commons.codec.CharsetsTest#getRequiredCharsets()") - public void testRequiredCharset(final Charset charset) throws UnsupportedEncodingException, DecoderException { + void testRequiredCharset(final Charset charset) throws UnsupportedEncodingException, DecoderException { testCharset(charset.name(), "testRequiredCharset"); } } diff --git a/src/test/java/org/apache/commons/codec/digest/HmacAlgorithmsTest.java b/src/test/java/org/apache/commons/codec/digest/HmacAlgorithmsTest.java index 43f6a92a..a5a6d1f3 100644 --- a/src/test/java/org/apache/commons/codec/digest/HmacAlgorithmsTest.java +++ b/src/test/java/org/apache/commons/codec/digest/HmacAlgorithmsTest.java @@ -135,7 +135,7 @@ public class HmacAlgorithmsTest { @ParameterizedTest @MethodSource("data") - public void testAlgorithm(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) + void testAlgorithm(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) throws NoSuchAlgorithmException { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); final String algorithm = hmacAlgorithm.getName(); @@ -147,63 +147,63 @@ public class HmacAlgorithmsTest { @ParameterizedTest @MethodSource("data") - public void testGetHmacEmptyKey(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { + void testGetHmacEmptyKey(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); assertThrows(IllegalArgumentException.class, () -> HmacUtils.getInitializedMac(hmacAlgorithm, EMPTY_BYTE_ARRAY)); } @ParameterizedTest @MethodSource("data") - public void testGetHmacNullKey(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { + void testGetHmacNullKey(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); assertThrows(IllegalArgumentException.class, () -> HmacUtils.getInitializedMac(hmacAlgorithm, null)); } @ParameterizedTest @MethodSource("data") - public void testHmacFailByteArray(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { + void testHmacFailByteArray(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); assertThrows(IllegalArgumentException.class, () -> new HmacUtils(hmacAlgorithm, (byte[]) null).hmac(STANDARD_PHRASE_BYTES)); } @ParameterizedTest @MethodSource("data") - public void testHmacFailInputStream(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { + void testHmacFailInputStream(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); assertThrows(IllegalArgumentException.class, () -> new HmacUtils(hmacAlgorithm, (byte[]) null).hmac(new ByteArrayInputStream(STANDARD_PHRASE_BYTES))); } @ParameterizedTest @MethodSource("data") - public void testHmacFailString(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { + void testHmacFailString(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); assertThrows(IllegalArgumentException.class, () -> new HmacUtils(hmacAlgorithm, (String) null).hmac(STANDARD_PHRASE_STRING)); } @ParameterizedTest @MethodSource("data") - public void testHmacHexFailByteArray(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { + void testHmacHexFailByteArray(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); assertThrows(IllegalArgumentException.class, () -> new HmacUtils(hmacAlgorithm, (byte[]) null).hmac(STANDARD_PHRASE_BYTES)); } @ParameterizedTest @MethodSource("data") - public void testHmacHexFailInputStream(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { + void testHmacHexFailInputStream(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); assertThrows(IllegalArgumentException.class, () -> new HmacUtils(hmacAlgorithm, (byte[]) null).hmac(new ByteArrayInputStream(STANDARD_PHRASE_BYTES))); } @ParameterizedTest @MethodSource("data") - public void testHmacHexFailString(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { + void testHmacHexFailString(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); assertThrows(IllegalArgumentException.class, () -> new HmacUtils(hmacAlgorithm, (String) null).hmac(STANDARD_PHRASE_STRING)); } @ParameterizedTest @MethodSource("data") - public void testInitializedMac(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { + void testInitializedMac(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); final Mac mac = HmacUtils.getInitializedMac(hmacAlgorithm, STANDARD_KEY_BYTES); final Mac mac2 = HmacUtils.getInitializedMac(hmacAlgorithm.getName(), STANDARD_KEY_BYTES); @@ -213,21 +213,21 @@ public class HmacAlgorithmsTest { @ParameterizedTest @MethodSource("data") - public void testMacByteArray(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { + void testMacByteArray(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); assertArrayEquals(standardResultBytes, new HmacUtils(hmacAlgorithm, STANDARD_KEY_BYTES).hmac(STANDARD_PHRASE_BYTES)); } @ParameterizedTest @MethodSource("data") - public void testMacHexByteArray(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { + void testMacHexByteArray(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); assertEquals(standardResultString, new HmacUtils(hmacAlgorithm, STANDARD_KEY_BYTES).hmacHex(STANDARD_PHRASE_BYTES)); } @ParameterizedTest @MethodSource("data") - public void testMacHexFile(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) + void testMacHexFile(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) throws IOException { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); assertEquals(standardResultString, new HmacUtils(hmacAlgorithm, STANDARD_KEY_BYTES).hmacHex(TempFile.toFile())); @@ -235,7 +235,7 @@ public class HmacAlgorithmsTest { @ParameterizedTest @MethodSource("data") - public void testMacHexPath(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) + void testMacHexPath(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) throws IOException { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); assertEquals(standardResultString, new HmacUtils(hmacAlgorithm, STANDARD_KEY_BYTES).hmacHex(TempFile)); @@ -243,7 +243,7 @@ public class HmacAlgorithmsTest { @ParameterizedTest @MethodSource("data") - public void testMacHexInputStream(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) + void testMacHexInputStream(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) throws IOException { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); assertEquals(standardResultString, new HmacUtils(hmacAlgorithm, STANDARD_KEY_BYTES).hmacHex(new ByteArrayInputStream(STANDARD_PHRASE_BYTES))); @@ -251,21 +251,21 @@ public class HmacAlgorithmsTest { @ParameterizedTest @MethodSource("data") - public void testMacHexString(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { + void testMacHexString(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); assertEquals(standardResultString, new HmacUtils(hmacAlgorithm, STANDARD_KEY_BYTES).hmacHex(STANDARD_PHRASE_STRING)); } @ParameterizedTest @MethodSource("data") - public void testMacInputStream(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) throws IOException { + void testMacInputStream(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) throws IOException { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); assertArrayEquals(standardResultBytes, new HmacUtils(hmacAlgorithm, STANDARD_KEY_BYTES).hmac(new ByteArrayInputStream(STANDARD_PHRASE_BYTES))); } @ParameterizedTest @MethodSource("data") - public void testMacString(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { + void testMacString(final HmacAlgorithms hmacAlgorithm, final byte[] standardResultBytes, final String standardResultString) { assumeTrue(HmacUtils.isAvailable(hmacAlgorithm)); assertArrayEquals(standardResultBytes, new HmacUtils(hmacAlgorithm, STANDARD_KEY_BYTES).hmac(STANDARD_PHRASE_STRING)); } diff --git a/src/test/java/org/apache/commons/codec/digest/MessageDigestAlgorithmsTest.java b/src/test/java/org/apache/commons/codec/digest/MessageDigestAlgorithmsTest.java index f98084b6..6b1b55db 100644 --- a/src/test/java/org/apache/commons/codec/digest/MessageDigestAlgorithmsTest.java +++ b/src/test/java/org/apache/commons/codec/digest/MessageDigestAlgorithmsTest.java @@ -125,7 +125,7 @@ public class MessageDigestAlgorithmsTest { @ParameterizedTest @MethodSource("data") - public void testAlgorithm(final String messageDigestAlgorithm) throws NoSuchAlgorithmException { + void testAlgorithm(final String messageDigestAlgorithm) throws NoSuchAlgorithmException { final String algorithm = messageDigestAlgorithm; assertNotNull(algorithm); assertFalse(algorithm.isEmpty()); @@ -135,7 +135,7 @@ public class MessageDigestAlgorithmsTest { @ParameterizedTest @MethodSource("data") - public void testDigestByteArray(final String messageDigestAlgorithm) { + void testDigestByteArray(final String messageDigestAlgorithm) { assumeTrue(DigestUtils.isAvailable(messageDigestAlgorithm)); assertArrayEquals(digestTestData(messageDigestAlgorithm), DigestUtils.digest(DigestUtils.getDigest(messageDigestAlgorithm), getTestData())); assertArrayEquals(digestTestData(messageDigestAlgorithm), DigestUtils.digest(DigestUtils.getDigest(messageDigestAlgorithm), getTestData())); @@ -143,7 +143,7 @@ public class MessageDigestAlgorithmsTest { @ParameterizedTest @MethodSource("data") - public void testDigestByteBuffer(final String messageDigestAlgorithm) { + void testDigestByteBuffer(final String messageDigestAlgorithm) { assumeTrue(DigestUtils.isAvailable(messageDigestAlgorithm)); assertArrayEquals(digestTestData(messageDigestAlgorithm), DigestUtils.digest(DigestUtils.getDigest(messageDigestAlgorithm), ByteBuffer.wrap(getTestData()))); @@ -153,7 +153,7 @@ public class MessageDigestAlgorithmsTest { @ParameterizedTest @MethodSource("data") - public void testDigestFile(final String messageDigestAlgorithm) throws IOException { + void testDigestFile(final String messageDigestAlgorithm) throws IOException { assumeTrue(DigestUtils.isAvailable(messageDigestAlgorithm)); assertArrayEquals(digestTestData(messageDigestAlgorithm), DigestUtils.digest(DigestUtils.getDigest(messageDigestAlgorithm), getTestFile())); assertArrayEquals(digestTestData(messageDigestAlgorithm), DigestUtils.digest(DigestUtils.getDigest(messageDigestAlgorithm), getTestFile())); @@ -161,7 +161,7 @@ public class MessageDigestAlgorithmsTest { @ParameterizedTest @MethodSource("data") - public void testDigestInputStream(final String messageDigestAlgorithm) throws IOException { + void testDigestInputStream(final String messageDigestAlgorithm) throws IOException { assumeTrue(DigestUtils.isAvailable(messageDigestAlgorithm)); assertArrayEquals(digestTestData(messageDigestAlgorithm), DigestUtils.digest(DigestUtils.getDigest(messageDigestAlgorithm), new ByteArrayInputStream(getTestData()))); @@ -179,19 +179,19 @@ public class MessageDigestAlgorithmsTest { @ParameterizedTest @MethodSource("data") - public void testDigestPathOpenOptionsEmpty(final String messageDigestAlgorithm) throws IOException { + void testDigestPathOpenOptionsEmpty(final String messageDigestAlgorithm) throws IOException { testDigestPath(messageDigestAlgorithm); } @ParameterizedTest @MethodSource("data") - public void testDigestPathStandardOpenOptionRead(final String messageDigestAlgorithm) throws IOException { + void testDigestPathStandardOpenOptionRead(final String messageDigestAlgorithm) throws IOException { testDigestPath(messageDigestAlgorithm, StandardOpenOption.READ); } @ParameterizedTest @MethodSource("data") - public void testGetMessageDigest(final String messageDigestAlgorithm) { + void testGetMessageDigest(final String messageDigestAlgorithm) { assumeTrue(DigestUtils.isAvailable(messageDigestAlgorithm)); final MessageDigest messageDigest = DigestUtils.getDigest(messageDigestAlgorithm); assertEquals(messageDigestAlgorithm, messageDigest.getAlgorithm()); @@ -199,7 +199,7 @@ public class MessageDigestAlgorithmsTest { @ParameterizedTest @MethodSource("data") - public void testNonBlockingDigestRandomAccessFile(final String messageDigestAlgorithm) throws IOException { + void testNonBlockingDigestRandomAccessFile(final String messageDigestAlgorithm) throws IOException { assumeTrue(DigestUtils.isAvailable(messageDigestAlgorithm)); final byte[] expected = digestTestData(messageDigestAlgorithm); diff --git a/src/test/java/org/apache/commons/codec/digest/Sha512CryptTest.java b/src/test/java/org/apache/commons/codec/digest/Sha512CryptTest.java index fd0f099f..5021cb2d 100644 --- a/src/test/java/org/apache/commons/codec/digest/Sha512CryptTest.java +++ b/src/test/java/org/apache/commons/codec/digest/Sha512CryptTest.java @@ -80,7 +80,7 @@ public class Sha512CryptTest { } @Disabled - public void testSha512CryptNullSalt() { + void testSha512CryptNullSalt() { // cannot be tested as sha512Crypt() with all params is private and // all public methods check for salt==null. } diff --git a/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java b/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java index e608f37d..f0a1664b 100644 --- a/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java +++ b/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java @@ -134,7 +134,7 @@ public class ColognePhoneticTest extends AbstractStringEncoderTest<ColognePhonet @Test // Ensure that override still allows tests to work - public void testCanFail() { + void testCanFail() { assertThrows(AssertionFailedError.class, () -> checkEncoding("/", "Fehler")); } diff --git a/src/test/java/org/apache/commons/codec/language/DaitchMokotoffSoundexTest.java b/src/test/java/org/apache/commons/codec/language/DaitchMokotoffSoundexTest.java index a3a5a9a2..0efd4f71 100644 --- a/src/test/java/org/apache/commons/codec/language/DaitchMokotoffSoundexTest.java +++ b/src/test/java/org/apache/commons/codec/language/DaitchMokotoffSoundexTest.java @@ -68,7 +68,7 @@ public class DaitchMokotoffSoundexTest extends AbstractStringEncoderTest<DaitchM } @Test - public void testEncodeBasic() { + void testEncodeBasic() { // same as above, but without branching assertEquals("097400", encode("AUERBACH")); assertEquals("097400", encode("OHRBACH")); diff --git a/src/test/java/org/apache/commons/codec/language/SoundexTest.java b/src/test/java/org/apache/commons/codec/language/SoundexTest.java index afebc3e3..ff1ea2e0 100644 --- a/src/test/java/org/apache/commons/codec/language/SoundexTest.java +++ b/src/test/java/org/apache/commons/codec/language/SoundexTest.java @@ -219,7 +219,7 @@ public class SoundexTest extends AbstractStringEncoderTest<Soundex> { @Test // examples and algorithm rules from: http://www.genealogy.com/articles/research/00000060.html - public void testGenealogy() { // treat vowels and HW as silent + void testGenealogy() { // treat vowels and HW as silent final Soundex s = Soundex.US_ENGLISH_GENEALOGY; assertEquals("H251", s.encode("Heggenburger")); assertEquals("B425", s.encode("Blackman")); @@ -342,7 +342,7 @@ public class SoundexTest extends AbstractStringEncoderTest<Soundex> { @Test // examples and algorithm rules from: http://west-penwith.org.uk/misc/soundex.htm - public void testSimplifiedSoundex() { // treat vowels and HW as separators + void testSimplifiedSoundex() { // treat vowels and HW as separators final Soundex s = Soundex.US_ENGLISH_SIMPLIFIED; assertEquals("W452", s.encode("WILLIAMS")); assertEquals("B625", s.encode("BARAGWANATH")); diff --git a/src/test/java/org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java b/src/test/java/org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java index b394b161..a9b12a97 100644 --- a/src/test/java/org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java +++ b/src/test/java/org/apache/commons/codec/language/bm/BeiderMorseEncoderTest.java @@ -188,7 +188,7 @@ public class BeiderMorseEncoderTest extends AbstractStringEncoderTest<StringEnco * @throws EncoderException for some failure scenarios */ @Test /* timeout = 20000L */ - public void testSpeedCheck() throws EncoderException { + void testSpeedCheck() throws EncoderException { final BeiderMorseEncoder bmpm = createGenericApproxEncoder(); final StringBuilder stringBuffer = new StringBuilder(); stringBuffer.append(TEST_CHARS[0]); diff --git a/src/test/java/org/apache/commons/codec/language/bm/LanguageGuessingTest.java b/src/test/java/org/apache/commons/codec/language/bm/LanguageGuessingTest.java index 22de707a..0d648018 100644 --- a/src/test/java/org/apache/commons/codec/language/bm/LanguageGuessingTest.java +++ b/src/test/java/org/apache/commons/codec/language/bm/LanguageGuessingTest.java @@ -57,7 +57,7 @@ public class LanguageGuessingTest { @ParameterizedTest @MethodSource("data") - public void testLanguageGuessing(final String name, final String language) { + void testLanguageGuessing(final String name, final String language) { final Languages.LanguageSet guesses = this.lang.guessLanguages(name); assertTrue(guesses.contains(language), diff --git a/src/test/java/org/apache/commons/codec/language/bm/PhoneticEngineTest.java b/src/test/java/org/apache/commons/codec/language/bm/PhoneticEngineTest.java index acab6805..0ce452f7 100644 --- a/src/test/java/org/apache/commons/codec/language/bm/PhoneticEngineTest.java +++ b/src/test/java/org/apache/commons/codec/language/bm/PhoneticEngineTest.java @@ -64,7 +64,7 @@ public class PhoneticEngineTest { // TODO Identify if there is a need to an assertTimeout(Duration.ofMillis(10000L) in some point, since this method was marked as @Test(timeout = 10000L) @ParameterizedTest @MethodSource("data") - public void testEncode(final String name, final String phoneticExpected, final NameType nameType, + void testEncode(final String name, final String phoneticExpected, final NameType nameType, final RuleType ruleType, final boolean concat, final int maxPhonemes) { final PhoneticEngine engine = new PhoneticEngine(nameType, ruleType, concat, maxPhonemes); @@ -86,7 +86,7 @@ public class PhoneticEngineTest { @ParameterizedTest @MethodSource("invalidData") - public void testInvalidEncode(final String input, final String phoneticExpected, final NameType nameType, + void testInvalidEncode(final String input, final String phoneticExpected, final NameType nameType, final RuleType ruleType, final boolean concat, final int maxPhonemes) { final PhoneticEngine engine = new PhoneticEngine(nameType, ruleType, concat, maxPhonemes); diff --git a/src/test/java/org/apache/commons/codec/net/PercentCodecTest.java b/src/test/java/org/apache/commons/codec/net/PercentCodecTest.java index faebda47..65950d5c 100644 --- a/src/test/java/org/apache/commons/codec/net/PercentCodecTest.java +++ b/src/test/java/org/apache/commons/codec/net/PercentCodecTest.java @@ -50,7 +50,7 @@ public class PercentCodecTest { @Test @Disabled // TODO Should be removed? - public void testBasicSpace() throws Exception { + void testBasicSpace() throws Exception { final PercentCodec percentCodec = new PercentCodec(); final String input = " "; final byte[] encoded = percentCodec.encode(input.getBytes(StandardCharsets.UTF_8));