This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
commit f89bdd34c43ae18f0e34189b08aa447afc9044c7 Author: Gary D. Gregory <garydgreg...@gmail.com> AuthorDate: Sat Jun 7 09:59:32 2025 -0400 Use JUnit 5 convention for test method visibility --- .../java/org/apache/commons/beanutils2/BeanMapTest.java | 16 ++++++++-------- .../org/apache/commons/beanutils2/ConvertUtilsTest.java | 2 +- .../org/apache/commons/beanutils2/LazyDynaListTest.java | 2 +- .../beanutils2/converters/CharacterConverterTest.java | 4 ++-- .../beanutils2/converters/IntegerConverterTest.java | 2 +- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/test/java/org/apache/commons/beanutils2/BeanMapTest.java b/src/test/java/org/apache/commons/beanutils2/BeanMapTest.java index 631d9cd1..f659c8d3 100644 --- a/src/test/java/org/apache/commons/beanutils2/BeanMapTest.java +++ b/src/test/java/org/apache/commons/beanutils2/BeanMapTest.java @@ -267,7 +267,7 @@ public class BeanMapTest extends AbstractMapTest<BeanMap, String, Object> { } @Test - public void testBeanMapClone() { + void testBeanMapClone() { final BeanMap map = (BeanMap) makeFullMap(); try { final BeanMap map2 = (BeanMap) map.clone(); @@ -284,7 +284,7 @@ public class BeanMapTest extends AbstractMapTest<BeanMap, String, Object> { } @Test - public void testBeanMapPutAllWriteable() { + void testBeanMapPutAllWriteable() { final BeanMap map1 = (BeanMap) makeFullMap(); final BeanMap map2 = (BeanMap) makeFullMap(); map2.put("someIntValue", Integer.valueOf(0)); @@ -296,7 +296,7 @@ public class BeanMapTest extends AbstractMapTest<BeanMap, String, Object> { * Test that the cause of exception thrown by clear() is initialized. */ @Test - public void testExceptionThrowFromClear() { + void testExceptionThrowFromClear() { try { final Object bean = Jira87BeanFactory.createMappedPropertyBean(); final BeanMap map = new BeanMap(bean); @@ -318,7 +318,7 @@ public class BeanMapTest extends AbstractMapTest<BeanMap, String, Object> { * Test that the cause of exception thrown by a clone() is initialized. */ @Test - public void testExceptionThrowFromClone() { + void testExceptionThrowFromClone() { // Test cloning a non-public bean (instantiation exception) try { final Object bean = Jira87BeanFactory.createMappedPropertyBean(); @@ -357,7 +357,7 @@ public class BeanMapTest extends AbstractMapTest<BeanMap, String, Object> { * Test that the cause of exception thrown by put() is initialized. */ @Test - public void testExceptionThrowFromPut() { + void testExceptionThrowFromPut() { try { final Map<String, Object> map = new BeanMap(new BeanThrowingExceptions()); map.put("valueThrowingException", "value"); @@ -382,7 +382,7 @@ public class BeanMapTest extends AbstractMapTest<BeanMap, String, Object> { * Test the default transformers using the getTypeTransformer() method */ @Test - public void testGetTypeTransformerMethod() { + void testGetTypeTransformerMethod() { final BeanMap beanMap = new BeanMap(); assertEquals(Boolean.TRUE, beanMap.getTypeTransformer(Boolean.TYPE).apply("true"), "Boolean.TYPE"); assertEquals(Character.valueOf('B'), beanMap.getTypeTransformer(Character.TYPE).apply("BCD"), "Character.TYPE"); @@ -416,14 +416,14 @@ public class BeanMapTest extends AbstractMapTest<BeanMap, String, Object> { } @Test - public void testMethodAccessor() throws Exception { + void testMethodAccessor() throws Exception { final BeanMap map = (BeanMap) makeFullMap(); final Method method = BeanWithProperties.class.getDeclaredMethod("getSomeIntegerValue"); assertEquals(method, map.getReadMethod("someIntegerValue")); } @Test - public void testMethodMutator() throws Exception { + void testMethodMutator() throws Exception { final BeanMap map = (BeanMap) makeFullMap(); final Method method = BeanWithProperties.class.getDeclaredMethod("setSomeIntegerValue", Integer.class); assertEquals(method, map.getWriteMethod("someIntegerValue")); diff --git a/src/test/java/org/apache/commons/beanutils2/ConvertUtilsTest.java b/src/test/java/org/apache/commons/beanutils2/ConvertUtilsTest.java index c092154b..aefefb87 100644 --- a/src/test/java/org/apache/commons/beanutils2/ConvertUtilsTest.java +++ b/src/test/java/org/apache/commons/beanutils2/ConvertUtilsTest.java @@ -84,7 +84,7 @@ public class ConvertUtilsTest { @Test @SuppressWarnings({ "unchecked", "rawtypes" }) // We need to use raw types in order to test legacy converters - public void testConvertToString() throws Exception { + void testConvertToString() throws Exception { final Converter dummyConverter = (type, value) -> value; final Converter fooConverter = (type, value) -> "Foo-Converter"; diff --git a/src/test/java/org/apache/commons/beanutils2/LazyDynaListTest.java b/src/test/java/org/apache/commons/beanutils2/LazyDynaListTest.java index a30edbd0..ee5875ee 100644 --- a/src/test/java/org/apache/commons/beanutils2/LazyDynaListTest.java +++ b/src/test/java/org/apache/commons/beanutils2/LazyDynaListTest.java @@ -268,7 +268,7 @@ public class LazyDynaListTest { /** * Test Collection */ - public void testCollection(final LazyDynaList list, final Class<?> testClass, final DynaClass testDynaClass, final Object wrongBean) { + void testCollection(final LazyDynaList list, final Class<?> testClass, final DynaClass testDynaClass, final Object wrongBean) { // Create Collection & Array of Maps final int size = 5; diff --git a/src/test/java/org/apache/commons/beanutils2/converters/CharacterConverterTest.java b/src/test/java/org/apache/commons/beanutils2/converters/CharacterConverterTest.java index 904f807a..84f75c67 100644 --- a/src/test/java/org/apache/commons/beanutils2/converters/CharacterConverterTest.java +++ b/src/test/java/org/apache/commons/beanutils2/converters/CharacterConverterTest.java @@ -74,7 +74,7 @@ public class CharacterConverterTest { */ @Test @SuppressWarnings("unchecked") // testing raw conversion - public void testConvertToString() { + void testConvertToString() { final Converter<Character> converter = new CharacterConverter(); @SuppressWarnings("rawtypes") @@ -91,7 +91,7 @@ public class CharacterConverterTest { */ @Test @SuppressWarnings("unchecked") // tests failure so allow mismatch - public void testConvertToUnsupportedType() { + void testConvertToUnsupportedType() { @SuppressWarnings("rawtypes") // tests failure so allow mismatch final Converter converter = new CharacterConverter(); assertThrows(ConversionException.class, () -> converter.convert(Integer.class, "Test")); diff --git a/src/test/java/org/apache/commons/beanutils2/converters/IntegerConverterTest.java b/src/test/java/org/apache/commons/beanutils2/converters/IntegerConverterTest.java index 2749d9e4..cb93ccc2 100644 --- a/src/test/java/org/apache/commons/beanutils2/converters/IntegerConverterTest.java +++ b/src/test/java/org/apache/commons/beanutils2/converters/IntegerConverterTest.java @@ -93,7 +93,7 @@ public class IntegerConverterTest extends AbstractNumberConverterTest<Integer> { */ @Test @SuppressWarnings("unchecked") // raw to test throwing - public void testInvalidDefaultObject() { + void testInvalidDefaultObject() { @SuppressWarnings("rawtypes") // raw to test throwing final NumberConverter converter = makeConverter(); assertThrows(ConversionException.class, () -> converter.setDefaultValue("notANumber"), "Invalid default value not detected!");