This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-bcel.git
The following commit(s) were added to refs/heads/master by this push: new 0ea74022 Use JUnit 5 convention for @Test method visibility 0ea74022 is described below commit 0ea74022e4ad7a19758f1acf85414ef9e6650c70 Author: Gary D. Gregory <garydgreg...@gmail.com> AuthorDate: Sat Jun 7 09:11:03 2025 -0400 Use JUnit 5 convention for @Test method visibility --- .../org/apache/bcel/AnnotationAccessFlagTest.java | 2 +- .../bcel/AnnotationDefaultAttributeTest.java | 2 +- .../java/org/apache/bcel/AnnotationEntryTest.java | 8 +-- .../java/org/apache/bcel/AnonymousClassTest.java | 10 +-- src/test/java/org/apache/bcel/ConstTest.java | 8 +-- .../java/org/apache/bcel/CounterVisitorTest.java | 78 +++++++++++----------- .../java/org/apache/bcel/ElementValueGenTest.java | 22 +++--- .../apache/bcel/EnclosingMethodAttributeTest.java | 6 +- .../java/org/apache/bcel/EnumAccessFlagTest.java | 2 +- src/test/java/org/apache/bcel/HandleTest.java | 4 +- .../org/apache/bcel/InstructionFinderTest.java | 2 +- .../apache/bcel/LocalVariableTypeTableTest.java | 4 +- src/test/java/org/apache/bcel/OssFuzzTest.java | 18 ++--- src/test/java/org/apache/bcel/PLSETest.java | 10 +-- src/test/java/org/apache/bcel/PerformanceTest.java | 2 +- .../apache/bcel/classfile/CodeExceptionTest.java | 2 +- .../classfile/ConstantPoolModuleToStringTest.java | 2 +- .../apache/bcel/classfile/ConstantPoolTest.java | 8 +-- .../org/apache/bcel/classfile/ConstantTest.java | 2 +- .../java/org/apache/bcel/classfile/FieldTest.java | 2 +- .../bcel/classfile/InvalidMethodSigantureTest.java | 2 +- .../apache/bcel/classfile/JDKClassDumpTest.java | 2 +- .../org/apache/bcel/classfile/Jira368Test.java | 6 +- .../apache/bcel/classfile/LocalVariableTest.java | 2 +- .../java/org/apache/bcel/classfile/RecordTest.java | 10 +-- .../org/apache/bcel/classfile/SignatureTest.java | 8 +-- .../org/apache/bcel/classfile/StackMapTest.java | 2 +- .../org/apache/bcel/classfile/UtilityTest.java | 16 ++--- .../org/apache/bcel/generic/AnnotationGenTest.java | 4 +- .../org/apache/bcel/generic/ArrayTypeTest.java | 18 ++--- .../org/apache/bcel/generic/BREAKPOINTTest.java | 2 +- .../org/apache/bcel/generic/BasicTypeTest.java | 6 +- .../org/apache/bcel/generic/BranchHandleTest.java | 8 +-- .../java/org/apache/bcel/generic/ClassGenTest.java | 2 +- src/test/java/org/apache/bcel/generic/D2FTest.java | 2 +- src/test/java/org/apache/bcel/generic/D2ITest.java | 2 +- src/test/java/org/apache/bcel/generic/D2LTest.java | 2 +- .../java/org/apache/bcel/generic/DADDTest.java | 2 +- .../java/org/apache/bcel/generic/DDIVTest.java | 2 +- .../java/org/apache/bcel/generic/DMULTest.java | 2 +- .../java/org/apache/bcel/generic/DNEGTest.java | 2 +- .../java/org/apache/bcel/generic/DREMTest.java | 2 +- .../java/org/apache/bcel/generic/DSUBTest.java | 2 +- src/test/java/org/apache/bcel/generic/F2DTest.java | 2 +- src/test/java/org/apache/bcel/generic/F2ITest.java | 2 +- src/test/java/org/apache/bcel/generic/F2LTest.java | 2 +- .../java/org/apache/bcel/generic/FADDTest.java | 2 +- .../java/org/apache/bcel/generic/FDIVTest.java | 2 +- .../java/org/apache/bcel/generic/FMULTest.java | 2 +- .../java/org/apache/bcel/generic/FNEGTest.java | 2 +- .../java/org/apache/bcel/generic/FREMTest.java | 2 +- .../java/org/apache/bcel/generic/FSUBTest.java | 2 +- .../apache/bcel/generic/FieldAnnotationsTest.java | 6 +- .../java/org/apache/bcel/generic/GETFIELDTest.java | 2 +- .../generic/GeneratingAnnotatedClassesTest.java | 18 ++--- src/test/java/org/apache/bcel/generic/I2BTest.java | 2 +- src/test/java/org/apache/bcel/generic/I2CTest.java | 2 +- src/test/java/org/apache/bcel/generic/I2DTest.java | 2 +- src/test/java/org/apache/bcel/generic/I2FTest.java | 2 +- src/test/java/org/apache/bcel/generic/I2LTest.java | 2 +- src/test/java/org/apache/bcel/generic/I2STest.java | 2 +- .../java/org/apache/bcel/generic/IADDTest.java | 2 +- .../java/org/apache/bcel/generic/IANDTest.java | 2 +- .../java/org/apache/bcel/generic/IDIVTest.java | 2 +- .../java/org/apache/bcel/generic/IMPDEP1Test.java | 2 +- .../java/org/apache/bcel/generic/IMPDEP2Test.java | 2 +- .../java/org/apache/bcel/generic/IMULTest.java | 2 +- .../java/org/apache/bcel/generic/INEGTest.java | 2 +- src/test/java/org/apache/bcel/generic/IORTest.java | 2 +- .../java/org/apache/bcel/generic/IREMTest.java | 2 +- .../java/org/apache/bcel/generic/ISHLTest.java | 2 +- .../java/org/apache/bcel/generic/ISHRTest.java | 2 +- .../java/org/apache/bcel/generic/ISUBTest.java | 2 +- .../java/org/apache/bcel/generic/IXORTest.java | 2 +- .../bcel/generic/InstructionFactoryTest.java | 10 +-- .../apache/bcel/generic/InstructionHandleTest.java | 10 +-- .../org/apache/bcel/generic/JiraBcel362Test.java | 2 +- src/test/java/org/apache/bcel/generic/L2DTest.java | 2 +- src/test/java/org/apache/bcel/generic/L2FTest.java | 2 +- src/test/java/org/apache/bcel/generic/L2ITest.java | 2 +- .../java/org/apache/bcel/generic/LADDTest.java | 2 +- .../java/org/apache/bcel/generic/LANDTest.java | 2 +- .../java/org/apache/bcel/generic/LCMPTest.java | 2 +- .../java/org/apache/bcel/generic/LDIVTest.java | 2 +- .../java/org/apache/bcel/generic/LMULTest.java | 2 +- .../java/org/apache/bcel/generic/LNEGTest.java | 2 +- src/test/java/org/apache/bcel/generic/LORTest.java | 2 +- .../java/org/apache/bcel/generic/LREMTest.java | 2 +- .../java/org/apache/bcel/generic/LSHLTest.java | 2 +- .../java/org/apache/bcel/generic/LSHRTest.java | 2 +- .../java/org/apache/bcel/generic/LSUBTest.java | 2 +- .../java/org/apache/bcel/generic/LXORTest.java | 2 +- .../org/apache/bcel/generic/MethodGenTest.java | 10 +-- .../org/apache/bcel/generic/ObjectTypeTest.java | 2 +- .../java/org/apache/bcel/generic/PUTFIELDTest.java | 2 +- .../org/apache/bcel/generic/PUTSTATICTest.java | 2 +- .../java/org/apache/bcel/generic/TypeTest.java | 4 +- .../java/org/apache/bcel/util/BCELifierTest.java | 6 +- .../java/org/apache/bcel/util/Class2HTMLTest.java | 2 +- .../apache/bcel/util/ClassPathRepositoryTest.java | 16 ++--- .../java/org/apache/bcel/util/ClassPathTest.java | 8 +-- .../apache/bcel/util/InstructionFinderTest.java | 2 +- .../bcel/util/LruCacheClassPathRepositoryTest.java | 6 +- .../org/apache/bcel/verifier/JiraBcel291Test.java | 2 +- .../org/apache/bcel/verifier/JiraBcel369Test.java | 2 +- .../bcel/verifier/VerifierArrayAccessTest.java | 4 +- .../apache/bcel/verifier/VerifierInvokeTest.java | 8 +-- .../org/apache/bcel/verifier/VerifierMainTest.java | 2 +- .../apache/bcel/verifier/VerifierReturnTest.java | 4 +- .../org/apache/bcel/verifier/VerifierTest.java | 16 ++--- .../apache/bcel/verifier/VerifierThrowTest.java | 2 +- .../apache/bcel/verifier/VerifyBadClassesTest.java | 18 ++--- .../apache/bcel/verifier/VerifyJavaMathTest.java | 2 +- .../apache/bcel/verifier/VerifyJavaUtilTest.java | 6 +- .../bcel/verifier/statics/Pass2VerifierTest.java | 2 +- .../structurals/UninitializedObjectTypeTest.java | 2 +- 116 files changed, 282 insertions(+), 282 deletions(-) diff --git a/src/test/java/org/apache/bcel/AnnotationAccessFlagTest.java b/src/test/java/org/apache/bcel/AnnotationAccessFlagTest.java index 68335de8..2d816341 100644 --- a/src/test/java/org/apache/bcel/AnnotationAccessFlagTest.java +++ b/src/test/java/org/apache/bcel/AnnotationAccessFlagTest.java @@ -31,7 +31,7 @@ public class AnnotationAccessFlagTest extends AbstractTest { * detectable through BCEL. */ @Test - public void testAnnotationClassSaysItIs() throws ClassNotFoundException { + void testAnnotationClassSaysItIs() throws ClassNotFoundException { JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.SimpleAnnotation"); assertTrue(clazz.isAnnotation(), "Expected SimpleAnnotation class to say it was an annotation - but it didn't !"); clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.SimpleClass"); diff --git a/src/test/java/org/apache/bcel/AnnotationDefaultAttributeTest.java b/src/test/java/org/apache/bcel/AnnotationDefaultAttributeTest.java index 72441c83..bccabc67 100644 --- a/src/test/java/org/apache/bcel/AnnotationDefaultAttributeTest.java +++ b/src/test/java/org/apache/bcel/AnnotationDefaultAttributeTest.java @@ -34,7 +34,7 @@ public class AnnotationDefaultAttributeTest extends AbstractTest { * against the method to discover the default value that was originally declared. */ @Test - public void testMethodAnnotations() throws ClassNotFoundException { + void testMethodAnnotations() throws ClassNotFoundException { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.SimpleAnnotation"); final Method m = getMethod(clazz, "fruit"); final AnnotationDefault a = (AnnotationDefault) findAttribute("AnnotationDefault", m.getAttributes()); diff --git a/src/test/java/org/apache/bcel/AnnotationEntryTest.java b/src/test/java/org/apache/bcel/AnnotationEntryTest.java index c7d018ce..7510f5e0 100644 --- a/src/test/java/org/apache/bcel/AnnotationEntryTest.java +++ b/src/test/java/org/apache/bcel/AnnotationEntryTest.java @@ -37,26 +37,26 @@ import org.junit.jupiter.api.Test; public class AnnotationEntryTest { @Test - public void testAddElementNameValuePair() { + void testAddElementNameValuePair() { final AnnotationEntry annotationEntry = new AnnotationEntry(0, null, false); annotationEntry.addElementNameValuePair(new ElementValuePair(0, new SimpleElementValue(0, 0, null), null)); assertEquals(1, annotationEntry.getNumElementValuePairs()); } @Test - public void testDump() throws IOException { + void testDump() throws IOException { final ByteArrayOutputStream out = new ByteArrayOutputStream(); new AnnotationEntry(0, null, false).dump(new DataOutputStream(out)); assertArrayEquals(new byte[4], out.toByteArray()); } @Test - public void testGetElementValuePairs() { + void testGetElementValuePairs() { assertEquals(0, new AnnotationEntry(0, null, false).getElementValuePairs().length); } @Test - public void testGetNumElementValuePairs() { + void testGetNumElementValuePairs() { assertEquals(0, new AnnotationEntry(0, null, false).getNumElementValuePairs()); } } diff --git a/src/test/java/org/apache/bcel/AnonymousClassTest.java b/src/test/java/org/apache/bcel/AnonymousClassTest.java index 261b6500..916a13f5 100644 --- a/src/test/java/org/apache/bcel/AnonymousClassTest.java +++ b/src/test/java/org/apache/bcel/AnonymousClassTest.java @@ -32,21 +32,21 @@ import org.junit.jupiter.api.Test; public class AnonymousClassTest extends AbstractTest { @Test - public void testAnonymousInnerClassIsAnonymous() throws ClassNotFoundException { + void testAnonymousInnerClassIsAnonymous() throws ClassNotFoundException { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.AnonymousClassTest$1"); assertTrue(clazz.isAnonymous(), "anonymous inner classes are anonymous"); assertTrue(clazz.isNested(), "anonymous inner classes are anonymous"); } @Test - public void testNamedInnerClassIsNotAnonymous() throws ClassNotFoundException { + void testNamedInnerClassIsNotAnonymous() throws ClassNotFoundException { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.AnonymousClassTest$X"); assertFalse(clazz.isAnonymous(), "regular inner classes are not anonymous"); assertTrue(clazz.isNested(), "regular inner classes are nested"); } @Test - public void testRegularClassInnerClasses() throws ClassNotFoundException { + void testRegularClassInnerClasses() throws ClassNotFoundException { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.AnonymousClassTest"); final InnerClasses innerClasses = clazz.getAttribute(Const.ATTR_INNER_CLASSES); final InnerClass[] innerClassArray = innerClasses.getInnerClasses(); @@ -55,14 +55,14 @@ public class AnonymousClassTest extends AbstractTest { } @Test - public void testRegularClassIsNotAnonymous() throws ClassNotFoundException { + void testRegularClassIsNotAnonymous() throws ClassNotFoundException { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.AnonymousClassTest"); assertFalse(clazz.isAnonymous(), "regular outer classes are not anonymous"); assertFalse(clazz.isNested(), "regular outer classes are not nested"); } @Test - public void testStaticInnerClassIsNotAnonymous() throws ClassNotFoundException { + void testStaticInnerClassIsNotAnonymous() throws ClassNotFoundException { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.AnonymousClassTest$Y"); assertFalse(clazz.isAnonymous(), "regular static inner classes are not anonymous"); assertTrue(clazz.isNested(), "regular static inner classes are nested"); diff --git a/src/test/java/org/apache/bcel/ConstTest.java b/src/test/java/org/apache/bcel/ConstTest.java index 2c1d176d..ecff2bba 100644 --- a/src/test/java/org/apache/bcel/ConstTest.java +++ b/src/test/java/org/apache/bcel/ConstTest.java @@ -29,25 +29,25 @@ import org.junit.jupiter.api.Test; public class ConstTest { @Test - public void testJava22() throws Exception { + void testJava22() throws Exception { assertEquals(66, Const.MAJOR_22); assertEquals(0, Const.MINOR_22); } @Test - public void testJava23() throws Exception { + void testJava23() throws Exception { assertEquals(67, Const.MAJOR_23); assertEquals(0, Const.MINOR_23); } @Test - public void testJava24() throws Exception { + void testJava24() throws Exception { assertEquals(68, Const.MAJOR_24); assertEquals(0, Const.MINOR_24); } @Test - public void testJava25() throws Exception { + void testJava25() throws Exception { assertEquals(69, Const.MAJOR_25); assertEquals(0, Const.MINOR_25); } diff --git a/src/test/java/org/apache/bcel/CounterVisitorTest.java b/src/test/java/org/apache/bcel/CounterVisitorTest.java index f9fea2dd..095710ac 100644 --- a/src/test/java/org/apache/bcel/CounterVisitorTest.java +++ b/src/test/java/org/apache/bcel/CounterVisitorTest.java @@ -31,197 +31,197 @@ public class CounterVisitorTest extends AbstractCounterVisitorTest { } @Test - public void testAnnotationDefaultCount() { + void testAnnotationDefaultCount() { assertEquals(0, getVisitor().annotationDefaultCount, "annotationDefaultCount"); } @Test - public void testAnnotationEntryCount() { + void testAnnotationEntryCount() { assertEquals(2, getVisitor().annotationEntryCount, "annotationEntryCount"); } @Test - public void testAnnotationsCount() { + void testAnnotationsCount() { assertEquals(2, getVisitor().annotationCount, "annotationCount"); } @Test - public void testCodeCount() { + void testCodeCount() { assertEquals(1, getVisitor().codeCount, "codeCount"); } @Test - public void testCodeExceptionCount() { + void testCodeExceptionCount() { assertEquals(0, getVisitor().codeExceptionCount, "codeExceptionCount"); } @Test - public void testConstantClassCount() { + void testConstantClassCount() { assertEquals(2, getVisitor().constantClassCount, "constantClassCount"); } @Test - public void testConstantDoubleCount() { + void testConstantDoubleCount() { assertEquals(0, getVisitor().constantDoubleCount, "constantDoubleCount"); } @Test - public void testConstantFieldrefCount() { + void testConstantFieldrefCount() { assertEquals(0, getVisitor().constantFieldrefCount, "constantFieldrefCount"); } @Test - public void testConstantFloatCount() { + void testConstantFloatCount() { assertEquals(0, getVisitor().constantFloatCount, "constantFloatCount"); } @Test - public void testConstantIntegerCount() { + void testConstantIntegerCount() { assertEquals(0, getVisitor().constantIntegerCount, "constantIntegerCount"); } @Test - public void testConstantInterfaceMethodrefCount() { + void testConstantInterfaceMethodrefCount() { assertEquals(0, getVisitor().constantInterfaceMethodrefCount, "constantInterfaceMethodrefCount"); } @Test - public void testConstantLongCount() { + void testConstantLongCount() { assertEquals(0, getVisitor().constantLongCount, "constantLongCount"); } @Test - public void testConstantMethodrefCount() { + void testConstantMethodrefCount() { assertEquals(1, getVisitor().constantMethodrefCount, "constantMethodrefCount"); } @Test - public void testConstantNameAndTypeCount() { + void testConstantNameAndTypeCount() { assertEquals(1, getVisitor().constantNameAndTypeCount, "constantNameAndTypeCount"); } @Test - public void testConstantPoolCount() { + void testConstantPoolCount() { assertEquals(1, getVisitor().constantPoolCount, "constantPoolCount"); } @Test - public void testConstantStringCount() { + void testConstantStringCount() { assertEquals(0, getVisitor().constantStringCount, "constantStringCount"); } @Test - public void testConstantValueCount() { + void testConstantValueCount() { assertEquals(0, getVisitor().constantValueCount, "constantValueCount"); } @Test - public void testDeprecatedCount() { + void testDeprecatedCount() { assertEquals(0, getVisitor().deprecatedCount, "deprecatedCount"); } @Test - public void testEnclosingMethodCount() { + void testEnclosingMethodCount() { assertEquals(0, getVisitor().enclosingMethodCount, "enclosingMethodCount"); } @Test - public void testExceptionTableCount() { + void testExceptionTableCount() { assertEquals(0, getVisitor().exceptionTableCount, "exceptionTableCount"); } @Test - public void testFieldCount() { + void testFieldCount() { assertEquals(0, getVisitor().fieldCount, "fieldCount"); } @Test - public void testInnerClassCount() { + void testInnerClassCount() { assertEquals(0, getVisitor().innerClassCount, "innerClassCount"); } @Test - public void testInnerClassesCount() { + void testInnerClassesCount() { assertEquals(0, getVisitor().innerClassesCount, "innerClassesCount"); } @Test - public void testJavaClassCount() { + void testJavaClassCount() { assertEquals(1, getVisitor().javaClassCount, "javaClassCount"); } @Test - public void testLineNumberCount() { + void testLineNumberCount() { assertEquals(1, getVisitor().lineNumberCount, "lineNumberCount"); } @Test - public void testLineNumberTableCount() { + void testLineNumberTableCount() { assertEquals(1, getVisitor().lineNumberTableCount, "lineNumberTableCount"); } @Test - public void testLocalVariableCount() { + void testLocalVariableCount() { assertEquals(1, getVisitor().localVariableCount, "localVariableCount"); } @Test - public void testLocalVariableTableCount() { + void testLocalVariableTableCount() { assertEquals(1, getVisitor().localVariableTableCount, "localVariableTableCount"); } @Test - public void testLocalVariableTypeTableCount() { + void testLocalVariableTypeTableCount() { assertEquals(0, getVisitor().localVariableTypeTableCount, "localVariableTypeTableCount"); } @Test - public void testMethodCount() { + void testMethodCount() { assertEquals(1, getVisitor().methodCount, "methodCount"); } @Test - public void testParameterAnnotationCount() { + void testParameterAnnotationCount() { assertEquals(0, getVisitor().parameterAnnotationCount, "parameterAnnotationCount"); } @Test - public void testRecordCount() { + void testRecordCount() { assertEquals(0, getVisitor().recordCount, "recordCount"); } @Test - public void testSignatureCount() { + void testSignatureCount() { assertEquals(0, getVisitor().signatureAnnotationCount, "signatureAnnotationCount"); } @Test - public void testSourceFileCount() { + void testSourceFileCount() { assertEquals(1, getVisitor().sourceFileCount, "sourceFileCount"); } @Test - public void testStackMapCount() { + void testStackMapCount() { assertEquals(0, getVisitor().stackMapCount, "stackMapCount"); } @Test - public void testStackMapEntryCount() { + void testStackMapEntryCount() { assertEquals(0, getVisitor().stackMapEntryCount, "stackMapEntryCount"); } @Test - public void testStackMapTypeCount() { + void testStackMapTypeCount() { assertEquals(0, getVisitor().stackMapTypeCount, "stackMapTypeCount"); } @Test - public void testSyntheticCount() { + void testSyntheticCount() { assertEquals(0, getVisitor().syntheticCount, "syntheticCount"); } @Test - public void testUnknownCount() { + void testUnknownCount() { assertEquals(0, getVisitor().unknownCount, "unknownCount"); } } diff --git a/src/test/java/org/apache/bcel/ElementValueGenTest.java b/src/test/java/org/apache/bcel/ElementValueGenTest.java index eb11ab0d..1bfd2e42 100644 --- a/src/test/java/org/apache/bcel/ElementValueGenTest.java +++ b/src/test/java/org/apache/bcel/ElementValueGenTest.java @@ -58,7 +58,7 @@ public class ElementValueGenTest extends AbstractTest { } @Test - public void testCreateBooleanElementValue() throws Exception { + void testCreateBooleanElementValue() throws Exception { final ClassGen cg = createClassGen("HelloWorld"); final ConstantPoolGen cp = cg.getConstantPool(); final SimpleElementValueGen evg = new SimpleElementValueGen(ElementValueGen.PRIMITIVE_BOOLEAN, cp, true); @@ -70,7 +70,7 @@ public class ElementValueGenTest extends AbstractTest { } @Test - public void testCreateByteElementValue() throws Exception { + void testCreateByteElementValue() throws Exception { final ClassGen cg = createClassGen("HelloWorld"); final ConstantPoolGen cp = cg.getConstantPool(); final SimpleElementValueGen evg = new SimpleElementValueGen(ElementValueGen.PRIMITIVE_BYTE, cp, (byte) 'z'); @@ -82,7 +82,7 @@ public class ElementValueGenTest extends AbstractTest { } @Test - public void testCreateCharElementValue() throws Exception { + void testCreateCharElementValue() throws Exception { final ClassGen cg = createClassGen("HelloWorld"); final ConstantPoolGen cp = cg.getConstantPool(); final SimpleElementValueGen evg = new SimpleElementValueGen(ElementValueGen.PRIMITIVE_CHAR, cp, 't'); @@ -96,7 +96,7 @@ public class ElementValueGenTest extends AbstractTest { // // // Create class element value @Test - public void testCreateClassElementValue() throws Exception { + void testCreateClassElementValue() throws Exception { final ClassGen cg = createClassGen("HelloWorld"); final ConstantPoolGen cp = cg.getConstantPool(); final ObjectType classType = new ObjectType("java.lang.Integer"); @@ -106,7 +106,7 @@ public class ElementValueGenTest extends AbstractTest { } @Test - public void testCreateDoubleElementValue() throws Exception { + void testCreateDoubleElementValue() throws Exception { final ClassGen cg = createClassGen("HelloWorld"); final ConstantPoolGen cp = cg.getConstantPool(); final SimpleElementValueGen evg = new SimpleElementValueGen(ElementValueGen.PRIMITIVE_DOUBLE, cp, 333.44); @@ -120,7 +120,7 @@ public class ElementValueGenTest extends AbstractTest { // // // Create enum element value @Test - public void testCreateEnumElementValue() throws Exception { + void testCreateEnumElementValue() throws Exception { final ClassGen cg = createClassGen("HelloWorld"); final ConstantPoolGen cp = cg.getConstantPool(); final ObjectType enumType = new ObjectType("SimpleEnum"); // Supports rainbow @@ -139,7 +139,7 @@ public class ElementValueGenTest extends AbstractTest { } @Test - public void testCreateFloatElementValue() throws Exception { + void testCreateFloatElementValue() throws Exception { final ClassGen cg = createClassGen("HelloWorld"); final ConstantPoolGen cp = cg.getConstantPool(); final SimpleElementValueGen evg = new SimpleElementValueGen(ElementValueGen.PRIMITIVE_FLOAT, cp, 111.222f); @@ -153,7 +153,7 @@ public class ElementValueGenTest extends AbstractTest { * Create primitive element values */ @Test - public void testCreateIntegerElementValue() throws Exception { + void testCreateIntegerElementValue() throws Exception { final ClassGen cg = createClassGen("HelloWorld"); final ConstantPoolGen cp = cg.getConstantPool(); final SimpleElementValueGen evg = new SimpleElementValueGen(ElementValueGen.PRIMITIVE_INT, cp, 555); @@ -164,7 +164,7 @@ public class ElementValueGenTest extends AbstractTest { } @Test - public void testCreateLongElementValue() throws Exception { + void testCreateLongElementValue() throws Exception { final ClassGen cg = createClassGen("HelloWorld"); final ConstantPoolGen cp = cg.getConstantPool(); final SimpleElementValueGen evg = new SimpleElementValueGen(ElementValueGen.PRIMITIVE_LONG, cp, 3334455L); @@ -176,7 +176,7 @@ public class ElementValueGenTest extends AbstractTest { } @Test - public void testCreateShortElementValue() throws Exception { + void testCreateShortElementValue() throws Exception { final ClassGen cg = createClassGen("HelloWorld"); final ConstantPoolGen cp = cg.getConstantPool(); final SimpleElementValueGen evg = new SimpleElementValueGen(ElementValueGen.PRIMITIVE_SHORT, cp, (short) 42); @@ -190,7 +190,7 @@ public class ElementValueGenTest extends AbstractTest { // // // Create string element values @Test - public void testCreateStringElementValue() throws Exception { + void testCreateStringElementValue() throws Exception { // Create HelloWorld final ClassGen cg = createClassGen("HelloWorld"); final ConstantPoolGen cp = cg.getConstantPool(); diff --git a/src/test/java/org/apache/bcel/EnclosingMethodAttributeTest.java b/src/test/java/org/apache/bcel/EnclosingMethodAttributeTest.java index 6dbd360e..6ebd84ae 100644 --- a/src/test/java/org/apache/bcel/EnclosingMethodAttributeTest.java +++ b/src/test/java/org/apache/bcel/EnclosingMethodAttributeTest.java @@ -38,7 +38,7 @@ public class EnclosingMethodAttributeTest extends AbstractTest { * Check that we can save and load the attribute correctly. */ @Test - public void testAttributeSerializtion() throws ClassNotFoundException, IOException { + void testAttributeSerializtion() throws ClassNotFoundException, IOException { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.AttributeTestClassEM02$1"); final ConstantPool pool = clazz.getConstantPool(); final Attribute[] encMethodAttrs = findAttribute("EnclosingMethod", clazz); @@ -62,7 +62,7 @@ public class EnclosingMethodAttributeTest extends AbstractTest { * null value) */ @Test - public void testCheckClassLevelNamedInnerClass() throws ClassNotFoundException { + void testCheckClassLevelNamedInnerClass() throws ClassNotFoundException { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.AttributeTestClassEM02$1"); final ConstantPool pool = clazz.getConstantPool(); final Attribute[] encMethodAttrs = findAttribute("EnclosingMethod", clazz); @@ -77,7 +77,7 @@ public class EnclosingMethodAttributeTest extends AbstractTest { * Verify for an inner class declared inside the 'main' method that the enclosing method attribute is set correctly. */ @Test - public void testCheckMethodLevelNamedInnerClass() throws ClassNotFoundException { + void testCheckMethodLevelNamedInnerClass() throws ClassNotFoundException { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.AttributeTestClassEM01$1S"); final ConstantPool pool = clazz.getConstantPool(); final Attribute[] encMethodAttrs = findAttribute("EnclosingMethod", clazz); diff --git a/src/test/java/org/apache/bcel/EnumAccessFlagTest.java b/src/test/java/org/apache/bcel/EnumAccessFlagTest.java index e7b8d3c3..43352c34 100644 --- a/src/test/java/org/apache/bcel/EnumAccessFlagTest.java +++ b/src/test/java/org/apache/bcel/EnumAccessFlagTest.java @@ -31,7 +31,7 @@ public class EnumAccessFlagTest extends AbstractTest { * access flags (through BCEL) that it was originally an enum type declaration. */ @Test - public void testEnumClassSaysItIs() throws ClassNotFoundException { + void testEnumClassSaysItIs() throws ClassNotFoundException { JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.SimpleEnum"); assertTrue(clazz.isEnum(), "Expected SimpleEnum class to say it was an enum - but it didn't !"); clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.SimpleClass"); diff --git a/src/test/java/org/apache/bcel/HandleTest.java b/src/test/java/org/apache/bcel/HandleTest.java index e93c9601..1ccb121a 100644 --- a/src/test/java/org/apache/bcel/HandleTest.java +++ b/src/test/java/org/apache/bcel/HandleTest.java @@ -136,7 +136,7 @@ public class HandleTest { * Assert that two independent instruction lists can be modified concurrently. Here: inserting branch instructions. */ @Test - public void testBranchHandle() throws Throwable { + void testBranchHandle() throws Throwable { perform(HandleTest::branchHandles); } @@ -144,7 +144,7 @@ public class HandleTest { * Assert that two independent instruction lists can be modified concurrently. Here: inserting regular instructions. */ @Test - public void testInstructionHandle() throws Throwable { + void testInstructionHandle() throws Throwable { perform(HandleTest::handles); } } diff --git a/src/test/java/org/apache/bcel/InstructionFinderTest.java b/src/test/java/org/apache/bcel/InstructionFinderTest.java index fbceeccb..20c05b82 100644 --- a/src/test/java/org/apache/bcel/InstructionFinderTest.java +++ b/src/test/java/org/apache/bcel/InstructionFinderTest.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; public class InstructionFinderTest extends AbstractTest { @Test - public void testSearchAll() throws Exception { + void testSearchAll() throws Exception { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".util.InstructionFinder"); final Method[] methods = clazz.getMethods(); Method searchM = null; diff --git a/src/test/java/org/apache/bcel/LocalVariableTypeTableTest.java b/src/test/java/org/apache/bcel/LocalVariableTypeTableTest.java index edbea3e0..45a55c28 100644 --- a/src/test/java/org/apache/bcel/LocalVariableTypeTableTest.java +++ b/src/test/java/org/apache/bcel/LocalVariableTypeTableTest.java @@ -135,7 +135,7 @@ public class LocalVariableTypeTableTest extends AbstractTest { } @Test - public void testGetLocalVariableTypeTable() throws ClassNotFoundException, NoSuchMethodException, SecurityException { + void testGetLocalVariableTypeTable() throws ClassNotFoundException, NoSuchMethodException, SecurityException { final JavaClass testJavaClass = getTestJavaClass("org/apache/commons/lang3/function/TriFunction"); final String expectedToString = "LocalVariableTypes(startPc = 0, length = 17, index = 0:org.apache.commons.lang3.function.TriFunction<T, U, V, R> this)"; for (final Method method : testJavaClass.getMethods()) { @@ -151,7 +151,7 @@ public class LocalVariableTypeTableTest extends AbstractTest { } @Test - public void testWithGenericArguement() throws ClassNotFoundException, NoSuchMethodException, InvocationTargetException, IllegalAccessException { + void testWithGenericArguement() throws ClassNotFoundException, NoSuchMethodException, InvocationTargetException, IllegalAccessException { final String targetClass = PACKAGE_BASE_NAME + ".data.SimpleClassHasMethodIncludeGenericArgument"; final TestClassLoader loader = new TestClassLoader(getClass().getClassLoader()); final Class<?> cls = loader.findClass(targetClass, getBytesFromClass(targetClass)); diff --git a/src/test/java/org/apache/bcel/OssFuzzTest.java b/src/test/java/org/apache/bcel/OssFuzzTest.java index a3fd5973..a0e5f0b3 100644 --- a/src/test/java/org/apache/bcel/OssFuzzTest.java +++ b/src/test/java/org/apache/bcel/OssFuzzTest.java @@ -30,22 +30,22 @@ import org.junit.jupiter.api.Test; public class OssFuzzTest { @Test - public void testIssue51980() throws Exception { + void testIssue51980() throws Exception { testOssFuzzReproducer("51980"); } @Test - public void testIssue51989() throws Exception { + void testIssue51989() throws Exception { testOssFuzzReproducer("51989"); } @Test - public void testIssue52168() throws Exception { + void testIssue52168() throws Exception { testOssFuzzReproducer("52168"); } @Test - public void testIssue53543() throws Exception { + void testIssue53543() throws Exception { testOssFuzzReproducer("53543"); } @@ -53,27 +53,27 @@ public class OssFuzzTest { * The original issue 53544 was a false positive but reviewing that issue did find a valid issue nearby. */ @Test - public void testIssue53544a() throws Exception { + void testIssue53544a() throws Exception { testOssFuzzReproducer("53544a"); } @Test - public void testIssue53620() throws Exception { + void testIssue53620() throws Exception { testOssFuzzReproducer("53620"); } @Test - public void testIssue53676() throws Exception { + void testIssue53676() throws Exception { testOssFuzzReproducer("53676"); } @Test - public void testIssue54119() throws Exception { + void testIssue54119() throws Exception { testOssFuzzReproducer("54119"); } @Test - public void testIssue54254() throws Exception { + void testIssue54254() throws Exception { testOssFuzzReproducer("54254"); } diff --git a/src/test/java/org/apache/bcel/PLSETest.java b/src/test/java/org/apache/bcel/PLSETest.java index 7d9dfd07..64f11ff3 100644 --- a/src/test/java/org/apache/bcel/PLSETest.java +++ b/src/test/java/org/apache/bcel/PLSETest.java @@ -49,7 +49,7 @@ public class PLSETest extends AbstractTest { * BCEL-208: A couple of methods in MethodGen.java need to test for an empty instruction list. */ @Test - public void testBCEL208() throws ClassNotFoundException { + void testBCEL208() throws ClassNotFoundException { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.PLSETestClass"); final ClassGen gen = new ClassGen(clazz); final ConstantPoolGen pool = gen.getConstantPool(); @@ -65,7 +65,7 @@ public class PLSETest extends AbstractTest { * BCEL-262: */ @Test - public void testBCEL262() throws ClassNotFoundException { + void testBCEL262() throws ClassNotFoundException { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.PLSETestEnum"); final ClassGen gen = new ClassGen(clazz); final ConstantPoolGen pool = gen.getConstantPool(); @@ -86,7 +86,7 @@ public class PLSETest extends AbstractTest { * BCEL-295: */ @Test - public void testBCEL295() throws Exception { + void testBCEL295() throws Exception { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.PLSETestClass2"); final ClassGen cg = new ClassGen(clazz); final ConstantPoolGen pool = cg.getConstantPool(); @@ -105,7 +105,7 @@ public class PLSETest extends AbstractTest { * BCEL-361: LineNumber.toString() treats code offset as signed */ @Test - public void testBCEL361() throws Exception { + void testBCEL361() throws Exception { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.LargeMethod"); final Method[] methods = clazz.getMethods(); final Method m = methods[0]; @@ -125,7 +125,7 @@ public class PLSETest extends AbstractTest { * BCEL-79: */ @Test - public void testBCEL79() throws ClassNotFoundException { + void testBCEL79() throws ClassNotFoundException { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.PLSETestClass"); final ClassGen gen = new ClassGen(clazz); final ConstantPoolGen pool = gen.getConstantPool(); diff --git a/src/test/java/org/apache/bcel/PerformanceTest.java b/src/test/java/org/apache/bcel/PerformanceTest.java index 7083814c..3b29a0f7 100644 --- a/src/test/java/org/apache/bcel/PerformanceTest.java +++ b/src/test/java/org/apache/bcel/PerformanceTest.java @@ -132,7 +132,7 @@ public final class PerformanceTest { } @Test - public void testPerformance() { + void testPerformance() { final File javaLib = new File(SystemProperties.getJavaHome(), "lib"); javaLib.listFiles(file -> { if (file.getName().endsWith(".jar")) { diff --git a/src/test/java/org/apache/bcel/classfile/CodeExceptionTest.java b/src/test/java/org/apache/bcel/classfile/CodeExceptionTest.java index 756a2ed2..4762e80c 100644 --- a/src/test/java/org/apache/bcel/classfile/CodeExceptionTest.java +++ b/src/test/java/org/apache/bcel/classfile/CodeExceptionTest.java @@ -27,7 +27,7 @@ public class CodeExceptionTest { * Tests that we do not break binary compatibility with BCEL-330. */ @Test - public void testReferenceToConstant() { + void testReferenceToConstant() { @SuppressWarnings("unused") final short referenceToConstant = Constants.AALOAD; } diff --git a/src/test/java/org/apache/bcel/classfile/ConstantPoolModuleToStringTest.java b/src/test/java/org/apache/bcel/classfile/ConstantPoolModuleToStringTest.java index a808fa40..16381af7 100644 --- a/src/test/java/org/apache/bcel/classfile/ConstantPoolModuleToStringTest.java +++ b/src/test/java/org/apache/bcel/classfile/ConstantPoolModuleToStringTest.java @@ -479,7 +479,7 @@ public class ConstantPoolModuleToStringTest { } @Test - public void test() throws Exception { + void test() throws Exception { final Enumeration<URL> moduleURLs = getClass().getClassLoader().getResources("module-info.class"); while (moduleURLs.hasMoreElements()) { final URL url = moduleURLs.nextElement(); diff --git a/src/test/java/org/apache/bcel/classfile/ConstantPoolTest.java b/src/test/java/org/apache/bcel/classfile/ConstantPoolTest.java index 630dc8c9..587cae4a 100644 --- a/src/test/java/org/apache/bcel/classfile/ConstantPoolTest.java +++ b/src/test/java/org/apache/bcel/classfile/ConstantPoolTest.java @@ -51,7 +51,7 @@ public class ConstantPoolTest extends AbstractTest { } @Test - public void testClassWithDoubleConstantPoolItem() throws ClassNotFoundException, IOException { + void testClassWithDoubleConstantPoolItem() throws ClassNotFoundException, IOException { try (ClassPath cp = new ClassPath("target/test-classes/org/apache/bcel/classfile")) { final ClassWithDoubleConstantPoolItem classWithDoubleConstantPoolItem = new ClassWithDoubleConstantPoolItem(); final JavaClass c = new ClassPathRepository(cp).loadClass(classWithDoubleConstantPoolItem.getClass()); @@ -77,7 +77,7 @@ public class ConstantPoolTest extends AbstractTest { } @Test - public void testClassWithLongConstantPoolItem() throws ClassNotFoundException, IOException { + void testClassWithLongConstantPoolItem() throws ClassNotFoundException, IOException { try (ClassPath cp = new ClassPath("target/test-classes/org/apache/bcel/classfile")) { final ClassWithLongConstantPoolItem classWithLongConstantPoolItem = new ClassWithLongConstantPoolItem(); final JavaClass c = new ClassPathRepository(cp).loadClass(classWithLongConstantPoolItem.getClass()); @@ -103,7 +103,7 @@ public class ConstantPoolTest extends AbstractTest { } @Test - public void testConstantToString() throws ClassNotFoundException { + void testConstantToString() throws ClassNotFoundException { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.SimpleClassWithDefaultConstructor"); final ConstantPoolGen cp = new ConstantPoolGen(clazz.getConstantPool()); final Method[] methods = clazz.getMethods(); @@ -131,7 +131,7 @@ public class ConstantPoolTest extends AbstractTest { } @Test - public void testTooManyConstants() throws ClassNotFoundException { + void testTooManyConstants() throws ClassNotFoundException { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.SimpleClassWithDefaultConstructor"); final ConstantPoolGen cp = new ConstantPoolGen(clazz.getConstantPool()); int i = cp.getSize(); diff --git a/src/test/java/org/apache/bcel/classfile/ConstantTest.java b/src/test/java/org/apache/bcel/classfile/ConstantTest.java index 6808d10e..3922cd16 100644 --- a/src/test/java/org/apache/bcel/classfile/ConstantTest.java +++ b/src/test/java/org/apache/bcel/classfile/ConstantTest.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; public class ConstantTest { @Test - public void testBCELComparator() throws Exception { + void testBCELComparator() throws Exception { final Constant obj = new ConstantClass(1); assertTrue(Constant.getComparator().equals(null, null)); assertTrue(Constant.getComparator().equals(obj, obj)); diff --git a/src/test/java/org/apache/bcel/classfile/FieldTest.java b/src/test/java/org/apache/bcel/classfile/FieldTest.java index bda9c7c6..757d3535 100644 --- a/src/test/java/org/apache/bcel/classfile/FieldTest.java +++ b/src/test/java/org/apache/bcel/classfile/FieldTest.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; public class FieldTest { @Test - public void testBCELComparator() throws Exception { + void testBCELComparator() throws Exception { final Field obj = new Field(1, 1, 1, null, null); assertTrue(Field.getComparator().equals(null, null)); assertTrue(Field.getComparator().equals(obj, obj)); diff --git a/src/test/java/org/apache/bcel/classfile/InvalidMethodSigantureTest.java b/src/test/java/org/apache/bcel/classfile/InvalidMethodSigantureTest.java index fa078c39..4b37a83a 100644 --- a/src/test/java/org/apache/bcel/classfile/InvalidMethodSigantureTest.java +++ b/src/test/java/org/apache/bcel/classfile/InvalidMethodSigantureTest.java @@ -63,7 +63,7 @@ public class InvalidMethodSigantureTest { private static final String SRC_TEST_RESOURCES_KOTLIN = "src/test/resources/kotlin/"; @Test - public void testLoadClass() throws Exception { + void testLoadClass() throws Exception { final Path path = Paths.get(SRC_TEST_RESOURCES_KOTLIN); assertTrue(Files.exists(path)); assertTrue(Files.isDirectory(path)); diff --git a/src/test/java/org/apache/bcel/classfile/JDKClassDumpTest.java b/src/test/java/org/apache/bcel/classfile/JDKClassDumpTest.java index a495ed5a..b203b4ab 100644 --- a/src/test/java/org/apache/bcel/classfile/JDKClassDumpTest.java +++ b/src/test/java/org/apache/bcel/classfile/JDKClassDumpTest.java @@ -82,7 +82,7 @@ public class JDKClassDumpTest { } @Test - public void testPerformanceJmod() throws Exception { + void testPerformanceJmod() throws Exception { JavaHome.streamModulePath().forEach(path -> assertDoesNotThrow(() -> testJar(path))); } } diff --git a/src/test/java/org/apache/bcel/classfile/Jira368Test.java b/src/test/java/org/apache/bcel/classfile/Jira368Test.java index 9d95b952..c710dabd 100644 --- a/src/test/java/org/apache/bcel/classfile/Jira368Test.java +++ b/src/test/java/org/apache/bcel/classfile/Jira368Test.java @@ -36,7 +36,7 @@ public class Jira368Test { } @Test - public void testInstructionListStringBrief() throws Exception { + void testInstructionListStringBrief() throws Exception { for (final Method method : parseJavaClass().getMethods()) { if (!method.isAbstract() && !method.isNative()) { final InstructionList instructionList = new InstructionList(method.getCode().getCode()); @@ -47,7 +47,7 @@ public class Jira368Test { } @Test - public void testInstructionListStringVerbose() throws Exception { + void testInstructionListStringVerbose() throws Exception { for (final Method method : parseJavaClass().getMethods()) { if (!method.isAbstract() && !method.isNative()) { final InstructionList instructionList = new InstructionList(method.getCode().getCode()); @@ -58,7 +58,7 @@ public class Jira368Test { } @Test - public void testMethodSignature() throws Exception { + void testMethodSignature() throws Exception { final String string = parseJavaClass().toString(); // System.out.println(string); assertNotNull(string); diff --git a/src/test/java/org/apache/bcel/classfile/LocalVariableTest.java b/src/test/java/org/apache/bcel/classfile/LocalVariableTest.java index 9ffe1712..b973edc9 100644 --- a/src/test/java/org/apache/bcel/classfile/LocalVariableTest.java +++ b/src/test/java/org/apache/bcel/classfile/LocalVariableTest.java @@ -27,7 +27,7 @@ public class LocalVariableTest { * Tests that we do not break binary compatibility with BCEL-330. */ @Test - public void testReferenceToConstant() { + void testReferenceToConstant() { @SuppressWarnings("unused") final short referenceToConstant = Constants.AALOAD; } diff --git a/src/test/java/org/apache/bcel/classfile/RecordTest.java b/src/test/java/org/apache/bcel/classfile/RecordTest.java index 427c1b9d..5d78ec21 100644 --- a/src/test/java/org/apache/bcel/classfile/RecordTest.java +++ b/src/test/java/org/apache/bcel/classfile/RecordTest.java @@ -37,7 +37,7 @@ public class RecordTest extends AbstractTest { * Check that we can copy a attribute correctly. */ @Test - public void recordsCanBeCopied() throws ClassNotFoundException, IOException { + void recordsCanBeCopied() throws ClassNotFoundException, IOException { final JavaClass clazz = new ClassParser("src/test/resources/record/SimpleRecord.class").parse(); final JavaClass copyClazz = clazz.copy(); assertEquals(clazz.toString(), copyClazz.toString(), "both records should have the same value"); @@ -47,7 +47,7 @@ public class RecordTest extends AbstractTest { * Check that a record can be visited by our visitors */ @Test - public void recordsCanBeVisited() throws ClassNotFoundException, IOException { + void recordsCanBeVisited() throws ClassNotFoundException, IOException { final JavaClass clazz = new ClassParser("src/test/resources/record/SimpleRecord.class").parse(); final CountingVisitor countVisitor = new CountingVisitor(); final DescendingVisitor desendingVisitor = new DescendingVisitor(clazz, countVisitor); @@ -60,7 +60,7 @@ public class RecordTest extends AbstractTest { * Check that we can save and load the attribute correctly. */ @Test - public void testAttributeSerializtion() throws ClassNotFoundException, IOException { + void testAttributeSerializtion() throws ClassNotFoundException, IOException { final JavaClass clazz = new ClassParser("src/test/resources/record/SimpleRecord.class").parse(); final File tfile = createTestdataFile("SimpleRecord.class"); final Record recordAttribute = (Record) findAttribute("Record", clazz)[0]; @@ -83,7 +83,7 @@ public class RecordTest extends AbstractTest { * @throws ClassFormatException */ @Test - public void testRecordClassSaysItIs() throws ClassNotFoundException, ClassFormatException, IOException { + void testRecordClassSaysItIs() throws ClassNotFoundException, ClassFormatException, IOException { final JavaClass clazz = new ClassParser("src/test/resources/record/SimpleRecord.class").parse(); assertTrue(clazz.isRecord(), "Expected SimpleRecord class to say it was a record - but it didn't !"); final JavaClass simpleClazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.SimpleClass"); @@ -99,7 +99,7 @@ public class RecordTest extends AbstractTest { * @throws IOException if an I/O error occurs. */ @Test - public void testRecordToString() throws ClassNotFoundException, ClassFormatException, IOException { + void testRecordToString() throws ClassNotFoundException, ClassFormatException, IOException { final JavaClass clazz = new ClassParser("src/test/resources/record/SimpleRecord.class").parse(); final Attribute[] attributes = clazz.getAttributes(); final Record recordAttribute = (Record) findAttribute("Record", clazz)[0]; diff --git a/src/test/java/org/apache/bcel/classfile/SignatureTest.java b/src/test/java/org/apache/bcel/classfile/SignatureTest.java index e3f1ec3c..a7f61811 100644 --- a/src/test/java/org/apache/bcel/classfile/SignatureTest.java +++ b/src/test/java/org/apache/bcel/classfile/SignatureTest.java @@ -36,13 +36,13 @@ import org.junit.jupiter.api.Test; public class SignatureTest extends AbstractTest { @Test - public void testBadSignatures() throws Exception { + void testBadSignatures() throws Exception { assertThrowsExactly(IllegalArgumentException.class, () -> Signature.translate("<")); assertThrowsExactly(IllegalArgumentException.class, () -> Signature.translate("<>")); } @Test - public void testMap() throws Exception { + void testMap() throws Exception { final JavaClass jc = Repository.lookupClass(Map.class); final Signature classSignature = (Signature) findAttribute("Signature", jc.getAttributes()); final String translatedSignature = Signature.translate(classSignature.getSignature()); @@ -59,7 +59,7 @@ public class SignatureTest extends AbstractTest { } @Test - public void testString() throws Exception { + void testString() throws Exception { final JavaClass jc = Repository.lookupClass(String.class); final Signature classSignature = (Signature) findAttribute("Signature", jc.getAttributes()); final String translatedSignature = Signature.translate(classSignature.getSignature()); @@ -69,7 +69,7 @@ public class SignatureTest extends AbstractTest { } @Test - public void testType() throws Exception { + void testType() throws Exception { assertEquals("(I)I", Type.getSignature(Math.class.getMethod("abs", int.class))); assertEquals("(J)J", Type.getSignature(Math.class.getMethod("abs", long.class))); assertEquals("(D)D", Type.getSignature(Math.class.getMethod("abs", double.class))); diff --git a/src/test/java/org/apache/bcel/classfile/StackMapTest.java b/src/test/java/org/apache/bcel/classfile/StackMapTest.java index 9accb8c4..c6b301d4 100644 --- a/src/test/java/org/apache/bcel/classfile/StackMapTest.java +++ b/src/test/java/org/apache/bcel/classfile/StackMapTest.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; public class StackMapTest { @Test - public void testSetStackMap() { + void testSetStackMap() { final StackMap stackMap = new StackMap(0, 0, StackMapEntry.EMPTY_ARRAY, new ConstantPool(new Constant[] { new ConstantLong(0) })); // No NPE stackMap.setStackMap(null); diff --git a/src/test/java/org/apache/bcel/classfile/UtilityTest.java b/src/test/java/org/apache/bcel/classfile/UtilityTest.java index e8dc9e83..58e5a558 100644 --- a/src/test/java/org/apache/bcel/classfile/UtilityTest.java +++ b/src/test/java/org/apache/bcel/classfile/UtilityTest.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; public class UtilityTest { @Test - public void testClearBit() { + void testClearBit() { assertEquals(0, Utility.clearBit(0, 0)); assertEquals(0, Utility.clearBit(1, 0), "1 bit 0 set to 0 -> 0"); assertEquals(1, Utility.clearBit(1, 1), "1 bit 1 is 0 hence no change"); @@ -45,7 +45,7 @@ public class UtilityTest { } @Test - public void testCodeToString() throws Exception { + void testCodeToString() throws Exception { final class CodeToString { int[][] a = new int[0][0]; @@ -88,7 +88,7 @@ public class UtilityTest { } @Test - public void testConvertString() { + void testConvertString() { assertEquals("\\n", Utility.convertString("\n")); assertEquals("\\r", Utility.convertString("\r")); assertEquals("\\\"", Utility.convertString("\"")); @@ -98,7 +98,7 @@ public class UtilityTest { } @Test - public void testIsSet() { + void testIsSet() { assertTrue(Utility.isSet(1, 0)); assertTrue(Utility.isSet(7, 1)); assertTrue(Utility.isSet(8, 3)); @@ -110,7 +110,7 @@ public class UtilityTest { } @Test - public void testPrintArray() { + void testPrintArray() { assertNull(Utility.printArray(null, false, false)); assertEquals("", Utility.printArray(new Object[0], false, false)); assertEquals("{}", Utility.printArray(new Object[0], true, false)); @@ -122,7 +122,7 @@ public class UtilityTest { } @Test - public void testSearchOpcode() { + void testSearchOpcode() { assertEquals(Const.ALOAD, Utility.searchOpcode("aload")); assertEquals(Const.NOP, Utility.searchOpcode("nop")); assertEquals(Const.BREAKPOINT, Utility.searchOpcode("breakpoint")); @@ -132,7 +132,7 @@ public class UtilityTest { } @Test - public void testSetBit() { + void testSetBit() { assertEquals(1, Utility.setBit(0, 0), "0 bit 0 set to 1 -> 1"); assertEquals(1, Utility.setBit(1, 0), "1 bit 0 is 1 hence no change"); assertEquals(3, Utility.setBit(1, 1), "1 bit 1 set to 1 -> 3"); @@ -143,7 +143,7 @@ public class UtilityTest { } @Test - public void testSignatureToStringWithGenerics() throws Exception { + void testSignatureToStringWithGenerics() throws Exception { // tests for BCEL-197 assertEquals("java.util.Map<X, java.util.List<Y>>", Utility.signatureToString("Ljava/util/Map<TX;Ljava/util/List<TY;>;>;"), "generic signature"); assertEquals("java.util.Set<? extends java.nio.file.OpenOption>", Utility.signatureToString("Ljava/util/Set<+Ljava/nio/file/OpenOption;>;"), diff --git a/src/test/java/org/apache/bcel/generic/AnnotationGenTest.java b/src/test/java/org/apache/bcel/generic/AnnotationGenTest.java index 69f98f9b..96bc66d4 100644 --- a/src/test/java/org/apache/bcel/generic/AnnotationGenTest.java +++ b/src/test/java/org/apache/bcel/generic/AnnotationGenTest.java @@ -71,7 +71,7 @@ public class AnnotationGenTest extends AbstractTest { * Programmatically construct an mutable annotation (AnnotationGen) object. */ @Test - public void testConstructMutableAnnotation() throws IOException { + void testConstructMutableAnnotation() throws IOException { // Create the containing class final ClassGen cg = createClassGen("HelloWorld"); final ConstantPoolGen cp = cg.getConstantPool(); @@ -92,7 +92,7 @@ public class AnnotationGenTest extends AbstractTest { } @Test - public void testVisibleInvisibleAnnotationGen() { + void testVisibleInvisibleAnnotationGen() { // Create the containing class final ClassGen cg = createClassGen("HelloWorld"); final ConstantPoolGen cp = cg.getConstantPool(); diff --git a/src/test/java/org/apache/bcel/generic/ArrayTypeTest.java b/src/test/java/org/apache/bcel/generic/ArrayTypeTest.java index 3eb41649..a1f40ceb 100644 --- a/src/test/java/org/apache/bcel/generic/ArrayTypeTest.java +++ b/src/test/java/org/apache/bcel/generic/ArrayTypeTest.java @@ -26,62 +26,62 @@ import org.junit.jupiter.api.Test; public class ArrayTypeTest { @Test - public void testGetBasicType() { + void testGetBasicType() { final BasicType type = Type.BYTE; final ArrayType objectType = new ArrayType(type, 1); assertEquals(type, objectType.getBasicType()); } @Test - public void testGetClassName() { + void testGetClassName() { final ArrayType objectType = new ArrayType(Type.BYTE, 1); assertEquals("[B", objectType.getClassName()); assertEquals(byte[].class.getName(), objectType.getClassName()); } @Test - public void testGetDimensions() { + void testGetDimensions() { final int dimensions = 1; final ArrayType objectType = new ArrayType(Type.BYTE, dimensions); assertEquals(dimensions, objectType.getDimensions()); } @Test - public void testGetElementType() { + void testGetElementType() { final BasicType type = Type.BYTE; final ArrayType objectType = new ArrayType(Type.BYTE, 1); assertEquals(type, objectType.getElementType()); } @Test - public void testGetSignatureDim1() { + void testGetSignatureDim1() { final ArrayType objectType = new ArrayType(Type.BYTE, 1); assertEquals("[B", objectType.getSignature()); assertEquals(byte[].class.getName(), objectType.getSignature()); } @Test - public void testGetSignatureDim2() { + void testGetSignatureDim2() { final ArrayType objectType = new ArrayType(Type.BYTE, 2); assertEquals("[[B", objectType.getSignature()); assertEquals(byte[][].class.getName(), objectType.getSignature()); } @Test - public void testGetSignatureDim4() { + void testGetSignatureDim4() { final ArrayType objectType = new ArrayType(Type.BYTE, 4); assertEquals("[[[[B", objectType.getSignature()); assertEquals(byte[][][][].class.getName(), objectType.getSignature()); } @Test - public void testGetSize() { + void testGetSize() { final ArrayType objectType = new ArrayType(Type.BYTE, 1); assertEquals(1, objectType.getSize()); } @Test - public void testGetType() { + void testGetType() { final ArrayType objectType = new ArrayType(Type.BYTE, 1); assertEquals(13, objectType.getType()); } diff --git a/src/test/java/org/apache/bcel/generic/BREAKPOINTTest.java b/src/test/java/org/apache/bcel/generic/BREAKPOINTTest.java index f31d22c6..966ab612 100644 --- a/src/test/java/org/apache/bcel/generic/BREAKPOINTTest.java +++ b/src/test/java/org/apache/bcel/generic/BREAKPOINTTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class BREAKPOINTTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final BREAKPOINT breakpoint = new BREAKPOINT(); breakpoint.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/BasicTypeTest.java b/src/test/java/org/apache/bcel/generic/BasicTypeTest.java index 11509010..d56f96a9 100644 --- a/src/test/java/org/apache/bcel/generic/BasicTypeTest.java +++ b/src/test/java/org/apache/bcel/generic/BasicTypeTest.java @@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test; public class BasicTypeTest { @Test - public void testClassName() { + void testClassName() { assertEquals(boolean.class.getName(), BasicType.getType(Const.T_BOOLEAN).getClassName()); assertEquals(byte.class.getName(), BasicType.getType(Const.T_BYTE).getClassName()); assertEquals(char.class.getName(), BasicType.getType(Const.T_CHAR).getClassName()); @@ -40,12 +40,12 @@ public class BasicTypeTest { } @Test - public void testGetType() { + void testGetType() { assertEquals(Type.BYTE, BasicType.getType(Const.T_BYTE)); } @Test - public void testSignature() { + void testSignature() { assertEquals("Z", BasicType.getType(Const.T_BOOLEAN).getSignature()); assertEquals("B", BasicType.getType(Const.T_BYTE).getSignature()); assertEquals("C", BasicType.getType(Const.T_CHAR).getSignature()); diff --git a/src/test/java/org/apache/bcel/generic/BranchHandleTest.java b/src/test/java/org/apache/bcel/generic/BranchHandleTest.java index 2c6707f7..7787f5d4 100644 --- a/src/test/java/org/apache/bcel/generic/BranchHandleTest.java +++ b/src/test/java/org/apache/bcel/generic/BranchHandleTest.java @@ -26,12 +26,12 @@ import org.junit.jupiter.api.Test; public class BranchHandleTest { @Test - public void testGetBHnull() { + void testGetBHnull() { assertThrows(ClassGenException.class, () -> BranchHandle.getBranchHandle(null)); } @Test - public void testsetInstructionBI() { + void testsetInstructionBI() { final BranchHandle bh = BranchHandle.getBranchHandle(new GOTO(null)); // have to start with a valid BI assertNotNull(bh); bh.setInstruction(new GOTO(null)); @@ -39,7 +39,7 @@ public class BranchHandleTest { } @Test - public void testsetInstructionnotBI() { + void testsetInstructionnotBI() { final BranchHandle bh = BranchHandle.getBranchHandle(new GOTO(null)); // have to start with a valid BI assertNotNull(bh); assertThrows(ClassGenException.class, () -> bh.setInstruction(new NOP())); @@ -47,7 +47,7 @@ public class BranchHandleTest { // Test that setInstruction only allows BranchInstructions @Test - public void testsetInstructionNull() { + void testsetInstructionNull() { final BranchHandle bh = BranchHandle.getBranchHandle(new GOTO(null)); // have to start with a valid BI assertNotNull(bh); assertThrows(ClassGenException.class, () -> bh.setInstruction(null)); diff --git a/src/test/java/org/apache/bcel/generic/ClassGenTest.java b/src/test/java/org/apache/bcel/generic/ClassGenTest.java index 04d8dcae..7f0da3ac 100644 --- a/src/test/java/org/apache/bcel/generic/ClassGenTest.java +++ b/src/test/java/org/apache/bcel/generic/ClassGenTest.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; public class ClassGenTest { @Test - public void testBCELComparator() throws Exception { + void testBCELComparator() throws Exception { final ClassGen obj = new ClassGen("", "", "", 0, null); assertTrue(ClassGen.getComparator().equals(null, null)); assertTrue(ClassGen.getComparator().equals(obj, obj)); diff --git a/src/test/java/org/apache/bcel/generic/D2FTest.java b/src/test/java/org/apache/bcel/generic/D2FTest.java index e9081a48..19b18f56 100644 --- a/src/test/java/org/apache/bcel/generic/D2FTest.java +++ b/src/test/java/org/apache/bcel/generic/D2FTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class D2FTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final D2F d2f = new D2F(); d2f.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/D2ITest.java b/src/test/java/org/apache/bcel/generic/D2ITest.java index 703fdcec..d6f4802d 100644 --- a/src/test/java/org/apache/bcel/generic/D2ITest.java +++ b/src/test/java/org/apache/bcel/generic/D2ITest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class D2ITest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final D2I d2i = new D2I(); d2i.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/D2LTest.java b/src/test/java/org/apache/bcel/generic/D2LTest.java index f81b95d2..4e0ac410 100644 --- a/src/test/java/org/apache/bcel/generic/D2LTest.java +++ b/src/test/java/org/apache/bcel/generic/D2LTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class D2LTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final D2L d2l = new D2L(); d2l.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/DADDTest.java b/src/test/java/org/apache/bcel/generic/DADDTest.java index 5999f87b..a3864253 100644 --- a/src/test/java/org/apache/bcel/generic/DADDTest.java +++ b/src/test/java/org/apache/bcel/generic/DADDTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class DADDTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final DADD dadd = new DADD(); dadd.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/DDIVTest.java b/src/test/java/org/apache/bcel/generic/DDIVTest.java index bd743d5b..74c088b4 100644 --- a/src/test/java/org/apache/bcel/generic/DDIVTest.java +++ b/src/test/java/org/apache/bcel/generic/DDIVTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class DDIVTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final DDIV ddiv = new DDIV(); ddiv.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/DMULTest.java b/src/test/java/org/apache/bcel/generic/DMULTest.java index ee801581..1051b1db 100644 --- a/src/test/java/org/apache/bcel/generic/DMULTest.java +++ b/src/test/java/org/apache/bcel/generic/DMULTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class DMULTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final DMUL dmul = new DMUL(); dmul.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/DNEGTest.java b/src/test/java/org/apache/bcel/generic/DNEGTest.java index 1e0e1f2c..ca916ddf 100644 --- a/src/test/java/org/apache/bcel/generic/DNEGTest.java +++ b/src/test/java/org/apache/bcel/generic/DNEGTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class DNEGTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final DNEG dneg = new DNEG(); dneg.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/DREMTest.java b/src/test/java/org/apache/bcel/generic/DREMTest.java index a88674d1..fd178b9e 100644 --- a/src/test/java/org/apache/bcel/generic/DREMTest.java +++ b/src/test/java/org/apache/bcel/generic/DREMTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class DREMTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final DREM drem = new DREM(); drem.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/DSUBTest.java b/src/test/java/org/apache/bcel/generic/DSUBTest.java index 40607774..4769f76e 100644 --- a/src/test/java/org/apache/bcel/generic/DSUBTest.java +++ b/src/test/java/org/apache/bcel/generic/DSUBTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class DSUBTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final DSUB dsub = new DSUB(); dsub.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/F2DTest.java b/src/test/java/org/apache/bcel/generic/F2DTest.java index 08ae4b87..09e7d7de 100644 --- a/src/test/java/org/apache/bcel/generic/F2DTest.java +++ b/src/test/java/org/apache/bcel/generic/F2DTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class F2DTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final F2D f2d = new F2D(); f2d.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/F2ITest.java b/src/test/java/org/apache/bcel/generic/F2ITest.java index dc4c14a3..714085b1 100644 --- a/src/test/java/org/apache/bcel/generic/F2ITest.java +++ b/src/test/java/org/apache/bcel/generic/F2ITest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class F2ITest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final F2I f2i = new F2I(); f2i.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/F2LTest.java b/src/test/java/org/apache/bcel/generic/F2LTest.java index 28687e18..1d64e45a 100644 --- a/src/test/java/org/apache/bcel/generic/F2LTest.java +++ b/src/test/java/org/apache/bcel/generic/F2LTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class F2LTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final F2L f2l = new F2L(); f2l.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/FADDTest.java b/src/test/java/org/apache/bcel/generic/FADDTest.java index 4c20a046..2b98947f 100644 --- a/src/test/java/org/apache/bcel/generic/FADDTest.java +++ b/src/test/java/org/apache/bcel/generic/FADDTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class FADDTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final FADD fadd = new FADD(); fadd.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/FDIVTest.java b/src/test/java/org/apache/bcel/generic/FDIVTest.java index dfc55d28..6675c9ac 100644 --- a/src/test/java/org/apache/bcel/generic/FDIVTest.java +++ b/src/test/java/org/apache/bcel/generic/FDIVTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class FDIVTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final FDIV fdiv = new FDIV(); fdiv.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/FMULTest.java b/src/test/java/org/apache/bcel/generic/FMULTest.java index 636a1b14..0151d582 100644 --- a/src/test/java/org/apache/bcel/generic/FMULTest.java +++ b/src/test/java/org/apache/bcel/generic/FMULTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class FMULTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final FMUL fmul = new FMUL(); fmul.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/FNEGTest.java b/src/test/java/org/apache/bcel/generic/FNEGTest.java index 7c0f5fab..3fbb16b4 100644 --- a/src/test/java/org/apache/bcel/generic/FNEGTest.java +++ b/src/test/java/org/apache/bcel/generic/FNEGTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class FNEGTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final FNEG fneg = new FNEG(); fneg.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/FREMTest.java b/src/test/java/org/apache/bcel/generic/FREMTest.java index a3408e71..8d2168d3 100644 --- a/src/test/java/org/apache/bcel/generic/FREMTest.java +++ b/src/test/java/org/apache/bcel/generic/FREMTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class FREMTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final FREM frem = new FREM(); frem.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/FSUBTest.java b/src/test/java/org/apache/bcel/generic/FSUBTest.java index f4658daa..af87d280 100644 --- a/src/test/java/org/apache/bcel/generic/FSUBTest.java +++ b/src/test/java/org/apache/bcel/generic/FSUBTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class FSUBTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final FSUB fsub = new FSUB(); fsub.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/FieldAnnotationsTest.java b/src/test/java/org/apache/bcel/generic/FieldAnnotationsTest.java index 9ffd89f8..65b3bc29 100644 --- a/src/test/java/org/apache/bcel/generic/FieldAnnotationsTest.java +++ b/src/test/java/org/apache/bcel/generic/FieldAnnotationsTest.java @@ -63,7 +63,7 @@ public class FieldAnnotationsTest extends AbstractTest { * Check field AnnotationEntrys are retrievable. */ @Test - public void testFieldAnnotationEntrys() throws ClassNotFoundException { + void testFieldAnnotationEntrys() throws ClassNotFoundException { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.AnnotatedFields"); // TODO L...;? checkAnnotatedField(clazz, "i", "L" + PACKAGE_BASE_SIG + "/data/SimpleAnnotation;", "id", "1"); @@ -74,7 +74,7 @@ public class FieldAnnotationsTest extends AbstractTest { * Check field AnnotationEntrys (de)serialize ok. */ @Test - public void testFieldAnnotationEntrysReadWrite() throws ClassNotFoundException, IOException { + void testFieldAnnotationEntrysReadWrite() throws ClassNotFoundException, IOException { final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.AnnotatedFields"); checkAnnotatedField(clazz, "i", "L" + PACKAGE_BASE_SIG + "/data/SimpleAnnotation;", "id", "1"); checkAnnotatedField(clazz, "s", "L" + PACKAGE_BASE_SIG + "/data/SimpleAnnotation;", "id", "2"); @@ -92,7 +92,7 @@ public class FieldAnnotationsTest extends AbstractTest { * Check we can load in a class, modify its field AnnotationEntrys, save it, reload it and everything is correct. */ @Test - public void testFieldAnnotationModification() throws ClassNotFoundException { + void testFieldAnnotationModification() throws ClassNotFoundException { final boolean dbg = false; final JavaClass clazz = getTestJavaClass(PACKAGE_BASE_NAME + ".data.AnnotatedFields"); final ClassGen clg = new ClassGen(clazz); diff --git a/src/test/java/org/apache/bcel/generic/GETFIELDTest.java b/src/test/java/org/apache/bcel/generic/GETFIELDTest.java index 663f3fc1..a03155c8 100644 --- a/src/test/java/org/apache/bcel/generic/GETFIELDTest.java +++ b/src/test/java/org/apache/bcel/generic/GETFIELDTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class GETFIELDTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final GETFIELD getfield = new GETFIELD(0); getfield.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/GeneratingAnnotatedClassesTest.java b/src/test/java/org/apache/bcel/generic/GeneratingAnnotatedClassesTest.java index a9bd6d43..25d1adda 100644 --- a/src/test/java/org/apache/bcel/generic/GeneratingAnnotatedClassesTest.java +++ b/src/test/java/org/apache/bcel/generic/GeneratingAnnotatedClassesTest.java @@ -340,7 +340,7 @@ public class GeneratingAnnotatedClassesTest extends AbstractTest { * </ol> */ @Test - public void testGenerateClassLevelAnnotations() throws ClassNotFoundException { + void testGenerateClassLevelAnnotations() throws ClassNotFoundException { // Create HelloWorld final ClassGen cg = createClassGen("HelloWorld"); cg.setMajor(49); @@ -371,7 +371,7 @@ public class GeneratingAnnotatedClassesTest extends AbstractTest { * Just check that we can dump a class that has a method annotation on it and it is still there when we read it back in */ @Test - public void testGenerateMethodLevelAnnotations1() throws ClassNotFoundException { + void testGenerateMethodLevelAnnotations1() throws ClassNotFoundException { // Create HelloWorld final ClassGen cg = createClassGen("HelloWorld"); final ConstantPoolGen cp = cg.getConstantPool(); @@ -404,7 +404,7 @@ public class GeneratingAnnotatedClassesTest extends AbstractTest { * annotations. */ @Test - public void testGenerateMethodLevelAnnotations2() throws ClassNotFoundException { + void testGenerateMethodLevelAnnotations2() throws ClassNotFoundException { // Create HelloWorld final ClassGen cg = createClassGen("HelloWorld"); final ConstantPoolGen cp = cg.getConstantPool(); @@ -440,7 +440,7 @@ public class GeneratingAnnotatedClassesTest extends AbstractTest { * Load a class in and modify it with a new attribute - A SimpleAnnotation annotation */ @Test - public void testModifyingClasses1() throws ClassNotFoundException { + void testModifyingClasses1() throws ClassNotFoundException { final JavaClass jc = getTestJavaClass(PACKAGE_BASE_NAME + ".data.SimpleAnnotatedClass"); final ClassGen cgen = new ClassGen(jc); final ConstantPoolGen cp = cgen.getConstantPool(); @@ -454,7 +454,7 @@ public class GeneratingAnnotatedClassesTest extends AbstractTest { * Load a class in and modify it with a new attribute - A ComplexAnnotation annotation */ @Test - public void testModifyingClasses2() throws ClassNotFoundException { + void testModifyingClasses2() throws ClassNotFoundException { final JavaClass jc = getTestJavaClass(PACKAGE_BASE_NAME + ".data.SimpleAnnotatedClass"); final ClassGen cgen = new ClassGen(jc); final ConstantPoolGen cp = cgen.getConstantPool(); @@ -472,7 +472,7 @@ public class GeneratingAnnotatedClassesTest extends AbstractTest { * array of SimpleAnnotations. */ @Test - public void testTransformClassToClassGen_ArrayAndAnnotationTypes() throws ClassNotFoundException { + void testTransformClassToClassGen_ArrayAndAnnotationTypes() throws ClassNotFoundException { final JavaClass jc = getTestJavaClass(PACKAGE_BASE_NAME + ".data.AnnotatedWithCombinedAnnotation"); final ClassGen cgen = new ClassGen(jc); // Check annotations are correctly preserved @@ -518,7 +518,7 @@ public class GeneratingAnnotatedClassesTest extends AbstractTest { * enum. */ @Test - public void testTransformClassToClassGen_EnumType() throws ClassNotFoundException { + void testTransformClassToClassGen_EnumType() throws ClassNotFoundException { final JavaClass jc = getTestJavaClass(PACKAGE_BASE_NAME + ".data.AnnotatedWithEnumClass"); final ClassGen cgen = new ClassGen(jc); // Check annotations are correctly preserved @@ -531,7 +531,7 @@ public class GeneratingAnnotatedClassesTest extends AbstractTest { * Transform simple class from an immutable to a mutable object. */ @Test - public void testTransformClassToClassGen_SimpleTypes() throws ClassNotFoundException { + void testTransformClassToClassGen_SimpleTypes() throws ClassNotFoundException { final JavaClass jc = getTestJavaClass(PACKAGE_BASE_NAME + ".data.SimpleAnnotatedClass"); final ClassGen cgen = new ClassGen(jc); // Check annotations are correctly preserved @@ -543,7 +543,7 @@ public class GeneratingAnnotatedClassesTest extends AbstractTest { * Transform complex class from an immutable to a mutable object. */ @Test - public void testTransformComplexClassToClassGen() throws ClassNotFoundException { + void testTransformComplexClassToClassGen() throws ClassNotFoundException { final JavaClass jc = getTestJavaClass(PACKAGE_BASE_NAME + ".data.ComplexAnnotatedClass"); final ClassGen cgen = new ClassGen(jc); // Check annotations are correctly preserved diff --git a/src/test/java/org/apache/bcel/generic/I2BTest.java b/src/test/java/org/apache/bcel/generic/I2BTest.java index 42e10f7b..97729640 100644 --- a/src/test/java/org/apache/bcel/generic/I2BTest.java +++ b/src/test/java/org/apache/bcel/generic/I2BTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class I2BTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final I2B i2b = new I2B(); i2b.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/I2CTest.java b/src/test/java/org/apache/bcel/generic/I2CTest.java index 6a84e281..1dd953ed 100644 --- a/src/test/java/org/apache/bcel/generic/I2CTest.java +++ b/src/test/java/org/apache/bcel/generic/I2CTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class I2CTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final I2C i2c = new I2C(); i2c.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/I2DTest.java b/src/test/java/org/apache/bcel/generic/I2DTest.java index 5c6898d8..2bb171cf 100644 --- a/src/test/java/org/apache/bcel/generic/I2DTest.java +++ b/src/test/java/org/apache/bcel/generic/I2DTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class I2DTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final I2D i2d = new I2D(); i2d.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/I2FTest.java b/src/test/java/org/apache/bcel/generic/I2FTest.java index f2fbad25..924403e9 100644 --- a/src/test/java/org/apache/bcel/generic/I2FTest.java +++ b/src/test/java/org/apache/bcel/generic/I2FTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class I2FTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final I2F i2f = new I2F(); i2f.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/I2LTest.java b/src/test/java/org/apache/bcel/generic/I2LTest.java index 7d26948e..88fa2ad1 100644 --- a/src/test/java/org/apache/bcel/generic/I2LTest.java +++ b/src/test/java/org/apache/bcel/generic/I2LTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class I2LTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final I2L i2l = new I2L(); i2l.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/I2STest.java b/src/test/java/org/apache/bcel/generic/I2STest.java index 7bbe034a..217d0f2b 100644 --- a/src/test/java/org/apache/bcel/generic/I2STest.java +++ b/src/test/java/org/apache/bcel/generic/I2STest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class I2STest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final I2S i2s = new I2S(); i2s.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/IADDTest.java b/src/test/java/org/apache/bcel/generic/IADDTest.java index 9c86a752..d46d12ba 100644 --- a/src/test/java/org/apache/bcel/generic/IADDTest.java +++ b/src/test/java/org/apache/bcel/generic/IADDTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class IADDTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final IADD iadd = new IADD(); iadd.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/IANDTest.java b/src/test/java/org/apache/bcel/generic/IANDTest.java index 802404f1..7870afd2 100644 --- a/src/test/java/org/apache/bcel/generic/IANDTest.java +++ b/src/test/java/org/apache/bcel/generic/IANDTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class IANDTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final IAND iand = new IAND(); iand.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/IDIVTest.java b/src/test/java/org/apache/bcel/generic/IDIVTest.java index 6a695773..5ecac6d6 100644 --- a/src/test/java/org/apache/bcel/generic/IDIVTest.java +++ b/src/test/java/org/apache/bcel/generic/IDIVTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class IDIVTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final IDIV idiv = new IDIV(); idiv.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/IMPDEP1Test.java b/src/test/java/org/apache/bcel/generic/IMPDEP1Test.java index 3fcbc750..743d23f1 100644 --- a/src/test/java/org/apache/bcel/generic/IMPDEP1Test.java +++ b/src/test/java/org/apache/bcel/generic/IMPDEP1Test.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class IMPDEP1Test { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final IMPDEP1 impdep1 = new IMPDEP1(); impdep1.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/IMPDEP2Test.java b/src/test/java/org/apache/bcel/generic/IMPDEP2Test.java index 26c5998e..8f266bfb 100644 --- a/src/test/java/org/apache/bcel/generic/IMPDEP2Test.java +++ b/src/test/java/org/apache/bcel/generic/IMPDEP2Test.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class IMPDEP2Test { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final IMPDEP2 impdep2 = new IMPDEP2(); impdep2.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/IMULTest.java b/src/test/java/org/apache/bcel/generic/IMULTest.java index d3b4077c..fd207c65 100644 --- a/src/test/java/org/apache/bcel/generic/IMULTest.java +++ b/src/test/java/org/apache/bcel/generic/IMULTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class IMULTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final IMUL imul = new IMUL(); imul.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/INEGTest.java b/src/test/java/org/apache/bcel/generic/INEGTest.java index 020aa7d7..ed3ead4f 100644 --- a/src/test/java/org/apache/bcel/generic/INEGTest.java +++ b/src/test/java/org/apache/bcel/generic/INEGTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class INEGTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final INEG ineg = new INEG(); ineg.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/IORTest.java b/src/test/java/org/apache/bcel/generic/IORTest.java index 73664fe2..6614a2ca 100644 --- a/src/test/java/org/apache/bcel/generic/IORTest.java +++ b/src/test/java/org/apache/bcel/generic/IORTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class IORTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final IOR ior = new IOR(); ior.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/IREMTest.java b/src/test/java/org/apache/bcel/generic/IREMTest.java index 0ca4ca11..15e99a12 100644 --- a/src/test/java/org/apache/bcel/generic/IREMTest.java +++ b/src/test/java/org/apache/bcel/generic/IREMTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class IREMTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final IREM irem = new IREM(); irem.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/ISHLTest.java b/src/test/java/org/apache/bcel/generic/ISHLTest.java index 4d15d63c..ef0f6842 100644 --- a/src/test/java/org/apache/bcel/generic/ISHLTest.java +++ b/src/test/java/org/apache/bcel/generic/ISHLTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class ISHLTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final ISHL ishl = new ISHL(); ishl.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/ISHRTest.java b/src/test/java/org/apache/bcel/generic/ISHRTest.java index 0e25516a..4dcfe265 100644 --- a/src/test/java/org/apache/bcel/generic/ISHRTest.java +++ b/src/test/java/org/apache/bcel/generic/ISHRTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class ISHRTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final ISHR ishr = new ISHR(); ishr.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/ISUBTest.java b/src/test/java/org/apache/bcel/generic/ISUBTest.java index ff439d18..ea7ef3f7 100644 --- a/src/test/java/org/apache/bcel/generic/ISUBTest.java +++ b/src/test/java/org/apache/bcel/generic/ISUBTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class ISUBTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final ISUB isub = new ISUB(); isub.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/IXORTest.java b/src/test/java/org/apache/bcel/generic/IXORTest.java index fec94ee4..6c73c6c2 100644 --- a/src/test/java/org/apache/bcel/generic/IXORTest.java +++ b/src/test/java/org/apache/bcel/generic/IXORTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class IXORTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final IXOR ixor = new IXOR(); ixor.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/InstructionFactoryTest.java b/src/test/java/org/apache/bcel/generic/InstructionFactoryTest.java index 44b0cf84..efb35176 100644 --- a/src/test/java/org/apache/bcel/generic/InstructionFactoryTest.java +++ b/src/test/java/org/apache/bcel/generic/InstructionFactoryTest.java @@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test; public class InstructionFactoryTest extends AbstractTest { @Test - public void testArrayLoad() throws Exception { + void testArrayLoad() throws Exception { assertEquals(InstructionConst.BALOAD, createArrayLoad(Type.BOOLEAN)); assertEquals(InstructionConst.BALOAD, createArrayLoad(Type.BYTE)); assertEquals(InstructionConst.CALOAD, createArrayLoad(Type.CHAR)); @@ -51,7 +51,7 @@ public class InstructionFactoryTest extends AbstractTest { } @Test - public void testArrayStore() throws Exception { + void testArrayStore() throws Exception { assertEquals(InstructionConst.BASTORE, createArrayStore(Type.BOOLEAN)); assertEquals(InstructionConst.BASTORE, createArrayStore(Type.BYTE)); assertEquals(InstructionConst.CASTORE, createArrayStore(Type.CHAR)); @@ -65,13 +65,13 @@ public class InstructionFactoryTest extends AbstractTest { } @Test - public void testCreateInvokeNullArgTypes() throws Exception { + void testCreateInvokeNullArgTypes() throws Exception { final InstructionFactory factory = new InstructionFactory(new ClassGen(Repository.lookupClass(Object.class))); factory.createInvoke("", "", Type.VOID, null, Const.INVOKESPECIAL, false); // Mustn't throw an NPE } @Test - public void testExceptions() throws Exception { + void testExceptions() throws Exception { final InstructionFactory factory = new InstructionFactory(new ClassGen(Repository.lookupClass(Object.class))); assertThrowsExactly(IllegalArgumentException.class, () -> createArrayLoad(Type.UNKNOWN)); assertThrowsExactly(IllegalArgumentException.class, () -> createArrayStore(Type.UNKNOWN)); @@ -92,7 +92,7 @@ public class InstructionFactoryTest extends AbstractTest { } @Test - public void testNull() throws Exception { + void testNull() throws Exception { assertEquals(InstructionConst.ICONST_0, createNull(Type.BOOLEAN)); assertEquals(InstructionConst.ICONST_0, createNull(Type.BYTE)); assertEquals(InstructionConst.ICONST_0, createNull(Type.CHAR)); diff --git a/src/test/java/org/apache/bcel/generic/InstructionHandleTest.java b/src/test/java/org/apache/bcel/generic/InstructionHandleTest.java index 7a5d08d1..65c90b2e 100644 --- a/src/test/java/org/apache/bcel/generic/InstructionHandleTest.java +++ b/src/test/java/org/apache/bcel/generic/InstructionHandleTest.java @@ -28,7 +28,7 @@ public class InstructionHandleTest { // Test that setInstruction only allows Instructions that are not BranchInstructions @Test - public void testBCEL195() { + void testBCEL195() { final InstructionList il = new InstructionList(); final InstructionHandle ih = il.append(InstructionConst.NOP); new TABLESWITCH(new int[0], InstructionHandle.EMPTY_ARRAY, ih); @@ -36,12 +36,12 @@ public class InstructionHandleTest { } @Test - public void testGetIHnull() { + void testGetIHnull() { assertThrows(ClassGenException.class, () -> InstructionHandle.getInstructionHandle(null)); } @Test - public void testsetInstructionI() { + void testsetInstructionI() { final InstructionHandle ih = InstructionHandle.getInstructionHandle(new NOP()); // have to start with a valid non BI assertNotNull(ih); ih.setInstruction(new NOP()); @@ -49,14 +49,14 @@ public class InstructionHandleTest { } @Test - public void testsetInstructionnotI() { + void testsetInstructionnotI() { final InstructionHandle ih = InstructionHandle.getInstructionHandle(new NOP()); // have to start with a valid non BI assertNotNull(ih); assertThrows(ClassGenException.class, () -> ih.setInstruction(new GOTO(null))); } @Test - public void testsetInstructionNull() { + void testsetInstructionNull() { final InstructionHandle ih = InstructionHandle.getInstructionHandle(new NOP()); // have to start with a valid non BI assertNotNull(ih); assertThrows(ClassGenException.class, () -> ih.setInstruction(null)); diff --git a/src/test/java/org/apache/bcel/generic/JiraBcel362Test.java b/src/test/java/org/apache/bcel/generic/JiraBcel362Test.java index 35acbfd8..a07c5f4a 100644 --- a/src/test/java/org/apache/bcel/generic/JiraBcel362Test.java +++ b/src/test/java/org/apache/bcel/generic/JiraBcel362Test.java @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; public class JiraBcel362Test extends AbstractTest { @Test - public void testProcessConstantPoolWithCondyEntry() throws ClassNotFoundException { + void testProcessConstantPoolWithCondyEntry() throws ClassNotFoundException { final JavaClass clazz = getTestJavaClass("issue362.Bcel362"); final ConstantPoolGen constantPoolGen = assertDoesNotThrow(() -> new ConstantPoolGen(clazz.getConstantPool())); assertTrue(constantPoolGen.lookupUtf8("$jacocoData") != -1); diff --git a/src/test/java/org/apache/bcel/generic/L2DTest.java b/src/test/java/org/apache/bcel/generic/L2DTest.java index 8905abb5..112ba194 100644 --- a/src/test/java/org/apache/bcel/generic/L2DTest.java +++ b/src/test/java/org/apache/bcel/generic/L2DTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class L2DTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final L2D l2d = new L2D(); l2d.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/L2FTest.java b/src/test/java/org/apache/bcel/generic/L2FTest.java index e41e1c75..1e7afb38 100644 --- a/src/test/java/org/apache/bcel/generic/L2FTest.java +++ b/src/test/java/org/apache/bcel/generic/L2FTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class L2FTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final L2F l2f = new L2F(); l2f.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/L2ITest.java b/src/test/java/org/apache/bcel/generic/L2ITest.java index 113fffaf..4fa4d423 100644 --- a/src/test/java/org/apache/bcel/generic/L2ITest.java +++ b/src/test/java/org/apache/bcel/generic/L2ITest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class L2ITest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final L2I l2i = new L2I(); l2i.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/LADDTest.java b/src/test/java/org/apache/bcel/generic/LADDTest.java index c753c34a..b58661b5 100644 --- a/src/test/java/org/apache/bcel/generic/LADDTest.java +++ b/src/test/java/org/apache/bcel/generic/LADDTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class LADDTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final LADD ladd = new LADD(); ladd.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/LANDTest.java b/src/test/java/org/apache/bcel/generic/LANDTest.java index 7b4aa3ad..ef6a5ad0 100644 --- a/src/test/java/org/apache/bcel/generic/LANDTest.java +++ b/src/test/java/org/apache/bcel/generic/LANDTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class LANDTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final LAND land = new LAND(); land.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/LCMPTest.java b/src/test/java/org/apache/bcel/generic/LCMPTest.java index 033a1642..56621de7 100644 --- a/src/test/java/org/apache/bcel/generic/LCMPTest.java +++ b/src/test/java/org/apache/bcel/generic/LCMPTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class LCMPTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final LCMP lcmp = new LCMP(); lcmp.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/LDIVTest.java b/src/test/java/org/apache/bcel/generic/LDIVTest.java index 6a269c28..2da5ed3f 100644 --- a/src/test/java/org/apache/bcel/generic/LDIVTest.java +++ b/src/test/java/org/apache/bcel/generic/LDIVTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class LDIVTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final LDIV ldiv = new LDIV(); ldiv.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/LMULTest.java b/src/test/java/org/apache/bcel/generic/LMULTest.java index 7fc07fec..e842c9f1 100644 --- a/src/test/java/org/apache/bcel/generic/LMULTest.java +++ b/src/test/java/org/apache/bcel/generic/LMULTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class LMULTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final LMUL lmul = new LMUL(); lmul.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/LNEGTest.java b/src/test/java/org/apache/bcel/generic/LNEGTest.java index ebb0cbcb..9df79438 100644 --- a/src/test/java/org/apache/bcel/generic/LNEGTest.java +++ b/src/test/java/org/apache/bcel/generic/LNEGTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class LNEGTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final LNEG lneg = new LNEG(); lneg.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/LORTest.java b/src/test/java/org/apache/bcel/generic/LORTest.java index 7deee4e0..d646a466 100644 --- a/src/test/java/org/apache/bcel/generic/LORTest.java +++ b/src/test/java/org/apache/bcel/generic/LORTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class LORTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final LOR lor = new LOR(); lor.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/LREMTest.java b/src/test/java/org/apache/bcel/generic/LREMTest.java index 3715d4da..9ddbebc3 100644 --- a/src/test/java/org/apache/bcel/generic/LREMTest.java +++ b/src/test/java/org/apache/bcel/generic/LREMTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class LREMTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final LREM lrem = new LREM(); lrem.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/LSHLTest.java b/src/test/java/org/apache/bcel/generic/LSHLTest.java index 9b3237fb..0ccea464 100644 --- a/src/test/java/org/apache/bcel/generic/LSHLTest.java +++ b/src/test/java/org/apache/bcel/generic/LSHLTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class LSHLTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final LSHL lshl = new LSHL(); lshl.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/LSHRTest.java b/src/test/java/org/apache/bcel/generic/LSHRTest.java index 4f230daf..d8766f9f 100644 --- a/src/test/java/org/apache/bcel/generic/LSHRTest.java +++ b/src/test/java/org/apache/bcel/generic/LSHRTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class LSHRTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final LSHR lshr = new LSHR(); lshr.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/LSUBTest.java b/src/test/java/org/apache/bcel/generic/LSUBTest.java index 4fcf5184..390eb2b3 100644 --- a/src/test/java/org/apache/bcel/generic/LSUBTest.java +++ b/src/test/java/org/apache/bcel/generic/LSUBTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class LSUBTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final LSUB lsub = new LSUB(); lsub.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/LXORTest.java b/src/test/java/org/apache/bcel/generic/LXORTest.java index 98d2024a..12b3cc8a 100644 --- a/src/test/java/org/apache/bcel/generic/LXORTest.java +++ b/src/test/java/org/apache/bcel/generic/LXORTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class LXORTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final LXOR lxor = new LXOR(); lxor.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/MethodGenTest.java b/src/test/java/org/apache/bcel/generic/MethodGenTest.java index 7299f118..daf3b9c5 100644 --- a/src/test/java/org/apache/bcel/generic/MethodGenTest.java +++ b/src/test/java/org/apache/bcel/generic/MethodGenTest.java @@ -72,7 +72,7 @@ public class MethodGenTest { } @Test - public void testAnnotationsAreUnpacked() throws Exception { + void testAnnotationsAreUnpacked() throws Exception { final JavaClass jc = Repository.lookupClass(Bar.Inner.class); final ClassGen cg = new ClassGen(jc); final MethodGen mg = new MethodGen(cg.getMethodAt(0), cg.getClassName(), cg.getConstantPool()); @@ -91,17 +91,17 @@ public class MethodGenTest { } @Test - public void testInvalidNullMethodBody_EmptyStaticInit() throws Exception { + void testInvalidNullMethodBody_EmptyStaticInit() throws Exception { testInvalidNullMethodBody("org.apache.bcel.generic.EmptyStaticInit"); } @Test - public void testInvalidNullMethodBody_MailDateFormat() { + void testInvalidNullMethodBody_MailDateFormat() { assertThrows(IllegalStateException.class, () -> testInvalidNullMethodBody("javax.mail.internet.MailDateFormat")); } @Test - public void testRemoveLocalVariable() throws Exception { + void testRemoveLocalVariable() throws Exception { final MethodGen mg = getMethod(Foo.class, "bar"); final LocalVariableGen lv = mg.getLocalVariables()[1]; @@ -123,7 +123,7 @@ public class MethodGenTest { } @Test - public void testRemoveLocalVariables() throws Exception { + void testRemoveLocalVariables() throws Exception { final MethodGen mg = getMethod(Foo.class, "bar"); final LocalVariableGen lv = mg.getLocalVariables()[1]; diff --git a/src/test/java/org/apache/bcel/generic/ObjectTypeTest.java b/src/test/java/org/apache/bcel/generic/ObjectTypeTest.java index c53d254f..518df287 100644 --- a/src/test/java/org/apache/bcel/generic/ObjectTypeTest.java +++ b/src/test/java/org/apache/bcel/generic/ObjectTypeTest.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; public class ObjectTypeTest { @Test - public void testGetClassName() { + void testGetClassName() { final String className = BigDecimal.class.getName(); final ObjectType objectType = ObjectType.getInstance(className); assertEquals(className, objectType.getClassName()); diff --git a/src/test/java/org/apache/bcel/generic/PUTFIELDTest.java b/src/test/java/org/apache/bcel/generic/PUTFIELDTest.java index ef2313df..af362d30 100644 --- a/src/test/java/org/apache/bcel/generic/PUTFIELDTest.java +++ b/src/test/java/org/apache/bcel/generic/PUTFIELDTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class PUTFIELDTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final PUTFIELD putfield = new PUTFIELD(0); putfield.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/PUTSTATICTest.java b/src/test/java/org/apache/bcel/generic/PUTSTATICTest.java index b7ddc877..fd8b4a5c 100644 --- a/src/test/java/org/apache/bcel/generic/PUTSTATICTest.java +++ b/src/test/java/org/apache/bcel/generic/PUTSTATICTest.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; public class PUTSTATICTest { @Test - public void testAccept() { + void testAccept() { final CountingVisitor countVisitor = new CountingVisitor(); final PUTSTATIC putstatic = new PUTSTATIC(0); putstatic.accept(countVisitor); diff --git a/src/test/java/org/apache/bcel/generic/TypeTest.java b/src/test/java/org/apache/bcel/generic/TypeTest.java index fad586a4..e836ed37 100644 --- a/src/test/java/org/apache/bcel/generic/TypeTest.java +++ b/src/test/java/org/apache/bcel/generic/TypeTest.java @@ -32,7 +32,7 @@ import org.junit.jupiter.params.provider.ValueSource; public class TypeTest { @Test - public void testBCEL243() { + void testBCEL243() { // expectedValue = "Ljava/util/Map<TX;Ljava/util/List<TY;>;>;"; // The line commented out above is the correct expected value; however, // the constructor for ObjectType is yet another place where BCEL does @@ -43,7 +43,7 @@ public class TypeTest { } @Test - public void testInternalTypeNametoSignature() { + void testInternalTypeNametoSignature() { assertNull(Type.internalTypeNameToSignature(null)); assertEquals("", Type.internalTypeNameToSignature("")); assertEquals("TT;", Type.internalTypeNameToSignature("TT;")); diff --git a/src/test/java/org/apache/bcel/util/BCELifierTest.java b/src/test/java/org/apache/bcel/util/BCELifierTest.java index 5895f9db..fd7ecdfe 100644 --- a/src/test/java/org/apache/bcel/util/BCELifierTest.java +++ b/src/test/java/org/apache/bcel/util/BCELifierTest.java @@ -162,7 +162,7 @@ public class BCELifierTest extends AbstractTest { } @Test - public void testHelloWorld() throws Exception { + void testHelloWorld() throws Exception { HelloWorldCreator.main(new String[] {}); final File workDir = new File("target"); final String javaAgent = getJavaAgent(); @@ -198,7 +198,7 @@ public class BCELifierTest extends AbstractTest { } @Test - public void testMainNoArg() throws Exception { + void testMainNoArg() throws Exception { final PrintStream sysout = System.out; try { final ByteArrayOutputStream out = new ByteArrayOutputStream(); @@ -220,7 +220,7 @@ public class BCELifierTest extends AbstractTest { } @Test - public void testStart() throws Exception { + void testStart() throws Exception { final OutputStream os = new ByteArrayOutputStream(); final JavaClass javaClass = BCELifier.getJavaClass("Java8Example"); assertNotNull(javaClass); diff --git a/src/test/java/org/apache/bcel/util/Class2HTMLTest.java b/src/test/java/org/apache/bcel/util/Class2HTMLTest.java index e56fbad4..a7c585a7 100644 --- a/src/test/java/org/apache/bcel/util/Class2HTMLTest.java +++ b/src/test/java/org/apache/bcel/util/Class2HTMLTest.java @@ -57,7 +57,7 @@ public class Class2HTMLTest { * Tests that we do not break binary compatibility with BCEL-330. */ @Test - public void testReferenceToConstant() { + void testReferenceToConstant() { @SuppressWarnings("unused") final short referenceToConstant = Constants.AALOAD; } diff --git a/src/test/java/org/apache/bcel/util/ClassPathRepositoryTest.java b/src/test/java/org/apache/bcel/util/ClassPathRepositoryTest.java index 6b43f854..09ea837c 100644 --- a/src/test/java/org/apache/bcel/util/ClassPathRepositoryTest.java +++ b/src/test/java/org/apache/bcel/util/ClassPathRepositoryTest.java @@ -38,7 +38,7 @@ import org.junit.jupiter.api.Test; public class ClassPathRepositoryTest { @Test - public void testClassPath() throws IOException { + void testClassPath() throws IOException { try (ClassPath classPath = new ClassPath("")) { final ClassPathRepository repository = new ClassPathRepository(classPath); try (ClassPath repoCp = repository.getClassPath()) { @@ -48,14 +48,14 @@ public class ClassPathRepositoryTest { } @Test - public void testClassPathRepository() throws ClassNotFoundException, IOException { + void testClassPathRepository() throws ClassNotFoundException, IOException { try (ClassPath classPath = new ClassPath("")) { verifyCaching(new ClassPathRepository(classPath)); } } @Test - public void testClassWithoutPackage() throws IOException { + void testClassWithoutPackage() throws IOException { try (ClassPath classPath = new ClassPath("")) { final ClassPathRepository repository = new ClassPathRepository(classPath); assertThrows(ClassNotFoundException.class, () -> repository.loadClass("ClassXYZ")); @@ -63,7 +63,7 @@ public class ClassPathRepositoryTest { } @Test - public void testEmptyInput() throws IOException { + void testEmptyInput() throws IOException { try (ClassPath classPath = new ClassPath("")) { final ClassPathRepository repository = new ClassPathRepository(classPath); assertThrows(IllegalArgumentException.class, () -> repository.loadClass("")); @@ -71,21 +71,21 @@ public class ClassPathRepositoryTest { } @Test - public void testLruCacheClassPathRepository() throws ClassNotFoundException, IOException { + void testLruCacheClassPathRepository() throws ClassNotFoundException, IOException { try (ClassPath classPath = new ClassPath("")) { verifyCaching(new LruCacheClassPathRepository(classPath, 10)); } } @Test - public void testMemorySensitiveClassPathRepository() throws ClassNotFoundException, IOException { + void testMemorySensitiveClassPathRepository() throws ClassNotFoundException, IOException { try (ClassPath classPath = new ClassPath("")) { verifyCaching(new MemorySensitiveClassPathRepository(classPath)); } } @Test - public void testNoClassNotFound() throws IOException { + void testNoClassNotFound() throws IOException { try (ClassPath classPath = new ClassPath("")) { final ClassPathRepository repository = new ClassPathRepository(classPath); assertThrows(ClassNotFoundException.class, () -> repository.loadClass("no.such.Class")); @@ -93,7 +93,7 @@ public class ClassPathRepositoryTest { } @Test - public void testNullInput() throws IOException { + void testNullInput() throws IOException { try (ClassPath classPath = new ClassPath("")) { final ClassPathRepository repository = new ClassPathRepository(classPath); assertThrows(IllegalArgumentException.class, () -> repository.loadClass((String) null)); diff --git a/src/test/java/org/apache/bcel/util/ClassPathTest.java b/src/test/java/org/apache/bcel/util/ClassPathTest.java index 63901c95..ed5331ff 100644 --- a/src/test/java/org/apache/bcel/util/ClassPathTest.java +++ b/src/test/java/org/apache/bcel/util/ClassPathTest.java @@ -37,24 +37,24 @@ public class ClassPathTest extends AbstractTest { } @Test - public void testGetClassFile() throws IOException { + void testGetClassFile() throws IOException { assertNotNull(ClassPath.SYSTEM_CLASS_PATH.getClassFile("java.lang.String")); } @Test - public void testGetResource() { + void testGetResource() { assertNotNull(ClassPath.SYSTEM_CLASS_PATH.getResource("java/lang/String.class")); } @Test - public void testGetResourceAsStream() throws IOException { + void testGetResourceAsStream() throws IOException { try (InputStream inputStream = ClassPath.SYSTEM_CLASS_PATH.getResourceAsStream("java/lang/String.class")) { assertNotNull(inputStream); } } @Test - public void testGetResources() { + void testGetResources() { assertTrue(ClassPath.SYSTEM_CLASS_PATH.getResources("java/lang/String.class").hasMoreElements()); } } diff --git a/src/test/java/org/apache/bcel/util/InstructionFinderTest.java b/src/test/java/org/apache/bcel/util/InstructionFinderTest.java index 47410cda..adb3c59e 100644 --- a/src/test/java/org/apache/bcel/util/InstructionFinderTest.java +++ b/src/test/java/org/apache/bcel/util/InstructionFinderTest.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; public class InstructionFinderTest extends AbstractTest { @Test - public void testSearch() { + void testSearch() { final InstructionList il = new InstructionList(); il.append(new ILOAD(1)); il.append(new ILOAD(2)); diff --git a/src/test/java/org/apache/bcel/util/LruCacheClassPathRepositoryTest.java b/src/test/java/org/apache/bcel/util/LruCacheClassPathRepositoryTest.java index 78158490..e9dab3bd 100644 --- a/src/test/java/org/apache/bcel/util/LruCacheClassPathRepositoryTest.java +++ b/src/test/java/org/apache/bcel/util/LruCacheClassPathRepositoryTest.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; public class LruCacheClassPathRepositoryTest { @Test - public void testCacheEviction() throws ClassNotFoundException, IOException { + void testCacheEviction() throws ClassNotFoundException, IOException { try (ClassPath classPath = new ClassPath("")) { final LruCacheClassPathRepository repository = new LruCacheClassPathRepository(classPath, 2); final JavaClass class1 = repository.loadClass("java.lang.String"); @@ -51,7 +51,7 @@ public class LruCacheClassPathRepositoryTest { } @Test - public void testLeastRecentlyUsedEviction() throws ClassNotFoundException, IOException { + void testLeastRecentlyUsedEviction() throws ClassNotFoundException, IOException { try (ClassPath classPath = new ClassPath("")) { final LruCacheClassPathRepository repository = new LruCacheClassPathRepository(classPath, 2); final JavaClass class1 = repository.loadClass("java.lang.String"); @@ -69,7 +69,7 @@ public class LruCacheClassPathRepositoryTest { } @Test - public void testZeroCacheSize() throws IOException { + void testZeroCacheSize() throws IOException { try (ClassPath classPath = new ClassPath("")) { assertThrows(IllegalArgumentException.class, () -> new LruCacheClassPathRepository(classPath, 0)); } diff --git a/src/test/java/org/apache/bcel/verifier/JiraBcel291Test.java b/src/test/java/org/apache/bcel/verifier/JiraBcel291Test.java index c1efddfb..cd01f210 100644 --- a/src/test/java/org/apache/bcel/verifier/JiraBcel291Test.java +++ b/src/test/java/org/apache/bcel/verifier/JiraBcel291Test.java @@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test; public class JiraBcel291Test { @Test - public void test() throws ClassNotFoundException { + void test() throws ClassNotFoundException { Verifier.verifyType("org.apache.bcel.verifier.tests.JiraBcel291TestFixture"); } } diff --git a/src/test/java/org/apache/bcel/verifier/JiraBcel369Test.java b/src/test/java/org/apache/bcel/verifier/JiraBcel369Test.java index 8f01b86a..3155d06c 100644 --- a/src/test/java/org/apache/bcel/verifier/JiraBcel369Test.java +++ b/src/test/java/org/apache/bcel/verifier/JiraBcel369Test.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; public class JiraBcel369Test extends AbstractTest { @Test - public void testCompileAndVerify() throws ClassNotFoundException { + void testCompileAndVerify() throws ClassNotFoundException { Verifier.verifyType(org.apache.bcel.verifier.JiraBcel369TestFixture.class.getName()); } diff --git a/src/test/java/org/apache/bcel/verifier/VerifierArrayAccessTest.java b/src/test/java/org/apache/bcel/verifier/VerifierArrayAccessTest.java index f89ecf74..c395e430 100644 --- a/src/test/java/org/apache/bcel/verifier/VerifierArrayAccessTest.java +++ b/src/test/java/org/apache/bcel/verifier/VerifierArrayAccessTest.java @@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test; public class VerifierArrayAccessTest extends AbstractVerifierTest { @Test - public void testInvalidArrayAccess() throws IOException, ClassNotFoundException { + void testInvalidArrayAccess() throws IOException, ClassNotFoundException { new TestArrayAccess03Creator().create(); assertVerifyRejected("TestArrayAccess03", "Verification of an arraystore instruction on an object must fail."); new TestArrayAccess04IntCreator().create(); @@ -53,7 +53,7 @@ public class VerifierArrayAccessTest extends AbstractVerifierTest { } @Test - public void testValidArrayAccess() throws IOException, ClassNotFoundException { + void testValidArrayAccess() throws IOException, ClassNotFoundException { assertVerifyOK("TestArrayAccess01", "Verification of an arraystore instruction on an array that is not compatible with the stored element must pass."); new TestArrayAccess02Creator().create(); assertVerifyOK("TestArrayAccess02", "Verification of an arraystore instruction on an array that is not compatible with the stored element must pass."); diff --git a/src/test/java/org/apache/bcel/verifier/VerifierInvokeTest.java b/src/test/java/org/apache/bcel/verifier/VerifierInvokeTest.java index 0be345d2..7b907718 100644 --- a/src/test/java/org/apache/bcel/verifier/VerifierInvokeTest.java +++ b/src/test/java/org/apache/bcel/verifier/VerifierInvokeTest.java @@ -24,23 +24,23 @@ import org.junit.jupiter.api.Test; public class VerifierInvokeTest extends AbstractVerifierTest { @Test - public void testLegalInvokeInterface() throws ClassNotFoundException { + void testLegalInvokeInterface() throws ClassNotFoundException { assertVerifyOK("TestLegalInvokeInterface01", "Verification of invokeinterface on method defined in superinterface must pass."); } @Test - public void testLegalInvokeSpecial() throws ClassNotFoundException { + void testLegalInvokeSpecial() throws ClassNotFoundException { assertVerifyOK("TestLegalInvokeSpecial01", "Verification of invokespecial on method defined in superclass must pass."); assertVerifyOK("TestLegalInvokeSpecial02", "Verification of invokespecial on method defined in superclass must pass."); } @Test - public void testLegalInvokeStatic() throws ClassNotFoundException { + void testLegalInvokeStatic() throws ClassNotFoundException { assertVerifyOK("TestLegalInvokeStatic01", "Verification of invokestatic on method defined in superclass must pass."); } @Test - public void testLegalInvokeVirtual() throws ClassNotFoundException { + void testLegalInvokeVirtual() throws ClassNotFoundException { assertVerifyOK("TestLegalInvokeVirtual01", "Verification of invokevirtual on method defined in superclass must pass."); assertVerifyOK("TestLegalInvokeVirtual02", "Verification of invokevirtual on method defined in superinterface must pass."); } diff --git a/src/test/java/org/apache/bcel/verifier/VerifierMainTest.java b/src/test/java/org/apache/bcel/verifier/VerifierMainTest.java index 188a1c3e..bde615d9 100644 --- a/src/test/java/org/apache/bcel/verifier/VerifierMainTest.java +++ b/src/test/java/org/apache/bcel/verifier/VerifierMainTest.java @@ -45,7 +45,7 @@ import org.junit.jupiter.api.Test; public class VerifierMainTest extends AbstractTest { @Test - public void testSWAP() throws Exception { + void testSWAP() throws Exception { final String[] argv = { "src/test/java/org/apache/bcel/data/SWAP.java", "-g", "-source", "1.4", "-target", "1.4", "-d", "target/test-classes" }; new Main(new PrintWriter(System.out), new PrintWriter(System.err), false/*systemExit*/, null/*options*/, null/*progress*/).compile(argv); final String javaAgent = getJavaAgent(); diff --git a/src/test/java/org/apache/bcel/verifier/VerifierReturnTest.java b/src/test/java/org/apache/bcel/verifier/VerifierReturnTest.java index 61581902..7f66c9fe 100644 --- a/src/test/java/org/apache/bcel/verifier/VerifierReturnTest.java +++ b/src/test/java/org/apache/bcel/verifier/VerifierReturnTest.java @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; public class VerifierReturnTest extends AbstractVerifierTest { @Test - public void testInvalidReturn() throws IOException, ClassNotFoundException { + void testInvalidReturn() throws IOException, ClassNotFoundException { new TestReturn01Creator().create(); assertVerifyRejected("TestReturn01", "Verification of a void method that returns an object must fail."); new TestReturn03IntCreator().create(); @@ -58,7 +58,7 @@ public class VerifierReturnTest extends AbstractVerifierTest { } @Test - public void testValidReturn() throws ClassNotFoundException { + void testValidReturn() throws ClassNotFoundException { assertVerifyOK("TestReturn02", "Verification of a method that returns a newly created object must pass."); assertVerifyOK("TestArray01", "Verification of a method that returns an array must pass."); } diff --git a/src/test/java/org/apache/bcel/verifier/VerifierTest.java b/src/test/java/org/apache/bcel/verifier/VerifierTest.java index 86fed696..8f9a308c 100644 --- a/src/test/java/org/apache/bcel/verifier/VerifierTest.java +++ b/src/test/java/org/apache/bcel/verifier/VerifierTest.java @@ -115,27 +115,27 @@ public class VerifierTest { } @Test - public void testArrayUtils() throws ClassNotFoundException { + void testArrayUtils() throws ClassNotFoundException { testNestHostWithJavaVersion("org.apache.commons.lang.ArrayUtils"); } @Test - public void testCollection() throws ClassNotFoundException { + void testCollection() throws ClassNotFoundException { testDefaultMethodValidation("java.util.Collection"); } @Test - public void testCommonsLang2() throws IOException, URISyntaxException, ClassNotFoundException { + void testCommonsLang2() throws IOException, URISyntaxException, ClassNotFoundException { testJarFile(getJarFile(org.apache.commons.lang.StringUtils.class), "ArrayUtils", "SerializationUtils"); } @Test - public void testDefinitionImpl() throws ClassNotFoundException { + void testDefinitionImpl() throws ClassNotFoundException { testNestHostWithJavaVersion("com.ibm.wsdl.DefinitionImpl"); } @Test - public void testJvmOpCodes() throws ClassNotFoundException { + void testJvmOpCodes() throws ClassNotFoundException { testDefaultMethodValidation("org.apache.bcel.verifier.tests.JvmOpCodes"); } @@ -152,17 +152,17 @@ public class VerifierTest { } @Test - public void testPackagePrivateField() throws ClassNotFoundException { + void testPackagePrivateField() throws ClassNotFoundException { testDefaultMethodValidation(FieldVerifierChildClass.class.getName()); } @Test - public void testPackagePrivateStaticField() throws ClassNotFoundException { + void testPackagePrivateStaticField() throws ClassNotFoundException { testDefaultMethodValidation(StaticFieldVerifierChildClass.class.getName()); } @Test - public void testWSDL() throws IOException, URISyntaxException, ClassNotFoundException { + void testWSDL() throws IOException, URISyntaxException, ClassNotFoundException { testJarFile(getJarFile(javax.wsdl.Port.class), "WSDLReaderImpl", "DefinitionImpl"); } } diff --git a/src/test/java/org/apache/bcel/verifier/VerifierThrowTest.java b/src/test/java/org/apache/bcel/verifier/VerifierThrowTest.java index c87e07bf..af540b5d 100644 --- a/src/test/java/org/apache/bcel/verifier/VerifierThrowTest.java +++ b/src/test/java/org/apache/bcel/verifier/VerifierThrowTest.java @@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test; public class VerifierThrowTest extends AbstractVerifierTest { @Test - public void testThrowEmptyStack() throws IOException, ClassNotFoundException { + void testThrowEmptyStack() throws IOException, ClassNotFoundException { new TestThrow01Creator().create(); assertVerifyRejected("TestThrow01", "Verification of a method with ATHROW instruction on an empty stack must fail."); } diff --git a/src/test/java/org/apache/bcel/verifier/VerifyBadClassesTest.java b/src/test/java/org/apache/bcel/verifier/VerifyBadClassesTest.java index dac2c135..8f7a2b45 100644 --- a/src/test/java/org/apache/bcel/verifier/VerifyBadClassesTest.java +++ b/src/test/java/org/apache/bcel/verifier/VerifyBadClassesTest.java @@ -110,7 +110,7 @@ public class VerifyBadClassesTest { * BCEL-303: AssertionViolatedException in Pass 3A Verification of invoke instructions */ @Test - public void testB303() { + void testB303() { testVerify("issue303/example", "A"); } @@ -118,7 +118,7 @@ public class VerifyBadClassesTest { * BCEL-307: ClassFormatException thrown in Pass 3A verification */ @Test - public void testB307() { + void testB307() { testVerify("issue307/example", "A"); } @@ -126,7 +126,7 @@ public class VerifyBadClassesTest { * BCEL-308: NullPointerException in Verifier Pass 3A */ @Test - public void testB308() { + void testB308() { testVerify("issue308", "Hello"); } @@ -134,7 +134,7 @@ public class VerifyBadClassesTest { * BCEL-309: NegativeArraySizeException when Code attribute length is negative */ @Test - public void testB309() { + void testB309() { testVerify("issue309", "Hello"); } @@ -142,7 +142,7 @@ public class VerifyBadClassesTest { * BCEL-310: ArrayIndexOutOfBounds in Verifier Pass 3A */ @Test - public void testB310() { + void testB310() { testVerify("issue310", "Hello"); } @@ -150,7 +150,7 @@ public class VerifyBadClassesTest { * BCEL-311: ClassCastException in Verifier Pass 2 */ @Test - public void testB311() { + void testB311() { testVerify("issue311", "Hello"); } @@ -159,7 +159,7 @@ public class VerifyBadClassesTest { * Verifier Pass 2 */ @Test - public void testB312() { + void testB312() { testVerify("issue312", "Hello"); } @@ -167,7 +167,7 @@ public class VerifyBadClassesTest { * BCEL-313: ClassFormatException: Invalid signature: Ljava/lang/String)V in Verifier Pass 3A */ @Test - public void testB313() { + void testB313() { testVerify("issue313", "Hello"); } @@ -175,7 +175,7 @@ public class VerifyBadClassesTest { * BCEL-337: StringIndexOutOfBounds in Pass 2 Verification of empty method names in the constant pool */ @Test - public void testB337() { + void testB337() { testVerify("issue337/example", "A"); } diff --git a/src/test/java/org/apache/bcel/verifier/VerifyJavaMathTest.java b/src/test/java/org/apache/bcel/verifier/VerifyJavaMathTest.java index 0f58d25e..b2d68956 100644 --- a/src/test/java/org/apache/bcel/verifier/VerifyJavaMathTest.java +++ b/src/test/java/org/apache/bcel/verifier/VerifyJavaMathTest.java @@ -35,7 +35,7 @@ public class VerifyJavaMathTest extends AbstractVerifierTest { @Disabled @Test - public void testBigInteger() throws ClassNotFoundException { + void testBigInteger() throws ClassNotFoundException { assertTrue(doAllPasses("java.math.BigInteger")); } diff --git a/src/test/java/org/apache/bcel/verifier/VerifyJavaUtilTest.java b/src/test/java/org/apache/bcel/verifier/VerifyJavaUtilTest.java index 55e8810a..943c18e7 100644 --- a/src/test/java/org/apache/bcel/verifier/VerifyJavaUtilTest.java +++ b/src/test/java/org/apache/bcel/verifier/VerifyJavaUtilTest.java @@ -28,17 +28,17 @@ import org.junit.jupiter.api.Test; public class VerifyJavaUtilTest extends AbstractVerifierTest { @Test - public void testHashMap() throws ClassNotFoundException { + void testHashMap() throws ClassNotFoundException { assertTrue(doAllPasses("java.util.HashMap")); } @Test - public void testLinkedHashMap() throws ClassNotFoundException { + void testLinkedHashMap() throws ClassNotFoundException { assertTrue(doAllPasses("java.util.LinkedHashMap")); } @Test - public void testTreeMap() throws ClassNotFoundException { + void testTreeMap() throws ClassNotFoundException { assertTrue(doAllPasses("java.util.TreeMap")); } diff --git a/src/test/java/org/apache/bcel/verifier/statics/Pass2VerifierTest.java b/src/test/java/org/apache/bcel/verifier/statics/Pass2VerifierTest.java index 9b7ca98e..1a70514d 100644 --- a/src/test/java/org/apache/bcel/verifier/statics/Pass2VerifierTest.java +++ b/src/test/java/org/apache/bcel/verifier/statics/Pass2VerifierTest.java @@ -28,7 +28,7 @@ public class Pass2VerifierTest { * Tests that we do not break binary compatibility with BCEL-330. */ @Test - public void testReferenceToConstant() { + void testReferenceToConstant() { @SuppressWarnings("unused") final short referenceToConstant = Constants.AALOAD; } diff --git a/src/test/java/org/apache/bcel/verifier/structurals/UninitializedObjectTypeTest.java b/src/test/java/org/apache/bcel/verifier/structurals/UninitializedObjectTypeTest.java index 881790b8..1f7e7df0 100644 --- a/src/test/java/org/apache/bcel/verifier/structurals/UninitializedObjectTypeTest.java +++ b/src/test/java/org/apache/bcel/verifier/structurals/UninitializedObjectTypeTest.java @@ -28,7 +28,7 @@ public class UninitializedObjectTypeTest { * Tests that we do not break binary compatibility with BCEL-330. */ @Test - public void testReferenceToConstant() { + void testReferenceToConstant() { @SuppressWarnings("unused") final short referenceToConstant = Constants.AALOAD; }