(commons-fileupload) 08/11: Let JUnit handle exceptions

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch 1.x
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git

commit 9d3aeeee9aac3637a59ac24ae594f4c91864ddaa
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Thu Jun 5 07:56:12 2025 -0400

    Let JUnit handle exceptions
---
 .../fileupload/DiskFileItemSerializeTest.java      | 34 +++++++++++++++-------
 1 file changed, 24 insertions(+), 10 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/fileupload/DiskFileItemSerializeTest.java 
b/src/test/java/org/apache/commons/fileupload/DiskFileItemSerializeTest.java
index a75902a6..1d398a13 100644
--- a/src/test/java/org/apache/commons/fileupload/DiskFileItemSerializeTest.java
+++ b/src/test/java/org/apache/commons/fileupload/DiskFileItemSerializeTest.java
@@ -86,22 +86,24 @@ public class DiskFileItemSerializeTest {
 
     /**
      * Create a FileItem with the specfied content bytes.
+     *
+     * @throws IOException test failure. 
      */
-    private FileItem createFileItem(final byte[] contentBytes) {
+    private FileItem createFileItem(final byte[] contentBytes) throws 
IOException {
         return createFileItem(contentBytes, REPO);
     }
 
     /**
      * Create a FileItem with the specfied content bytes and repository.
+     *
+     * @throws IOException test failure. 
      */
-    private FileItem createFileItem(final byte[] contentBytes, final File 
repository) {
+    private FileItem createFileItem(final byte[] contentBytes, final File 
repository) throws IOException {
         final FileItemFactory factory = new DiskFileItemFactory(THRESHOLD, 
repository);
         final String textFieldName = "textField";
         final FileItem item = factory.createItem(textFieldName, 
CONTENT_TYPE_TEXT, true, "My File Name");
         try (OutputStream os = item.getOutputStream()) {
             os.write(contentBytes);
-        } catch (final IOException e) {
-            fail("Unexpected IOException" + e);
         }
         return item;
     }
@@ -148,9 +150,11 @@ public class DiskFileItemSerializeTest {
 
     /**
      * Test creation of a field for which the amount of data falls above the 
configured threshold.
+     *
+     * @throws IOException test failure. 
      */
     @Test
-    public void testAboveThreshold() {
+    public void testAboveThreshold() throws IOException {
         // Create the FileItem
         final byte[] testFieldValueBytes = createContentBytes(THRESHOLD + 1);
         final FileItem item = createFileItem(testFieldValueBytes);
@@ -163,9 +167,11 @@ public class DiskFileItemSerializeTest {
 
     /**
      * Test creation of a field for which the amount of data falls below the 
configured threshold.
+     *
+     * @throws IOException test failure. 
      */
     @Test
-    public void testBelowThreshold() {
+    public void testBelowThreshold() throws IOException {
         // Create the FileItem
         final byte[] testFieldValueBytes = createContentBytes(THRESHOLD - 1);
         testInMemoryObject(testFieldValueBytes);
@@ -173,15 +179,19 @@ public class DiskFileItemSerializeTest {
 
     /**
      * Helper method to test creation of a field.
+     *
+     * @throws IOException test failure. 
      */
-    private void testInMemoryObject(final byte[] testFieldValueBytes) {
+    private void testInMemoryObject(final byte[] testFieldValueBytes) throws 
IOException {
         testInMemoryObject(testFieldValueBytes, REPO);
     }
 
     /**
      * Helper method to test creation of a field when a repository is used.
+     *
+     * @throws IOException test failure. 
      */
-    private void testInMemoryObject(final byte[] testFieldValueBytes, final 
File repository) {
+    private void testInMemoryObject(final byte[] testFieldValueBytes, final 
File repository) throws IOException {
         final FileItem item = createFileItem(testFieldValueBytes, repository);
         // Check state is as expected
         assertTrue("Initial: in memory", item.isInMemory());
@@ -216,9 +226,11 @@ public class DiskFileItemSerializeTest {
 
     /**
      * Test creation of a field for which the amount of data equals the 
configured threshold.
+     *
+     * @throws IOException test failure. 
      */
     @Test
-    public void testThreshold() {
+    public void testThreshold() throws IOException {
         // Create the FileItem
         final byte[] testFieldValueBytes = createContentBytes(THRESHOLD);
         testInMemoryObject(testFieldValueBytes);
@@ -226,9 +238,11 @@ public class DiskFileItemSerializeTest {
 
     /**
      * Test serialization and deserialization when repository is not null.
+     *
+     * @throws IOException test failure. 
      */
     @Test
-    public void testValidRepository() {
+    public void testValidRepository() throws IOException {
         // Create the FileItem
         final byte[] testFieldValueBytes = createContentBytes(THRESHOLD);
         testInMemoryObject(testFieldValueBytes, REPO);