This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git
The following commit(s) were added to refs/heads/master by this push: new 13aebc396 Add assertions to org.apache.commons.lang3.ClassUtilsTest.test_getShortCanonicalName_String() 13aebc396 is described below commit 13aebc396de9233b8f913afa4b02f62f9d11f819 Author: Gary D. Gregory <garydgreg...@gmail.com> AuthorDate: Wed May 28 18:12:57 2025 -0400 Add assertions to org.apache.commons.lang3.ClassUtilsTest.test_getShortCanonicalName_String() --- src/test/java/org/apache/commons/lang3/ClassUtilsTest.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java b/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java index 9f3b3490b..beda999ae 100644 --- a/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java @@ -584,6 +584,15 @@ public void test_getShortCanonicalName_String() { assertEquals("String[]", ClassUtils.getShortCanonicalName(String[].class.getName())); assertEquals("String[]", ClassUtils.getShortCanonicalName(String[].class.getCanonicalName())); assertEquals("String[]", ClassUtils.getShortCanonicalName("String[]")); + // Note that we throw RuntimeException (but not which one) for the following bad inputs: + assertThrows(RuntimeException.class, () -> ClassUtils.getShortCanonicalName("")); + assertThrows(RuntimeException.class, () -> ClassUtils.getShortCanonicalName("[")); + assertThrows(RuntimeException.class, () -> ClassUtils.getShortCanonicalName("[]")); + assertThrows(RuntimeException.class, () -> ClassUtils.getShortCanonicalName("[;")); + assertThrows(RuntimeException.class, () -> ClassUtils.getShortCanonicalName("[];")); + assertThrows(RuntimeException.class, () -> ClassUtils.getShortCanonicalName(" ")); + assertThrows(RuntimeException.class, () -> ClassUtils.getShortCanonicalName("[$")); + assertThrows(RuntimeException.class, () -> ClassUtils.getShortCanonicalName("[$a")); } @Test