This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.commons-commons-parent-84 in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
discard 79836c54 Bump org.apache.commons:commons-parent from 81 to 84 add bff9a3db Bump github/codeql-action from 3.28.17 to 3.28.18 (#501) add 758df627 Remove extra vertical whitespace add c1e11fda Fix SpotBugs [ERROR] Medium: Shared primitive variable "isSharedConnection" in one thread may not yield the value of the most recent write from another thread [org.apache.commons.dbcp2.managed.ManagedConnection] AT_STALE_THREAD_WRITE_OF_PRIMITIVE add dfd796fd Fix Javadoc add 997e1992 Ad org.apache.commons.dbcp2.datasources.TestPerUserPoolDataSource.testDefaultReadOnly() add 032fd501 Fix Javadoc add 8f8b0bad Don't use parent pom 83 yet add 5ed30e25 Fix SpotBugs [ERROR] Medium: Shared primitive variable "closed" in one thread may not yield the value of the most recent write from another thread [org.apache.commons.dbcp2.cpdsadapter.PooledConnectionImpl] AT_STALE_THREAD_WRITE_OF_PRIMITIVE add 3af43c9f Fix SpotBugs [ERROR] Medium: Shared primitive variable "closed" in one thread may not yield the value of the most recent write from another thread [org.apache.commons.dbcp2.DelegatingStatement] AT_STALE_THREAD_WRITE_OF_PRIMITIVE add 8a4bfcdd Fix SpotBugs [ERROR] Medium: Shared primitive variable "cacheState" in one thread may not yield the value of the most recent write from another thread [org.apache.commons.dbcp2.DelegatingConnection] AT_STALE_THREAD_WRITE_OF_PRIMITIVE add ea6dba61 Fix SpotBugs [ERROR] Medium: Operation on the "fatalSqlExceptionThrown" shared variable in "PoolableConnection" class is not atomic [org.apache.commons.dbcp2.PoolableConnection] AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE add 83d9341e Javadoc add e57fcdb3 Fix SpotBugs [ERROR] Medium: Shared primitive variable "clearStatementPoolOnReturn" in one thread may not yield the value of the most recent write from another thread [org.apache.commons.dbcp2.PoolingConnection] AT_STALE_THREAD_WRITE_OF_PRIMITIVE add 6f6c12e4 Fix SpotBugs [ERROR] Medium: Shared primitive variable "maxTotal" in one thread may not yield the value of the most recent write from another thread [org.apache.commons.dbcp2.datasources.SharedPoolDataSource] AT_STALE_THREAD_WRITE_OF_PRIMITIVE add 2f1b9d9e Fix SpotBugs [ERROR] Medium: Shared primitive variables in one thread may not yield the value of the most recent write from another thread [org.apache.commons.dbcp2.datasources.InstanceKeyDataSource] AT_STALE_THREAD_WRITE_OF_PRIMITIVE add d2761e44 Javadoc add bffe9100 Fix SpotBugs [ERROR] Medium: Shared primitive variables in one thread may not yield the value of the most recent write from another thread [org.apache.commons.dbcp2.cpdsadapter.DriverAdapterCPDS] AT_STALE_THREAD_WRITE_OF_PRIMITIVE add 44a4b74b Fix SpotBugs [ERROR] Medium: Shared primitive variables in one thread may not yield the value of the most recent write from another thread [org.apache.commons.dbcp2.PoolableConnectionFactory] AT_STALE_THREAD_WRITE_OF_PRIMITIVE add 7ccaa5ab Add internal org.apache.commons.dbcp2.datasources.CharArray.clear() add 53462102 Add internal org.apache.commons.dbcp2.datasources.UserPassKey.clear() add dc2c59ac Add org.apache.commons.dbcp2.datasources.PooledConnectionManager.setPassword(char[]) add a524ea54 Next release will be labeled 2.14.0 add 1afdbf79 Bump org.apache.commons:commons-parent from 81 to 84 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (79836c54) \ N -- N -- N refs/heads/dependabot/maven/org.apache.commons-commons-parent-84 (1afdbf79) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .github/workflows/codeql-analysis.yml | 6 +- .github/workflows/scorecards-analysis.yml | 2 +- pom.xml | 8 +-- src/changes/changes.xml | 34 +++++++++ .../apache/commons/dbcp2/DelegatingConnection.java | 3 +- .../apache/commons/dbcp2/DelegatingStatement.java | 2 +- .../apache/commons/dbcp2/PoolableConnection.java | 13 ++-- .../commons/dbcp2/PoolableConnectionFactory.java | 16 ++--- .../apache/commons/dbcp2/PoolingConnection.java | 2 +- .../dbcp2/cpdsadapter/DriverAdapterCPDS.java | 10 +-- .../dbcp2/cpdsadapter/PooledConnectionImpl.java | 2 +- .../dbcp2/datasources/CPDSConnectionFactory.java | 1 + .../commons/dbcp2/datasources/CharArray.java | 24 +++++-- .../dbcp2/datasources/InstanceKeyDataSource.java | 34 ++++----- .../datasources/KeyedCPDSConnectionFactory.java | 8 +++ .../dbcp2/datasources/PooledConnectionManager.java | 29 ++++---- .../dbcp2/datasources/SharedPoolDataSource.java | 2 +- .../commons/dbcp2/datasources/UserPassKey.java | 11 +++ .../commons/dbcp2/managed/ManagedConnection.java | 24 ++----- .../commons/dbcp2/datasources/CharArrayTest.java | 8 +++ .../datasources/PooledConnectionManagerTest.java | 70 ++++++++++++++++++ .../datasources/TestCPDSConnectionFactory.java | 10 ++- .../datasources/TestPerUserPoolDataSource.java | 83 +++++++++++++--------- .../UserPassKeyTest.java} | 34 +++++---- 24 files changed, 295 insertions(+), 141 deletions(-) create mode 100644 src/test/java/org/apache/commons/dbcp2/datasources/PooledConnectionManagerTest.java copy src/test/java/org/apache/commons/dbcp2/{TestListException.java => datasources/UserPassKeyTest.java} (51%)