This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
from 5ed30e25 Fix SpotBugs [ERROR] Medium: Shared primitive variable
"closed" in one thread may not yield the value of the most recent write from
another thread [org.apache.commons.dbcp2.cpdsadapter.PooledConnectionImpl]
AT_STALE_THREAD_WRITE_OF_PRIMITIVE
new 3af43c9f Fix SpotBugs [ERROR] Medium: Shared primitive variable
"closed" in one thread may not yield the value of the most recent write from
another thread [org.apache.commons.dbcp2.DelegatingStatement]
AT_STALE_THREAD_WRITE_OF_PRIMITIVE
new 8a4bfcdd Fix SpotBugs [ERROR] Medium: Shared primitive variable
"cacheState" in one thread may not yield the value of the most recent write
from another thread [org.apache.commons.dbcp2.DelegatingConnection]
AT_STALE_THREAD_WRITE_OF_PRIMITIVE
new ea6dba61 Fix SpotBugs [ERROR] Medium: Operation on the
"fatalSqlExceptionThrown" shared variable in "PoolableConnection" class is not
atomic [org.apache.commons.dbcp2.PoolableConnection]
AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE
new 83d9341e Javadoc
new e57fcdb3 Fix SpotBugs [ERROR] Medium: Shared primitive variable
"clearStatementPoolOnReturn" in one thread may not yield the value of the most
recent write from another thread [org.apache.commons.dbcp2.PoolingConnection]
AT_STALE_THREAD_WRITE_OF_PRIMITIVE
new 6f6c12e4 Fix SpotBugs [ERROR] Medium: Shared primitive variable
"maxTotal" in one thread may not yield the value of the most recent write from
another thread [org.apache.commons.dbcp2.datasources.SharedPoolDataSource]
AT_STALE_THREAD_WRITE_OF_PRIMITIVE
new 2f1b9d9e Fix SpotBugs [ERROR] Medium: Shared primitive variables in
one thread may not yield the value of the most recent write from another thread
[org.apache.commons.dbcp2.datasources.InstanceKeyDataSource]
AT_STALE_THREAD_WRITE_OF_PRIMITIVE
new d2761e44 Javadoc
new bffe9100 Fix SpotBugs [ERROR] Medium: Shared primitive variables in
one thread may not yield the value of the most recent write from another thread
[org.apache.commons.dbcp2.cpdsadapter.DriverAdapterCPDS]
AT_STALE_THREAD_WRITE_OF_PRIMITIVE
new 44a4b74b Fix SpotBugs [ERROR] Medium: Shared primitive variables in
one thread may not yield the value of the most recent write from another thread
[org.apache.commons.dbcp2.PoolableConnectionFactory]
AT_STALE_THREAD_WRITE_OF_PRIMITIVE
new 7ccaa5ab Add internal
org.apache.commons.dbcp2.datasources.CharArray.clear()
new 53462102 Add internal
org.apache.commons.dbcp2.datasources.UserPassKey.clear()
new dc2c59ac Add
org.apache.commons.dbcp2.datasources.PooledConnectionManager.setPassword(char[])
The 13 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
src/changes/changes.xml | 32 ++++++++++
.../apache/commons/dbcp2/DelegatingConnection.java | 3 +-
.../apache/commons/dbcp2/DelegatingStatement.java | 2 +-
.../apache/commons/dbcp2/PoolableConnection.java | 13 ++--
.../commons/dbcp2/PoolableConnectionFactory.java | 16 ++---
.../apache/commons/dbcp2/PoolingConnection.java | 2 +-
.../dbcp2/cpdsadapter/DriverAdapterCPDS.java | 10 ++--
.../dbcp2/datasources/CPDSConnectionFactory.java | 1 +
.../commons/dbcp2/datasources/CharArray.java | 24 +++++---
.../dbcp2/datasources/InstanceKeyDataSource.java | 26 ++++----
.../datasources/KeyedCPDSConnectionFactory.java | 8 +++
.../dbcp2/datasources/PooledConnectionManager.java | 29 ++++-----
.../dbcp2/datasources/SharedPoolDataSource.java | 2 +-
.../commons/dbcp2/datasources/UserPassKey.java | 11 ++++
.../commons/dbcp2/datasources/CharArrayTest.java | 8 +++
.../datasources/PooledConnectionManagerTest.java | 70 ++++++++++++++++++++++
.../datasources/TestCPDSConnectionFactory.java | 10 +++-
.../UserPassKeyTest.java} | 34 +++++------
18 files changed, 225 insertions(+), 76 deletions(-)
create mode 100644
src/test/java/org/apache/commons/dbcp2/datasources/PooledConnectionManagerTest.java
copy src/test/java/org/apache/commons/dbcp2/{TestListException.java =>
datasources/UserPassKeyTest.java} (51%)
