This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-exec.git
commit 353f8facfaae82c98e98dcbcb5be5eb685a4d4a9
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Sat May 24 09:46:27 2025 -0400
Test packages can't have info files since they are already in main
Don't use TODO to raise Checkstyle issues
---
pom.xml | 1 +
src/conf/checkstyle-suppressions.xml | 24 ++++++++++++++++++++++
src/conf/checkstyle.xml | 2 --
.../org/apache/commons/exec/issues/Exec65Test.java | 2 +-
4 files changed, 26 insertions(+), 3 deletions(-)
diff --git a/pom.xml b/pom.xml
index c6fe3d86..b58e702a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -102,6 +102,7 @@ limitations under the License.
<configLocation>${basedir}/src/conf/checkstyle.xml</configLocation>
<enableRulesSummary>false</enableRulesSummary>
<includeTestSourceDirectory>true</includeTestSourceDirectory>
+
<suppressionsLocation>${basedir}/src/conf/checkstyle-suppressions.xml</suppressionsLocation>
<consoleOutput>true</consoleOutput>
</configuration>
</plugin>
diff --git a/src/conf/checkstyle-suppressions.xml
b/src/conf/checkstyle-suppressions.xml
new file mode 100644
index 00000000..9701a56c
--- /dev/null
+++ b/src/conf/checkstyle-suppressions.xml
@@ -0,0 +1,24 @@
+<?xml version="1.0"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ https://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+<!DOCTYPE suppressions PUBLIC
+ "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+ "https://checkstyle.org/dtds/suppressions_1_2.dtd";>
+<!-- SEE: http://checkstyle.sourceforge.net/config.html#Examples -->
+<suppressions>
+ <suppress checks="JavadocPackage" files="src[/\\]test[/\\]java[/\\]" />
+</suppressions>
diff --git a/src/conf/checkstyle.xml b/src/conf/checkstyle.xml
index 7bab93bb..65bf5e5b 100644
--- a/src/conf/checkstyle.xml
+++ b/src/conf/checkstyle.xml
@@ -141,7 +141,6 @@
<module name="SuperClone" />
<module name="SuperFinalize" />
<module name="IllegalType" />
- <module name="DeclarationOrder" />
<module name="ExplicitInitialization" />
<module name="DefaultComesLast" />
<module name="FallThrough" />
@@ -159,7 +158,6 @@
<!-- Miscellaneous other checks. -->
<!-- See https://checkstyle.sf.net/config_misc.html -->
<module name="ArrayTypeStyle" />
- <module name="TodoComment" />
<module name="UpperEll" />
<module name="TypecastParenPad" />
</module>
diff --git a/src/test/java/org/apache/commons/exec/issues/Exec65Test.java
b/src/test/java/org/apache/commons/exec/issues/Exec65Test.java
index ac4be48a..b576ac69 100644
--- a/src/test/java/org/apache/commons/exec/issues/Exec65Test.java
+++ b/src/test/java/org/apache/commons/exec/issues/Exec65Test.java
@@ -92,7 +92,7 @@ public class Exec65Test extends AbstractExecTest {
public void testExec65WithSudoUsingShellScript() throws Exception {
assumeFalse(new File(".").getAbsolutePath().contains("travis"),
"Test is skipped on travis, because we have to be a sudoer to
make the other tests pass.");
- // TODO Fails on GitHub
+ // TODO: Fails on GitHub
assumeTrue(System.getenv("GITHUB_WORKFLOW") == null);
final DefaultExecutor executor = DefaultExecutor.builder().get();
