This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
commit bc321099cd30efa7c55859b6b3a3a70b19921d05
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Sun May 18 18:22:02 2025 -0400
Fix SpotBugs AT_STALE_THREAD_WRITE_OF_PRIMITIVE in BoundedInputStream
- Note that BoundedInputStream.setPropagateClose(boolean) is deprecated
- [ERROR] Medium: Shared primitive variable "propagateClose" in one
thread may not yield the value of the most recent write from another
thread [org.apache.commons.io.input.BoundedInputStream] At
BoundedInputStream.java:[line 555] AT_STALE_THREAD_WRITE_OF_PRIMITIVE
---
src/changes/changes.xml | 1 +
src/main/java/org/apache/commons/io/input/BoundedInputStream.java | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index cf788651b..b3fd11585 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -65,6 +65,7 @@ The <action> type attribute can be add,update,fix,remove.
<action dev="ggregory" type="fix" due-to="Gary
Gregory">Fix SpotBugs [ERROR] Medium: Shared primitive variable "atSlashCr" in
one thread may not yield the value of the most recent write from another thread
[org.apache.commons.io.input.UnixLineEndingInputStream] At
UnixLineEndingInputStream.java:[line 124]
AT_STALE_THREAD_WRITE_OF_PRIMITIVE.</action>
<action dev="ggregory" type="fix" due-to="Gary
Gregory">Fix SpotBugs [ERROR] Medium: Shared primitive variable "atSlashLf" in
one thread may not yield the value of the most recent write from another thread
[org.apache.commons.io.input.UnixLineEndingInputStream] At
UnixLineEndingInputStream.java:[line 125]
AT_STALE_THREAD_WRITE_OF_PRIMITIVE.</action>
<action dev="ggregory" type="fix" due-to="Gary
Gregory">Fix SpotBugs [ERROR] Medium: Shared primitive variable "closed" in one
thread may not yield the value of the most recent write from another thread
[org.apache.commons.io.input.ProxyInputStream] At ProxyInputStream.java:[line
233] AT_STALE_THREAD_WRITE_OF_PRIMITIVE.</action>
+ <action dev="ggregory" type="fix" due-to="Gary
Gregory">Fix SpotBugs [ERROR] Medium: Shared primitive variable
"propagateClose" in one thread may not yield the value of the most recent write
from another thread [org.apache.commons.io.input.BoundedInputStream] At
BoundedInputStream.java:[line 555] AT_STALE_THREAD_WRITE_OF_PRIMITIVE.</action>
<!-- ADD -->
<action dev="ggregory" type="add" issue="IO-875" due-to="Pierre Baumard,
Gary Gregory">Add and use
org.apache.commons.io.file.CountingPathVisitor.accept(Path,
BasicFileAttributes) #743.</action>
<!-- UPDATE -->
diff --git a/src/main/java/org/apache/commons/io/input/BoundedInputStream.java
b/src/main/java/org/apache/commons/io/input/BoundedInputStream.java
index 14fed6048..3c2f59b95 100644
--- a/src/main/java/org/apache/commons/io/input/BoundedInputStream.java
+++ b/src/main/java/org/apache/commons/io/input/BoundedInputStream.java
@@ -551,7 +551,7 @@ public synchronized void reset() throws IOException {
* @deprecated Use {@link AbstractBuilder#setPropagateClose(boolean)}.
*/
@Deprecated
- public void setPropagateClose(final boolean propagateClose) {
+ public synchronized void setPropagateClose(final boolean propagateClose) {
this.propagateClose = propagateClose;
}
