This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-rdf.git
commit bfd4835c85595fee8a182f77ab61ac7b0237069d Author: Gary D. Gregory <garydgreg...@gmail.com> AuthorDate: Sat May 17 08:32:40 2025 -0400 Add missing test coverage in org.apache.commons.rdf.api.RDFSyntaxTest --- commons-rdf-api/pom.xml | 7 +++++++ .../org/apache/commons/rdf/api/RDFSyntaxTest.java | 24 ++++++++++++++++++++++ 2 files changed, 31 insertions(+) diff --git a/commons-rdf-api/pom.xml b/commons-rdf-api/pom.xml index c90e5eeb..852a5db3 100644 --- a/commons-rdf-api/pom.xml +++ b/commons-rdf-api/pom.xml @@ -43,6 +43,13 @@ <commons.jacoco.lineRatio>0.76</commons.jacoco.lineRatio> <commons.jacoco.complexityRatio>0.66</commons.jacoco.complexityRatio> </properties> + <dependencies> + <dependency> + <groupId>org.junit-pioneer</groupId> + <artifactId>junit-pioneer</artifactId> + <scope>test</scope> + </dependency> + </dependencies> <build> <plugins> <plugin> diff --git a/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/RDFSyntaxTest.java b/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/RDFSyntaxTest.java index 2242ace0..b69f2049 100644 --- a/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/RDFSyntaxTest.java +++ b/commons-rdf-api/src/test/java/org/apache/commons/rdf/api/RDFSyntaxTest.java @@ -18,14 +18,24 @@ package org.apache.commons.rdf.api; import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertTrue; import java.util.Optional; import org.junit.jupiter.api.Test; +import org.junitpioneer.jupiter.cartesian.ArgumentSets; +import org.junitpioneer.jupiter.cartesian.CartesianTest; public class RDFSyntaxTest { + static ArgumentSets providerRDFSyntax() { + return ArgumentSets + .argumentsForFirstParameter(RDFSyntax.w3cSyntaxes()) + .argumentsForNextParameter(RDFSyntax.w3cSyntaxes()); + } + @Test public void testByFileExtension() throws Exception { assertEquals(RDFSyntax.JSONLD, RDFSyntax.byFileExtension(".jsonld").get()); @@ -91,6 +101,20 @@ public class RDFSyntaxTest { } } + @CartesianTest + @CartesianTest.MethodFactory("providerRDFSyntax") + void testEqualsAndHashCode(final RDFSyntax left, final RDFSyntax right) { + assertNotNull(left); + assertNotNull(right); + if (left == right) { + assertEquals(left, right); + assertEquals(left.hashCode(), right.hashCode()); + } else { + assertNotEquals(left, right); + assertNotEquals(left.hashCode(), right.hashCode()); + } + } + @Test public void testFileExtension() throws Exception { assertEquals(".jsonld", RDFSyntax.JSONLD.fileExtension());