This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch 1.x in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git
commit 561d9e8acba34451b6478d0f71674fbcd46b1f03 Author: Gary D. Gregory <garydgreg...@gmail.com> AuthorDate: Sun May 4 14:35:43 2025 -0400 Reuse StandardCharsets.ISO_8859_1 --- .../java/org/apache/commons/fileupload/FileUploadBase.java | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/main/java/org/apache/commons/fileupload/FileUploadBase.java b/src/main/java/org/apache/commons/fileupload/FileUploadBase.java index d82ad7b5..ec272051 100644 --- a/src/main/java/org/apache/commons/fileupload/FileUploadBase.java +++ b/src/main/java/org/apache/commons/fileupload/FileUploadBase.java @@ -20,7 +20,7 @@ import static java.lang.String.format; import java.io.IOException; import java.io.InputStream; -import java.io.UnsupportedEncodingException; +import java.nio.charset.StandardCharsets; import java.util.ArrayList; import java.util.HashMap; import java.util.Iterator; @@ -974,19 +974,12 @@ public abstract class FileUploadBase { final ParameterParser parser = new ParameterParser(); parser.setLowerCaseNames(true); // Parameter parser can handle null input - final Map<String, String> params = parser.parse(contentType, new char[] {';', ','}); + final Map<String, String> params = parser.parse(contentType, new char[] { ';', ',' }); final String boundaryStr = params.get("boundary"); - if (boundaryStr == null) { return null; } - byte[] boundary; - try { - boundary = boundaryStr.getBytes("ISO-8859-1"); - } catch (final UnsupportedEncodingException e) { - boundary = boundaryStr.getBytes(); // Intentionally falls back to default charset - } - return boundary; + return boundaryStr.getBytes(StandardCharsets.ISO_8859_1); } /**