This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-vfs.git
commit b52d926fccbd933f6b02fb1f937615274b05d983 Author: Gary D. Gregory <garydgreg...@gmail.com> AuthorDate: Sat May 3 15:22:43 2025 -0400 Better exception message --- .../java/org/apache/commons/vfs2/provider/http4/Http4FileSystem.java | 4 +--- .../java/org/apache/commons/vfs2/provider/http5/Http5FileSystem.java | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http4/Http4FileSystem.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http4/Http4FileSystem.java index b18da8c3b..a4e8b08fb 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http4/Http4FileSystem.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http4/Http4FileSystem.java @@ -90,9 +90,7 @@ public class Http4FileSystem extends AbstractFileSystem { @Override protected void doCloseCommunicationLink() { if (httpClient instanceof Closeable) { - // TODO "Error closing HttpClient" Commons IO - // Uncheck.run(() -> ((Closeable) httpClient).close(), () -> "Error closing HttpClient"); - Uncheck.run(() -> ((Closeable) httpClient).close()); + Uncheck.run(() -> ((Closeable) httpClient).close(), () -> "Error closing HttpClient"); } } diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http5/Http5FileSystem.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http5/Http5FileSystem.java index accfa3761..a710c84db 100644 --- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http5/Http5FileSystem.java +++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/http5/Http5FileSystem.java @@ -88,9 +88,7 @@ public class Http5FileSystem extends AbstractFileSystem { @Override protected void doCloseCommunicationLink() { if (httpClient instanceof Closeable) { - // TODO "Error closing HttpClient" Commons IO - // Uncheck.run(() -> ((Closeable) httpClient).close(), () -> "Error closing HttpClient"); - Uncheck.run(() -> ((Closeable) httpClient).close()); + Uncheck.run(() -> ((Closeable) httpClient).close(), () -> "Error closing HttpClient"); } }