This is an automated email from the ASF dual-hosted git repository. ggregory pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-imaging.git
from 6e5d80c6 Internal refactoring new 24bab44e Fix SpotBugs CT_CONSTRUCTOR_THROW new c1ba8734 Fix SpotBugs CT_CONSTRUCTOR_THROW new faef3de2 Rename abstract classes to Abstract* The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/changes/changes.xml | 1 + src/conf/spotbugs-exclude-filter.xml | 2 +- ...Stream.java => AbstractBinaryOutputStream.java} | 6 +-- .../common/BigEndianBinaryOutputStream.java | 2 +- .../commons/imaging/common/ImageBuilder.java | 2 +- .../common/LittleEndianBinaryOutputStream.java | 2 +- .../imaging/formats/bmp/BmpImageParser.java | 4 +- .../commons/imaging/formats/bmp/BmpWriter.java | 4 +- .../imaging/formats/bmp/BmpWriterPalette.java | 4 +- .../commons/imaging/formats/bmp/BmpWriterRgb.java | 4 +- .../imaging/formats/dcx/DcxImageParser.java | 4 +- .../imaging/formats/gif/GifImageParser.java | 4 +- .../imaging/formats/icns/IcnsImageParser.java | 4 +- .../imaging/formats/ico/IcoImageParser.java | 6 +-- .../imaging/formats/jpeg/JpegImageParser.java | 8 ++-- .../imaging/formats/jpeg/iptc/IptcParser.java | 6 +-- ...ricSegment.java => AbstractGenericSegment.java} | 8 ++-- .../imaging/formats/jpeg/segments/App2Segment.java | 2 +- .../imaging/formats/jpeg/segments/AppnSegment.java | 2 +- .../imaging/formats/jpeg/segments/ComSegment.java | 2 +- .../imaging/formats/jpeg/segments/DhtSegment.java | 2 +- .../imaging/formats/jpeg/segments/DqtSegment.java | 2 +- .../imaging/formats/jpeg/segments/JfifSegment.java | 2 +- .../imaging/formats/jpeg/segments/SofnSegment.java | 2 +- .../imaging/formats/jpeg/segments/SosSegment.java | 2 +- .../formats/jpeg/segments/UnknownSegment.java | 2 +- .../commons/imaging/formats/pcx/PcxWriter.java | 8 ++-- .../commons/imaging/formats/pcx/RleWriter.java | 6 +-- .../imaging/formats/png/chunks/PngChunkGama.java | 2 +- .../imaging/formats/png/chunks/PngChunkIccp.java | 2 +- .../imaging/formats/png/chunks/PngChunkIhdr.java | 2 +- .../imaging/formats/png/chunks/PngChunkItxt.java | 2 +- .../imaging/formats/png/chunks/PngChunkPhys.java | 2 +- .../imaging/formats/png/chunks/PngChunkPlte.java | 2 +- .../imaging/formats/png/chunks/PngChunkScal.java | 2 +- .../imaging/formats/png/chunks/PngChunkText.java | 2 +- .../imaging/formats/png/chunks/PngChunkZtxt.java | 2 +- .../TransparencyFilterGrayscale.java | 2 +- .../TransparencyFilterTrueColor.java | 2 +- .../imaging/formats/psd/PsdImageParser.java | 4 +- .../{DataParser.java => AbstractDataParser.java} | 2 +- .../formats/psd/dataparsers/DataParserBitmap.java | 2 +- .../formats/psd/dataparsers/DataParserCmyk.java | 2 +- .../psd/dataparsers/DataParserGrayscale.java | 2 +- .../formats/psd/dataparsers/DataParserIndexed.java | 2 +- .../formats/psd/dataparsers/DataParserLab.java | 2 +- .../formats/psd/dataparsers/DataParserRgb.java | 2 +- .../formats/psd/dataparsers/DataParserStub.java | 2 +- .../psd/datareaders/CompressedDataReader.java | 6 +-- .../psd/datareaders/UncompressedDataReader.java | 6 +-- .../formats/tiff/AbstractTiffImageData.java | 22 +++++----- ...RasterData.java => AbstractTiffRasterData.java} | 4 +- .../imaging/formats/tiff/TiffDirectory.java | 2 +- .../imaging/formats/tiff/TiffImageParser.java | 51 +++++----------------- .../formats/tiff/TiffImagingParameters.java | 8 ++-- .../imaging/formats/tiff/TiffRasterDataFloat.java | 2 +- .../imaging/formats/tiff/TiffRasterDataInt.java | 2 +- .../imaging/formats/tiff/TiffRasterStatistics.java | 2 +- ...ataReader.java => AbstractImageDataReader.java} | 16 +++---- .../formats/tiff/datareaders/DataReaderStrips.java | 16 +++---- .../formats/tiff/datareaders/DataReaderTiled.java | 21 ++++----- ...er.java => AbstractPhotometricInterpreter.java} | 4 +- .../PhotometricInterpreterBiLevel.java | 2 +- .../PhotometricInterpreterCieLab.java | 2 +- .../PhotometricInterpreterCmyk.java | 2 +- .../PhotometricInterpreterLogLuv.java | 2 +- .../PhotometricInterpreterPalette.java | 2 +- .../PhotometricInterpreterRgb.java | 2 +- .../PhotometricInterpreterYCbCr.java | 2 +- .../floatingpoint/PaletteEntryForRange.java | 2 +- .../floatingpoint/PaletteEntryForValue.java | 2 +- .../floatingpoint/PhotometricInterpreterFloat.java | 4 +- .../tiff/write/AbstractTiffImageWriter.java | 6 +-- .../formats/tiff/write/AbstractTiffOutputItem.java | 6 +-- .../tiff/write/TiffImageWriterLossless.java | 6 +-- .../formats/tiff/write/TiffImageWriterLossy.java | 6 +-- .../formats/tiff/write/TiffOutputDirectory.java | 4 +- .../formats/tiff/write/TiffOutputField.java | 4 +- .../imaging/formats/webp/WebPChunkType.java | 6 +-- .../imaging/formats/webp/WebPImageParser.java | 16 +++---- .../{WebPChunk.java => AbstractWebPChunk.java} | 39 +++++++++-------- .../imaging/formats/webp/chunks/WebPChunkAlph.java | 2 +- .../imaging/formats/webp/chunks/WebPChunkAnim.java | 2 +- .../imaging/formats/webp/chunks/WebPChunkAnmf.java | 2 +- .../imaging/formats/webp/chunks/WebPChunkExif.java | 2 +- .../imaging/formats/webp/chunks/WebPChunkIccp.java | 2 +- .../imaging/formats/webp/chunks/WebPChunkVp8.java | 2 +- .../imaging/formats/webp/chunks/WebPChunkVp8l.java | 2 +- .../imaging/formats/webp/chunks/WebPChunkVp8x.java | 2 +- .../imaging/formats/webp/chunks/WebPChunkXml.java | 2 +- .../imaging/formats/webp/chunks/WebPChunkXyzw.java | 2 +- .../tiff/ExampleReadFloatingPointData.java | 4 +- .../{IcnsBaseTest.java => AbstractIcnsTest.java} | 4 +- .../commons/imaging/formats/icns/IcnsReadTest.java | 2 +- .../imaging/formats/icns/IcnsRoundTripTest.java | 20 ++++----- .../imaging/formats/ico/IcoRoundtripTest.java | 39 ++++++++--------- .../{JpegBaseTest.java => AbstractJpegTest.java} | 4 +- .../commons/imaging/formats/jpeg/JpegReadTest.java | 2 +- .../{IptcBaseTest.java => AbstractIptcTest.java} | 4 +- .../imaging/formats/jpeg/iptc/IptcAddTest.java | 2 +- .../imaging/formats/jpeg/iptc/IptcDumpTest.java | 2 +- .../imaging/formats/jpeg/iptc/IptcParserTest.java | 6 +-- .../imaging/formats/jpeg/iptc/IptcUpdateTest.java | 2 +- .../{RgbeBaseTest.java => AbstractRgbeTest.java} | 4 +- .../commons/imaging/formats/rgbe/RgbeReadTest.java | 2 +- .../{TiffBaseTest.java => AbstractTiffTest.java} | 4 +- .../imaging/formats/tiff/TiffBigTiffTest.java | 2 +- .../imaging/formats/tiff/TiffCcittTest.java | 2 +- .../tiff/TiffFloatingPointMultivariableTest.java | 4 +- .../formats/tiff/TiffFloatingPointReadTest.java | 8 ++-- .../tiff/TiffFloatingPointRoundTripTest.java | 2 +- .../commons/imaging/formats/tiff/TiffJpegTest.java | 2 +- .../commons/imaging/formats/tiff/TiffLzwTest.java | 2 +- .../formats/tiff/TiffRasterDataIntTest.java | 10 ++--- .../imaging/formats/tiff/TiffRasterDataTest.java | 8 ++-- .../formats/tiff/TiffRasterStatisticsTest.java | 4 +- .../formats/tiff/TiffReadImageInfoTest.java | 2 +- .../commons/imaging/formats/tiff/TiffReadTest.java | 2 +- .../formats/tiff/TiffReadWriteTagsTest.java | 2 +- .../formats/tiff/TiffRoundTripInt32Test.java | 6 +-- .../imaging/formats/tiff/TiffRoundtripTest.java | 2 +- .../formats/tiff/TiffShortIntRoundTripTest.java | 6 +-- .../imaging/formats/tiff/TiffSubImageTest.java | 2 +- .../{WbmpBaseTest.java => AbstractWbmpTest.java} | 4 +- .../commons/imaging/formats/wbmp/WbmpReadTest.java | 2 +- .../{WebPBaseTest.java => AbstractWebPTest.java} | 4 +- .../commons/imaging/formats/webp/WebPDumpTest.java | 2 +- .../imaging/formats/webp/WebPMetadataTest.java | 2 +- .../commons/imaging/formats/webp/WebPReadTest.java | 2 +- .../xbm/{XbmBaseTest.java => AbstractXbmTest.java} | 4 +- .../commons/imaging/formats/xbm/XbmReadTest.java | 2 +- 131 files changed, 303 insertions(+), 328 deletions(-) rename src/main/java/org/apache/commons/imaging/common/{BinaryOutputStream.java => AbstractBinaryOutputStream.java} (88%) rename src/main/java/org/apache/commons/imaging/formats/jpeg/segments/{GenericSegment.java => AbstractGenericSegment.java} (88%) rename src/main/java/org/apache/commons/imaging/formats/psd/dataparsers/{DataParser.java => AbstractDataParser.java} (97%) rename src/main/java/org/apache/commons/imaging/formats/tiff/{TiffRasterData.java => AbstractTiffRasterData.java} (98%) rename src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/{ImageDataReader.java => AbstractImageDataReader.java} (98%) rename src/main/java/org/apache/commons/imaging/formats/tiff/photometricinterpreters/{PhotometricInterpreter.java => AbstractPhotometricInterpreter.java} (90%) rename src/main/java/org/apache/commons/imaging/formats/webp/chunks/{WebPChunk.java => AbstractWebPChunk.java} (87%) rename src/test/java/org/apache/commons/imaging/formats/icns/{IcnsBaseTest.java => AbstractIcnsTest.java} (91%) rename src/test/java/org/apache/commons/imaging/formats/jpeg/{JpegBaseTest.java => AbstractJpegTest.java} (91%) rename src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/{IptcBaseTest.java => AbstractIptcTest.java} (94%) rename src/test/java/org/apache/commons/imaging/formats/rgbe/{RgbeBaseTest.java => AbstractRgbeTest.java} (91%) rename src/test/java/org/apache/commons/imaging/formats/tiff/{TiffBaseTest.java => AbstractTiffTest.java} (91%) rename src/test/java/org/apache/commons/imaging/formats/wbmp/{WbmpBaseTest.java => AbstractWbmpTest.java} (88%) rename src/test/java/org/apache/commons/imaging/formats/webp/{WebPBaseTest.java => AbstractWebPTest.java} (93%) rename src/test/java/org/apache/commons/imaging/formats/xbm/{XbmBaseTest.java => AbstractXbmTest.java} (88%)