This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-imaging.git

commit edb419d2e655127d59c943628bb5613b993d300a
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Apr 26 08:18:53 2025 -0400

    Fix PMD CollapsibleIfStatements
---
 src/main/java/org/apache/commons/imaging/AbstractImageParser.java | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/commons/imaging/AbstractImageParser.java 
b/src/main/java/org/apache/commons/imaging/AbstractImageParser.java
index a76fdbe1..24d05f1d 100644
--- a/src/main/java/org/apache/commons/imaging/AbstractImageParser.java
+++ b/src/main/java/org/apache/commons/imaging/AbstractImageParser.java
@@ -137,10 +137,8 @@ public abstract class AbstractImageParser<T extends 
ImagingParameters<T>> extend
             return true;
         }
         final int index = fileName.lastIndexOf('.');
-        if (index >= 0) {
-            if (ArrayUtils.contains(extensions, fileName.substring(index + 
1).toLowerCase(Locale.ROOT))) {
-                return true;
-            }
+        if (index >= 0 && ArrayUtils.contains(extensions, 
fileName.substring(index + 1).toLowerCase(Locale.ROOT))) {
+            return true;
         }
         return false;
     }

Reply via email to