(commons-jxpath) 04/04: Fix PMD AvoidDecimalLiteralsInBigDecimalConstructor in org.apache.commons.jxpath.util.BasicTypeConverter.allocateNumber(Class, double)

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-jxpath.git

commit ced1bc444f34aefc3b05ab53d6aeeb0f73ae706b
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Apr 12 09:42:23 2025 -0400

    Fix PMD AvoidDecimalLiteralsInBigDecimalConstructor in
    org.apache.commons.jxpath.util.BasicTypeConverter.allocateNumber(Class,
    double)
---
 src/changes/changes.xml                                              | 1 +
 src/main/java/org/apache/commons/jxpath/util/BasicTypeConverter.java | 3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 25a6185..0ab0a20 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -134,6 +134,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action dev="ggregory" type="fix" due-to="Gary Gregory">Make the private 
JDOMNodePointer.id field final.</action>
       <action dev="ggregory" type="fix" due-to="Gary 
Gregory">ExpressionContext.getContextNodeList() now uses generics.</action>
       <action dev="ggregory" type="fix" due-to="Gary 
Gregory">BasicTypeConverter.unmodifiableCollection(Collection) now uses 
generics.</action>
+      <action dev="ggregory" type="fix" due-to="Gary Gregory. PMD">Fix PMD 
AvoidDecimalLiteralsInBigDecimalConstructor in 
org.apache.commons.jxpath.util.BasicTypeConverter.allocateNumber(Class, 
double).</action>
       <!-- ADD -->
       <action issue="JXPATH-123" dev="mbenson" type="add">
         XPath function "ends-with" is not implemented (although "starts-with" 
is).
diff --git 
a/src/main/java/org/apache/commons/jxpath/util/BasicTypeConverter.java 
b/src/main/java/org/apache/commons/jxpath/util/BasicTypeConverter.java
index 63bdd8b..f4bfe20 100644
--- a/src/main/java/org/apache/commons/jxpath/util/BasicTypeConverter.java
+++ b/src/main/java/org/apache/commons/jxpath/util/BasicTypeConverter.java
@@ -173,8 +173,7 @@ public class BasicTypeConverter implements TypeConverter {
             return BigInteger.valueOf((long) value);
         }
         if (type == BigDecimal.class) {
-            // TODO ? 
https://pmd.sourceforge.io/pmd-6.50.0/pmd_rules_java_errorprone.html#avoiddecimalliteralsinbigdecimalconstructor
-            return new BigDecimal(value); // NOPMD
+            return new BigDecimal(Double.toString(value));
         }
         final String className = type.getName();
         Class initialValueType = null;