(commons-io) 02/03: Remove duplication in test fixtures

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git

commit 709e8cd8814d403a4ce47bc248f53f52986b4976
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Mar 30 15:12:06 2025 -0400

    Remove duplication in test fixtures
---
 .../commons/io/file/attribute/FileTimesTest.java   | 28 +++-------------------
 1 file changed, 3 insertions(+), 25 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/io/file/attribute/FileTimesTest.java 
b/src/test/java/org/apache/commons/io/file/attribute/FileTimesTest.java
index 4bee2451a..afd7f7126 100644
--- a/src/test/java/org/apache/commons/io/file/attribute/FileTimesTest.java
+++ b/src/test/java/org/apache/commons/io/file/attribute/FileTimesTest.java
@@ -37,28 +37,6 @@
  */
 public class FileTimesTest {
 
-    public static Stream<Arguments> dateToNtfsProvider() {
-        // @formatter:off
-        return Stream.of(
-            Arguments.of("1601-01-01T00:00:00.000Z", 0),
-            Arguments.of("1601-01-01T00:00:00.000Z", 1),
-            Arguments.of("1600-12-31T23:59:59.999Z", -1),
-            Arguments.of("+30828-09-14T02:48:05.477580700Z", Long.MAX_VALUE),
-            Arguments.of("-27627-04-19T21:11:54.522419200Z", Long.MIN_VALUE),
-            Arguments.of("1601-01-01T00:00:00.001Z", 
FileTimes.HUNDRED_NANOS_PER_MILLISECOND),
-            Arguments.of("1601-01-01T00:00:00.001Z", 
FileTimes.HUNDRED_NANOS_PER_MILLISECOND + 1),
-            Arguments.of("1601-01-01T00:00:00.000Z", 
FileTimes.HUNDRED_NANOS_PER_MILLISECOND - 1),
-            Arguments.of("1600-12-31T23:59:59.999Z", 
-FileTimes.HUNDRED_NANOS_PER_MILLISECOND),
-            Arguments.of("1600-12-31T23:59:59.999Z", 
-FileTimes.HUNDRED_NANOS_PER_MILLISECOND + 1),
-            Arguments.of("1600-12-31T23:59:59.998Z", 
-FileTimes.HUNDRED_NANOS_PER_MILLISECOND - 1),
-            Arguments.of("1970-01-01T00:00:00.000Z", 
-FileTimes.UNIX_TO_NTFS_OFFSET),
-            Arguments.of("1970-01-01T00:00:00.000Z", 
-FileTimes.UNIX_TO_NTFS_OFFSET + 1),
-            Arguments.of("1970-01-01T00:00:00.001Z", 
-FileTimes.UNIX_TO_NTFS_OFFSET + FileTimes.HUNDRED_NANOS_PER_MILLISECOND),
-            Arguments.of("1969-12-31T23:59:59.999Z", 
-FileTimes.UNIX_TO_NTFS_OFFSET - 1),
-            Arguments.of("1969-12-31T23:59:59.999Z", 
-FileTimes.UNIX_TO_NTFS_OFFSET - FileTimes.HUNDRED_NANOS_PER_MILLISECOND));
-        // @formatter:on
-    }
-
     public static Stream<Arguments> fileTimeNanoUnitsToNtfsProvider() {
         // @formatter:off
         return Stream.of(
@@ -103,7 +81,7 @@ public static Stream<Arguments> isUnixFileTimeProvider() {
     }
 
     @ParameterizedTest
-    @MethodSource("dateToNtfsProvider")
+    @MethodSource("fileTimeNanoUnitsToNtfsProvider")
     public void testDateToFileTime(final String instant, final long ignored) {
         final Instant parsedInstant = Instant.parse(instant);
         final FileTime parsedFileTime = FileTime.from(parsedInstant);
@@ -112,7 +90,7 @@ public void testDateToFileTime(final String instant, final 
long ignored) {
     }
 
     @ParameterizedTest
-    @MethodSource("dateToNtfsProvider")
+    @MethodSource("fileTimeNanoUnitsToNtfsProvider")
     public void testDateToNtfsTime(final String instant, final long ntfsTime) {
         final long ntfsMillis = Math.floorDiv(ntfsTime, 
FileTimes.HUNDRED_NANOS_PER_MILLISECOND) * 
FileTimes.HUNDRED_NANOS_PER_MILLISECOND;
         final Date parsed = Date.from(Instant.parse(instant));
@@ -152,7 +130,7 @@ public void testFileTimeToNtfsTime(final String instant, 
final long ntfsTime) {
     }
 
     @ParameterizedTest
-    @MethodSource("dateToNtfsProvider")
+    @MethodSource("fileTimeNanoUnitsToNtfsProvider")
     public void testFromUnixTime(final String instant, final long ntfsTime) {
         final long epochSecond = Instant.parse(instant).getEpochSecond();
         assertEquals(epochSecond, 
FileTimes.fromUnixTime(epochSecond).to(TimeUnit.SECONDS));