(commons-rng) 04/06: Sonar fix: use method reference

[aherbert]

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git

commit 283de5b9ac71a0805c60f9ecb63ada760b43859c
Author: Alex Herbert <aherb...@apache.org>
AuthorDate: Tue Mar 25 14:03:24 2025 +0000

    Sonar fix: use method reference
---
 .../src/test/java/org/apache/commons/rng/core/ProvidersList.java      | 4 ++--
 .../apache/commons/rng/core/source64/XoRoShiRo128PlusPlusTest.java    | 2 +-
 .../sampling/distribution/ZigguratNormalizedGaussianSamplerTest.java  | 3 +--
 .../org/apache/commons/rng/simple/ProvidersCommonParametricTest.java  | 2 +-
 .../rng/simple/internal/RandomSourceInternalParametricTest.java       | 2 +-
 5 files changed, 6 insertions(+), 7 deletions(-)

diff --git 
a/commons-rng-core/src/test/java/org/apache/commons/rng/core/ProvidersList.java 
b/commons-rng-core/src/test/java/org/apache/commons/rng/core/ProvidersList.java
index 312fdff9..04faee99 100644
--- 
a/commons-rng-core/src/test/java/org/apache/commons/rng/core/ProvidersList.java
+++ 
b/commons-rng-core/src/test/java/org/apache/commons/rng/core/ProvidersList.java
@@ -171,10 +171,10 @@ public final class ProvidersList {
             LIST.addAll(LIST64);
             // Dynamically identify the sub-type RNGs
             LIST.stream()
-                .filter(rng -> rng instanceof JumpableUniformRandomProvider)
+                .filter(JumpableUniformRandomProvider.class::isInstance)
                 .forEach(rng -> LIST_JUMP.add((JumpableUniformRandomProvider) 
rng));
             LIST.stream()
-                .filter(rng -> rng instanceof SplittableUniformRandomProvider)
+                .filter(SplittableUniformRandomProvider.class::isInstance)
                 .forEach(rng -> 
LIST_SPLIT.add((SplittableUniformRandomProvider) rng));
         } catch (final Exception e) {
             // CHECKSTYLE: stop Regexp
diff --git 
a/commons-rng-core/src/test/java/org/apache/commons/rng/core/source64/XoRoShiRo128PlusPlusTest.java
 
b/commons-rng-core/src/test/java/org/apache/commons/rng/core/source64/XoRoShiRo128PlusPlusTest.java
index ec4e05ea..c83ccff4 100644
--- 
a/commons-rng-core/src/test/java/org/apache/commons/rng/core/source64/XoRoShiRo128PlusPlusTest.java
+++ 
b/commons-rng-core/src/test/java/org/apache/commons/rng/core/source64/XoRoShiRo128PlusPlusTest.java
@@ -119,6 +119,6 @@ class XoRoShiRo128PlusPlusTest {
     @Test
     void testNextOutputThrows() {
         final XoRoShiRo128PlusPlus rng = new XoRoShiRo128PlusPlus(SEED);
-        Assertions.assertThrows(UnsupportedOperationException.class, () -> 
rng.nextOutput());
+        Assertions.assertThrows(UnsupportedOperationException.class, 
rng::nextOutput);
     }
 }
diff --git 
a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ZigguratNormalizedGaussianSamplerTest.java
 
b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ZigguratNormalizedGaussianSamplerTest.java
index f4e8b02c..c864fc41 100644
--- 
a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ZigguratNormalizedGaussianSamplerTest.java
+++ 
b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/ZigguratNormalizedGaussianSamplerTest.java
@@ -35,8 +35,7 @@ class ZigguratNormalizedGaussianSamplerTest {
 
         // Infinite loop (in v1.1).
         final ZigguratNormalizedGaussianSampler sampler = new 
ZigguratNormalizedGaussianSampler(bad);
-        Assertions.assertThrows(StackOverflowError.class,
-            () -> sampler.sample());
+        Assertions.assertThrows(StackOverflowError.class, sampler::sample);
     }
 
     /**
diff --git 
a/commons-rng-simple/src/test/java/org/apache/commons/rng/simple/ProvidersCommonParametricTest.java
 
b/commons-rng-simple/src/test/java/org/apache/commons/rng/simple/ProvidersCommonParametricTest.java
index 1d1dcaf5..85b2004d 100644
--- 
a/commons-rng-simple/src/test/java/org/apache/commons/rng/simple/ProvidersCommonParametricTest.java
+++ 
b/commons-rng-simple/src/test/java/org/apache/commons/rng/simple/ProvidersCommonParametricTest.java
@@ -119,7 +119,7 @@ class ProvidersCommonParametricTest {
         } else {
             // Try no arguments for a provider that does require them
             Assertions.assertThrows(IllegalArgumentException.class,
-                () -> originalSource.create(),
+                originalSource::create,
                 () -> "Source requires arguments: " + originalSource);
         }
     }
diff --git 
a/commons-rng-simple/src/test/java/org/apache/commons/rng/simple/internal/RandomSourceInternalParametricTest.java
 
b/commons-rng-simple/src/test/java/org/apache/commons/rng/simple/internal/RandomSourceInternalParametricTest.java
index 9eba05a7..f4f5957e 100644
--- 
a/commons-rng-simple/src/test/java/org/apache/commons/rng/simple/internal/RandomSourceInternalParametricTest.java
+++ 
b/commons-rng-simple/src/test/java/org/apache/commons/rng/simple/internal/RandomSourceInternalParametricTest.java
@@ -215,6 +215,6 @@ class RandomSourceInternalParametricTest {
 
         final Integer expected = EXPECTED_SEED_BYTES.get(randomSourceInternal);
         Assertions.assertNotNull(expected, () -> "Missing expected seed byte 
size: " + randomSourceInternal);
-        Assertions.assertEquals(expected.intValue(), size, () -> 
randomSourceInternal.toString());
+        Assertions.assertEquals(expected.intValue(), size, 
randomSourceInternal::toString);
     }
 }