This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git


The following commit(s) were added to refs/heads/master by this push:
     new 54b5c096 Javadoc @since tag should be after @throws
54b5c096 is described below

commit 54b5c0963ac1c111bdc6f7e769d1a10bb70764f3
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Mar 22 09:13:12 2025 -0400

    Javadoc @since tag should be after @throws
---
 src/main/java/org/apache/commons/dbcp2/BasicDataSource.java           | 2 +-
 src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java 
b/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
index 2d026a8e..a904ac5f 100644
--- a/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
+++ b/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
@@ -2030,8 +2030,8 @@ public class BasicDataSource implements DataSource, 
BasicDataSourceMXBean, MBean
      * </p>
      *
      * @param disconnectionSqlCodes SQL State codes considered to signal fatal 
conditions
-     * @since 2.1
      * @throws IllegalArgumentException if any SQL state codes overlap with 
those in {@link #disconnectionIgnoreSqlCodes}.
+     * @since 2.1
      */
     public void setDisconnectionSqlCodes(final Collection<String> 
disconnectionSqlCodes) {
         Utils.checkSqlCodes(disconnectionSqlCodes, 
this.disconnectionIgnoreSqlCodes);
diff --git 
a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java 
b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
index 91ce0de4..85930db3 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
@@ -699,8 +699,8 @@ public class PoolableConnectionFactory implements 
PooledObjectFactory<PoolableCo
      * @param disconnectionSqlCodes
      *            The disconnection SQL codes.
      * @see #getDisconnectionSqlCodes()
-     * @since 2.1
      * @throws IllegalArgumentException if any SQL state codes overlap with 
those in {@link #disconnectionIgnoreSqlCodes}.
+     * @since 2.1
      */
     public void setDisconnectionSqlCodes(final Collection<String> 
disconnectionSqlCodes) {
         Utils.checkSqlCodes(disconnectionSqlCodes, 
this.disconnectionIgnoreSqlCodes);

Reply via email to