Author: mikl Date: Tue Dec 28 22:19:34 2010 New Revision: 1053472 URL: http://svn.apache.org/viewvc?rev=1053472&view=rev Log: Purified tests introduced in MATH-385 such that NaNs and infinites are handled properly
Modified: commons/proper/math/trunk/src/test/java/org/apache/commons/math/distribution/CauchyDistributionTest.java commons/proper/math/trunk/src/test/java/org/apache/commons/math/distribution/FDistributionTest.java commons/proper/math/trunk/src/test/java/org/apache/commons/math/distribution/TDistributionTest.java Modified: commons/proper/math/trunk/src/test/java/org/apache/commons/math/distribution/CauchyDistributionTest.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math/distribution/CauchyDistributionTest.java?rev=1053472&r1=1053471&r2=1053472&view=diff ============================================================================== --- commons/proper/math/trunk/src/test/java/org/apache/commons/math/distribution/CauchyDistributionTest.java (original) +++ commons/proper/math/trunk/src/test/java/org/apache/commons/math/distribution/CauchyDistributionTest.java Tue Dec 28 22:19:34 2010 @@ -109,15 +109,14 @@ public class CauchyDistributionTest exte } public void testMomonts() { - final double tol = 1e-9; CauchyDistribution dist; - dist = new CauchyDistributionImpl(10.2, 0.15); - assertEquals(dist.getNumericalMean(), Double.NaN, tol); - assertEquals(dist.getNumericalVariance(), Double.NaN, tol); + dist = new CauchyDistributionImpl(10.2, 0.15); + assertTrue(Double.isNaN(dist.getNumericalMean())); + assertTrue(Double.isNaN(dist.getNumericalVariance())); dist = new CauchyDistributionImpl(23.12, 2.12); - assertEquals(dist.getNumericalMean(), Double.NaN, tol); - assertEquals(dist.getNumericalVariance(), Double.NaN, tol); + assertTrue(Double.isNaN(dist.getNumericalMean())); + assertTrue(Double.isNaN(dist.getNumericalVariance())); } } Modified: commons/proper/math/trunk/src/test/java/org/apache/commons/math/distribution/FDistributionTest.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math/distribution/FDistributionTest.java?rev=1053472&r1=1053471&r2=1053472&view=diff ============================================================================== --- commons/proper/math/trunk/src/test/java/org/apache/commons/math/distribution/FDistributionTest.java (original) +++ commons/proper/math/trunk/src/test/java/org/apache/commons/math/distribution/FDistributionTest.java Tue Dec 28 22:19:34 2010 @@ -130,12 +130,12 @@ public class FDistributionTest extends C FDistribution dist; dist = new FDistributionImpl(1, 2); - assertEquals(dist.getNumericalMean(), Double.NaN, tol); - assertEquals(dist.getNumericalVariance(), Double.NaN, tol); + assertTrue(Double.isNaN(dist.getNumericalMean())); + assertTrue(Double.isNaN(dist.getNumericalVariance())); dist = new FDistributionImpl(1, 3); assertEquals(dist.getNumericalMean(), 3d / (3d - 2d), tol); - assertEquals(dist.getNumericalVariance(), Double.NaN, tol); + assertTrue(Double.isNaN(dist.getNumericalVariance())); dist = new FDistributionImpl(1, 5); assertEquals(dist.getNumericalMean(), 5d / (5d - 2d), tol); Modified: commons/proper/math/trunk/src/test/java/org/apache/commons/math/distribution/TDistributionTest.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math/distribution/TDistributionTest.java?rev=1053472&r1=1053471&r2=1053472&view=diff ============================================================================== --- commons/proper/math/trunk/src/test/java/org/apache/commons/math/distribution/TDistributionTest.java (original) +++ commons/proper/math/trunk/src/test/java/org/apache/commons/math/distribution/TDistributionTest.java Tue Dec 28 22:19:34 2010 @@ -124,12 +124,12 @@ public class TDistributionTest extends C TDistribution dist; dist = new TDistributionImpl(1); - assertEquals(dist.getNumericalMean(), Double.NaN, tol); - assertEquals(dist.getNumericalVariance(), Double.NaN, tol); + assertTrue(Double.isNaN(dist.getNumericalMean())); + assertTrue(Double.isNaN(dist.getNumericalVariance())); dist = new TDistributionImpl(1.5); assertEquals(dist.getNumericalMean(), 0, tol); - assertEquals(dist.getNumericalVariance(), Double.POSITIVE_INFINITY, tol); + assertTrue(Double.isInfinite(dist.getNumericalVariance())); dist = new TDistributionImpl(5); assertEquals(dist.getNumericalMean(), 0, tol);