(commons-net) 06/08: Use an ArrayList instead of a Vector

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git

commit 780595c7dbcb85f0afa9dd9bd71f354134f23237
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Wed Feb 19 19:54:13 2025 -0500

    Use an ArrayList instead of a Vector
    
    - Reuse IOUtils
    - Simplify
---
 .../org/apache/commons/net/nntp/NNTPClient.java    | 22 +++++-----------------
 1 file changed, 5 insertions(+), 17 deletions(-)

diff --git a/src/main/java/org/apache/commons/net/nntp/NNTPClient.java 
b/src/main/java/org/apache/commons/net/nntp/NNTPClient.java
index d9d02f5d..84d42d5f 100644
--- a/src/main/java/org/apache/commons/net/nntp/NNTPClient.java
+++ b/src/main/java/org/apache/commons/net/nntp/NNTPClient.java
@@ -23,8 +23,10 @@ import java.io.Reader;
 import java.io.StringWriter;
 import java.io.Writer;
 import java.util.ArrayList;
+import java.util.List;
 import java.util.Vector;
 
+import org.apache.commons.io.IOUtils;
 import org.apache.commons.net.MalformedServerReplyException;
 import org.apache.commons.net.io.DotTerminatedMessageReader;
 import org.apache.commons.net.io.DotTerminatedMessageWriter;
@@ -436,25 +438,11 @@ public class NNTPClient extends NNTP {
         if (!NNTPReply.isPositiveCompletion(newnews(query.getNewsgroups(), 
query.getDate(), query.getTime(), query.isGMT(), query.getDistributions()))) {
             return null;
         }
-
-        final Vector<String> list = new Vector<>();
+        List<String> list = new ArrayList<>();
         try (BufferedReader reader = new DotTerminatedMessageReader(_reader_)) 
{
-
-            String line;
-            while ((line = reader.readLine()) != null) {
-                list.addElement(line);
-            }
+            list = IOUtils.readLines(reader);
         }
-
-        final int size = list.size();
-        if (size < 1) {
-            return NetConstants.EMPTY_STRING_ARRAY;
-        }
-
-        final String[] result = new String[size];
-        list.copyInto(result);
-
-        return result;
+        return list.toArray(NetConstants.EMPTY_STRING_ARRAY);
     }
 
     /**