This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
The following commit(s) were added to refs/heads/master by this push:
new 777e8562b Better test method name
777e8562b is described below
commit 777e8562bb33f9c7996ca70462bcf915c7a8dd5e
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Wed Feb 19 14:55:29 2025 -0500
Better test method name
---
src/test/java/org/apache/commons/io/FileUtilsTest.java | 8 ++++----
src/test/java/org/apache/commons/io/IOUtilsTest.java | 10 +++++-----
src/test/java/org/apache/commons/io/test/TestUtils.java | 2 +-
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/test/java/org/apache/commons/io/FileUtilsTest.java
b/src/test/java/org/apache/commons/io/FileUtilsTest.java
index 35e4ed897..7551192b2 100644
--- a/src/test/java/org/apache/commons/io/FileUtilsTest.java
+++ b/src/test/java/org/apache/commons/io/FileUtilsTest.java
@@ -299,7 +299,7 @@ private void openOutputStream_noParent(final boolean
createFile) throws Exceptio
assertNull(file.getParentFile());
try {
if (createFile) {
- TestUtils.createLineBasedFile(file, new String[]{"Hello"});
+ TestUtils.createLineFileUtf8(file, new String[]{"Hello"});
}
try (FileOutputStream out = FileUtils.openOutputStream(file)) {
out.write(0);
@@ -361,7 +361,7 @@ public void setUp() throws Exception {
@Test
public void test_openInputStream_exists() throws Exception {
final File file = new File(tempDirFile, "test.txt");
- TestUtils.createLineBasedFile(file, new String[]{"Hello"});
+ TestUtils.createLineFileUtf8(file, new String[]{"Hello"});
try (FileInputStream in = FileUtils.openInputStream(file)) {
assertEquals('H', in.read());
}
@@ -383,7 +383,7 @@ public void test_openInputStream_notExists() {
@Test
public void test_openOutputStream_exists() throws Exception {
final File file = new File(tempDirFile, "test.txt");
- TestUtils.createLineBasedFile(file, new String[]{"Hello"});
+ TestUtils.createLineFileUtf8(file, new String[]{"Hello"});
try (FileOutputStream out = FileUtils.openOutputStream(file)) {
out.write(0);
}
@@ -2836,7 +2836,7 @@ public void testReadLines() throws Exception {
final File file = TestUtils.newFile(tempDirFile, "lines.txt");
try {
final String[] data = {"hello", "/u1234", "", "this is", "some
text"};
- TestUtils.createLineBasedFile(file, data);
+ TestUtils.createLineFileUtf8(file, data);
final List<String> lines = FileUtils.readLines(file, UTF_8);
assertEquals(Arrays.asList(data), lines);
diff --git a/src/test/java/org/apache/commons/io/IOUtilsTest.java
b/src/test/java/org/apache/commons/io/IOUtilsTest.java
index edf74142c..b26be27e6 100644
--- a/src/test/java/org/apache/commons/io/IOUtilsTest.java
+++ b/src/test/java/org/apache/commons/io/IOUtilsTest.java
@@ -1021,7 +1021,7 @@ public void testReadLines_CharSequence() throws
IOException {
CharSequence csq = null;
try {
final String[] data = {"hello", "/u1234", "", "this is", "some
text"};
- TestUtils.createLineBasedFile(file, data);
+ TestUtils.createLineFileUtf8(file, data);
csq = new String(Files.readAllBytes(file.toPath()),
StandardCharsets.UTF_8);
final List<String> lines = IOUtils.readLines(csq);
assertEquals(Arrays.asList(data), lines);
@@ -1036,7 +1036,7 @@ public void testReadLines_CharSequenceAsStringBuilder()
throws IOException {
StringBuilder csq = null;
try {
final String[] data = {"hello", "/u1234", "", "this is", "some
text"};
- TestUtils.createLineBasedFile(file, data);
+ TestUtils.createLineFileUtf8(file, data);
csq = new StringBuilder(new
String(Files.readAllBytes(file.toPath()), StandardCharsets.UTF_8));
final List<String> lines = IOUtils.readLines(csq);
assertEquals(Arrays.asList(data), lines);
@@ -1051,7 +1051,7 @@ public void testReadLines_InputStream() throws Exception {
InputStream in = null;
try {
final String[] data = {"hello", "world", "", "this is", "some
text"};
- TestUtils.createLineBasedFile(file, data);
+ TestUtils.createLineFileUtf8(file, data);
in = Files.newInputStream(file.toPath());
final List<String> lines = IOUtils.readLines(in);
@@ -1069,7 +1069,7 @@ public void testReadLines_InputStream_String() throws
Exception {
InputStream in = null;
try {
final String[] data = {"hello", "/u1234", "", "this is", "some
text"};
- TestUtils.createLineBasedFile(file, data);
+ TestUtils.createLineFileUtf8(file, data);
in = Files.newInputStream(file.toPath());
final List<String> lines = IOUtils.readLines(in, UTF_8);
@@ -1087,7 +1087,7 @@ public void testReadLines_Reader() throws Exception {
Reader in = null;
try {
final String[] data = {"hello", "/u1234", "", "this is", "some
text"};
- TestUtils.createLineBasedFile(file, data);
+ TestUtils.createLineFileUtf8(file, data);
in = new InputStreamReader(Files.newInputStream(file.toPath()));
final List<String> lines = IOUtils.readLines(in);
assertEquals(Arrays.asList(data), lines);
diff --git a/src/test/java/org/apache/commons/io/test/TestUtils.java
b/src/test/java/org/apache/commons/io/test/TestUtils.java
index 0c9d0c36f..cab7d9146 100644
--- a/src/test/java/org/apache/commons/io/test/TestUtils.java
+++ b/src/test/java/org/apache/commons/io/test/TestUtils.java
@@ -184,7 +184,7 @@ public static void createFile(final Path file, final long
size) throws IOExcepti
}
}
- public static void createLineBasedFile(final File file, final String[]
data) throws IOException {
+ public static void createLineFileUtf8(final File file, final String[]
data) throws IOException {
if (file.getParentFile() != null && !file.getParentFile().exists()) {
throw new IOException("Cannot create file " + file + " as the
parent directory does not exist");
}
