This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-codec.git
commit ed56539e654720440b72ce8cc8d346bc4642d054 Author: Gary D. Gregory <[email protected]> AuthorDate: Sun Feb 9 17:47:57 2025 -0500 Add Checkstyle ArrayTypeStyle --- src/conf/checkstyle.xml | 1 + src/test/java/org/apache/commons/codec/AbstractStringEncoderTest.java | 2 +- .../org/apache/commons/codec/binary/Codec105ErrorInputStream.java | 2 +- src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java | 2 +- .../java/org/apache/commons/codec/language/ColognePhoneticTest.java | 2 +- src/test/java/org/apache/commons/codec/net/QCodecTest.java | 4 ++-- .../java/org/apache/commons/codec/net/QuotedPrintableCodecTest.java | 4 ++-- src/test/java/org/apache/commons/codec/net/URLCodecTest.java | 4 ++-- 8 files changed, 11 insertions(+), 10 deletions(-) diff --git a/src/conf/checkstyle.xml b/src/conf/checkstyle.xml index 91830935..7ea4138e 100644 --- a/src/conf/checkstyle.xml +++ b/src/conf/checkstyle.xml @@ -48,6 +48,7 @@ limitations under the License. <property name="file" value="src/conf/checkstyle-suppressions.xml"/> </module> <module name="TreeWalker"> + <module name="ArrayTypeStyle" /> <module name="AvoidStarImport" /> <module name="ExplicitInitializationCheck" /> <module name="FinalLocalVariable" /> diff --git a/src/test/java/org/apache/commons/codec/AbstractStringEncoderTest.java b/src/test/java/org/apache/commons/codec/AbstractStringEncoderTest.java index 7ab9b311..6fa6c887 100644 --- a/src/test/java/org/apache/commons/codec/AbstractStringEncoderTest.java +++ b/src/test/java/org/apache/commons/codec/AbstractStringEncoderTest.java @@ -41,7 +41,7 @@ public abstract class AbstractStringEncoderTest<T extends StringEncoder> { } } - protected void checkEncodingVariations(final String expected, final String data[]) throws EncoderException { + protected void checkEncodingVariations(final String expected, final String[] data) throws EncoderException { for (final String element : data) { this.checkEncoding(expected, element); } diff --git a/src/test/java/org/apache/commons/codec/binary/Codec105ErrorInputStream.java b/src/test/java/org/apache/commons/codec/binary/Codec105ErrorInputStream.java index 9aec8a5e..c6954879 100644 --- a/src/test/java/org/apache/commons/codec/binary/Codec105ErrorInputStream.java +++ b/src/test/java/org/apache/commons/codec/binary/Codec105ErrorInputStream.java @@ -41,7 +41,7 @@ public class Codec105ErrorInputStream extends InputStream { } @Override - public int read(final byte b[], final int pos, final int len) throws IOException { + public int read(final byte[] b, final int pos, final int len) throws IOException { if (this.countdown-- > 0) { b[pos] = '\n'; return 1; diff --git a/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java b/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java index 4d9343a9..bee13271 100644 --- a/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java +++ b/src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java @@ -190,7 +190,7 @@ public class PureJavaCrc32Test { } } - public static void main(final String args[]) throws Exception { + public static void main(final String[] args) throws Exception { printSystemProperties(System.out); doBench(CRCS, System.out); } diff --git a/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java b/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java index 6baab6c2..2d59494b 100644 --- a/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java +++ b/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java @@ -91,7 +91,7 @@ public class ColognePhoneticTest extends AbstractStringEncoderTest<ColognePhonet } // Allow command-line testing - public static void main(final String args[]) { + public static void main(final String[] args) { final ColognePhonetic coder = new ColognePhonetic(); for (final String arg : args) { final String code = coder.encode(arg); diff --git a/src/test/java/org/apache/commons/codec/net/QCodecTest.java b/src/test/java/org/apache/commons/codec/net/QCodecTest.java index 5e3939d6..99470063 100644 --- a/src/test/java/org/apache/commons/codec/net/QCodecTest.java +++ b/src/test/java/org/apache/commons/codec/net/QCodecTest.java @@ -35,9 +35,9 @@ import org.junit.jupiter.api.Test; */ public class QCodecTest { - static final int SWISS_GERMAN_STUFF_UNICODE[] = { 0x47, 0x72, 0xFC, 0x65, 0x7A, 0x69, 0x5F, 0x7A, 0xE4, 0x6D, 0xE4 }; + static final int[] SWISS_GERMAN_STUFF_UNICODE = { 0x47, 0x72, 0xFC, 0x65, 0x7A, 0x69, 0x5F, 0x7A, 0xE4, 0x6D, 0xE4 }; - static final int RUSSIAN_STUFF_UNICODE[] = { 0x412, 0x441, 0x435, 0x43C, 0x5F, 0x43F, 0x440, 0x438, 0x432, 0x435, 0x442 }; + static final int[] RUSSIAN_STUFF_UNICODE = { 0x412, 0x441, 0x435, 0x43C, 0x5F, 0x43F, 0x440, 0x438, 0x432, 0x435, 0x442 }; private String constructString(final int[] unicodeChars) { final StringBuilder buffer = new StringBuilder(); diff --git a/src/test/java/org/apache/commons/codec/net/QuotedPrintableCodecTest.java b/src/test/java/org/apache/commons/codec/net/QuotedPrintableCodecTest.java index 4a6dbbb1..cc903fc5 100644 --- a/src/test/java/org/apache/commons/codec/net/QuotedPrintableCodecTest.java +++ b/src/test/java/org/apache/commons/codec/net/QuotedPrintableCodecTest.java @@ -34,9 +34,9 @@ import org.junit.jupiter.api.Test; */ public class QuotedPrintableCodecTest { - static final int SWISS_GERMAN_STUFF_UNICODE[] = { 0x47, 0x72, 0xFC, 0x65, 0x7A, 0x69, 0x5F, 0x7A, 0xE4, 0x6D, 0xE4 }; + static final int[] SWISS_GERMAN_STUFF_UNICODE = { 0x47, 0x72, 0xFC, 0x65, 0x7A, 0x69, 0x5F, 0x7A, 0xE4, 0x6D, 0xE4 }; - static final int RUSSIAN_STUFF_UNICODE[] = { 0x412, 0x441, 0x435, 0x43C, 0x5F, 0x43F, 0x440, 0x438, 0x432, 0x435, 0x442 }; + static final int[] RUSSIAN_STUFF_UNICODE = { 0x412, 0x441, 0x435, 0x43C, 0x5F, 0x43F, 0x440, 0x438, 0x432, 0x435, 0x442 }; private String constructString(final int[] unicodeChars) { final StringBuilder buffer = new StringBuilder(); diff --git a/src/test/java/org/apache/commons/codec/net/URLCodecTest.java b/src/test/java/org/apache/commons/codec/net/URLCodecTest.java index 0cdf65d4..03f31fba 100644 --- a/src/test/java/org/apache/commons/codec/net/URLCodecTest.java +++ b/src/test/java/org/apache/commons/codec/net/URLCodecTest.java @@ -33,9 +33,9 @@ import org.junit.jupiter.api.Test; */ public class URLCodecTest { - static final int SWISS_GERMAN_STUFF_UNICODE[] = { 0x47, 0x72, 0xFC, 0x65, 0x7A, 0x69, 0x5F, 0x7A, 0xE4, 0x6D, 0xE4 }; + static final int[] SWISS_GERMAN_STUFF_UNICODE = { 0x47, 0x72, 0xFC, 0x65, 0x7A, 0x69, 0x5F, 0x7A, 0xE4, 0x6D, 0xE4 }; - static final int RUSSIAN_STUFF_UNICODE[] = { 0x412, 0x441, 0x435, 0x43C, 0x5F, 0x43F, 0x440, 0x438, 0x432, 0x435, 0x442 }; + static final int[] RUSSIAN_STUFF_UNICODE = { 0x412, 0x441, 0x435, 0x43C, 0x5F, 0x43F, 0x440, 0x438, 0x432, 0x435, 0x442 }; private String constructString(final int[] unicodeChars) { final StringBuilder buffer = new StringBuilder();
