This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch 1.X in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
commit 40960d93f4f99e6ce6b4073fa70e39b0ddfb1e9e Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Tue Jan 21 12:00:09 2025 -0500 Remove dead comments --- src/main/java/org/apache/commons/beanutils/BeanMap.java | 6 ------ src/main/java/org/apache/commons/beanutils/WeakFastHashMap.java | 8 -------- .../java/org/apache/commons/beanutils/bugs/Jira347TestCase.java | 1 - .../commons/beanutils/converters/ArrayConverterTestCase.java | 4 ---- .../commons/beanutils/converters/BigDecimalConverterTestCase.java | 8 -------- .../commons/beanutils/converters/BigIntegerConverterTestCase.java | 8 -------- .../commons/beanutils/converters/ByteConverterTestCase.java | 8 -------- .../commons/beanutils/converters/CharacterConverterTestCase.java | 4 ---- .../commons/beanutils/converters/ClassConverterTestCase.java | 4 ---- .../commons/beanutils/converters/ClassReloaderTestCase.java | 4 ---- .../commons/beanutils/converters/DateConverterTestBase.java | 6 ------ .../commons/beanutils/converters/DoubleConverterTestCase.java | 8 -------- .../commons/beanutils/converters/FileConverterTestCase.java | 8 -------- .../commons/beanutils/converters/FloatConverterTestCase.java | 8 -------- .../commons/beanutils/converters/IntegerConverterTestCase.java | 8 -------- .../commons/beanutils/converters/LongConverterTestCase.java | 8 -------- .../commons/beanutils/converters/NumberConverterTestBase.java | 6 ------ .../commons/beanutils/converters/ShortConverterTestCase.java | 8 -------- .../commons/beanutils/converters/SqlDateConverterTestCase.java | 4 ---- .../commons/beanutils/converters/SqlTimeConverterTestCase.java | 4 ---- .../beanutils/converters/SqlTimestampConverterTestCase.java | 4 ---- .../apache/commons/beanutils/converters/URLConverterTestCase.java | 8 -------- .../commons/beanutils/expression/DefaultResolverTestCase.java | 4 ---- .../locale/converters/BigDecimalLocaleConverterTestCase.java | 2 -- .../locale/converters/BigIntegerLocaleConverterTestCase.java | 2 -- .../beanutils/locale/converters/ByteLocaleConverterTestCase.java | 2 -- .../beanutils/locale/converters/DateLocaleConverterTestCase.java | 4 ---- .../locale/converters/DoubleLocaleConverterTestCase.java | 2 -- .../beanutils/locale/converters/FloatLocaleConverterTestCase.java | 2 -- .../locale/converters/IntegerLocaleConverterTestCase.java | 2 -- .../beanutils/locale/converters/LongLocaleConverterTestCase.java | 2 -- .../beanutils/locale/converters/ShortLocaleConverterTestCase.java | 2 -- .../commons/beanutils/memoryleaktests/MemoryLeakTestCase.java | 8 -------- 33 files changed, 167 deletions(-) diff --git a/src/main/java/org/apache/commons/beanutils/BeanMap.java b/src/main/java/org/apache/commons/beanutils/BeanMap.java index ffa4b43c..182da078 100644 --- a/src/main/java/org/apache/commons/beanutils/BeanMap.java +++ b/src/main/java/org/apache/commons/beanutils/BeanMap.java @@ -199,7 +199,6 @@ public class BeanMap extends AbstractMap<Object, Object> implements Cloneable { private transient HashMap<String, Method> writeMethods = new HashMap<>(); // Constructors - //------------------------------------------------------------------------- private transient HashMap<String, Class<? extends Object>> types = new HashMap<>(); @@ -210,7 +209,6 @@ public class BeanMap extends AbstractMap<Object, Object> implements Cloneable { } // Map interface - //------------------------------------------------------------------------- /** * Constructs a new <code>BeanMap</code> that operates on the @@ -539,7 +537,6 @@ public class BeanMap extends AbstractMap<Object, Object> implements Cloneable { } // Helper methods - //------------------------------------------------------------------------- /** * Returns the accessor for the property with the given name. @@ -586,7 +583,6 @@ public class BeanMap extends AbstractMap<Object, Object> implements Cloneable { } // Properties - //------------------------------------------------------------------------- /** * Returns the mutator for the property with the given name. @@ -656,7 +652,6 @@ public class BeanMap extends AbstractMap<Object, Object> implements Cloneable { } // Implementation methods - //------------------------------------------------------------------------- /** * Get the keys for this BeanMap. @@ -750,7 +745,6 @@ public class BeanMap extends AbstractMap<Object, Object> implements Cloneable { } // Implementation classes - //------------------------------------------------------------------------- /** * Reinitializes this bean. Called during {@link #setBean(Object)}. diff --git a/src/main/java/org/apache/commons/beanutils/WeakFastHashMap.java b/src/main/java/org/apache/commons/beanutils/WeakFastHashMap.java index a3ef2640..08b191d0 100644 --- a/src/main/java/org/apache/commons/beanutils/WeakFastHashMap.java +++ b/src/main/java/org/apache/commons/beanutils/WeakFastHashMap.java @@ -316,7 +316,6 @@ class WeakFastHashMap<K, V> extends HashMap<K, V> { } // Constructors - // ---------------------------------------------------------------------- /** * Collection implementation over the values of the FastHashMap @@ -347,7 +346,6 @@ class WeakFastHashMap<K, V> extends HashMap<K, V> { private boolean fast; // Property access - // ---------------------------------------------------------------------- /** * Construct an empty map. @@ -366,7 +364,6 @@ class WeakFastHashMap<K, V> extends HashMap<K, V> { } // Map access - // ---------------------------------------------------------------------- // These methods can forward straight to the wrapped Map in 'fast' mode. // (because they are query methods) @@ -430,7 +427,6 @@ class WeakFastHashMap<K, V> extends HashMap<K, V> { } // Map modification - // ---------------------------------------------------------------------- // These methods perform special behaviour in 'fast' mode. // The map is cloned, updated and then assigned back. // See the comments at the top as to why this won't always work. @@ -478,7 +474,6 @@ class WeakFastHashMap<K, V> extends HashMap<K, V> { } // Basic object methods - // ---------------------------------------------------------------------- protected Map<K, V> createMap(final int capacity, final float factor) { return new WeakHashMap<>(capacity, factor); @@ -499,7 +494,6 @@ class WeakFastHashMap<K, V> extends HashMap<K, V> { } // Map views - // ---------------------------------------------------------------------- /** * Compare the specified object with this list for equality. This @@ -588,7 +582,6 @@ class WeakFastHashMap<K, V> extends HashMap<K, V> { } // Abstractions on Map creations (for subclasses such as WeakFastHashMap) - // ---------------------------------------------------------------------- /** * Return the hash code value for this map. This implementation uses @@ -685,7 +678,6 @@ class WeakFastHashMap<K, V> extends HashMap<K, V> { } // Map view inner classes - // ---------------------------------------------------------------------- /** * Remove any mapping for this key, and return any previously diff --git a/src/test/java/org/apache/commons/beanutils/bugs/Jira347TestCase.java b/src/test/java/org/apache/commons/beanutils/bugs/Jira347TestCase.java index 95db1466..1dac286d 100644 --- a/src/test/java/org/apache/commons/beanutils/bugs/Jira347TestCase.java +++ b/src/test/java/org/apache/commons/beanutils/bugs/Jira347TestCase.java @@ -120,7 +120,6 @@ public class Jira347TestCase extends TestCase { final ClassLoader loader = newClassLoader(); final Class<?> beanClass = loader.loadClass(className); beanClass.getConstructor().newInstance(); - // ----------------------------------------------------------------------------- // Sanity checks only assertNotNull("ClassLoader is null", loader); diff --git a/src/test/java/org/apache/commons/beanutils/converters/ArrayConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/ArrayConverterTestCase.java index d4ea3d79..94fd435c 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/ArrayConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/ArrayConverterTestCase.java @@ -38,8 +38,6 @@ public class ArrayConverterTestCase extends TestCase { return new TestSuite(ArrayConverterTestCase.class); } - // ------------------------------------------------------------------------ - /** * Construct a new Array Converter test case. * @param name Test Name @@ -74,8 +72,6 @@ public class ArrayConverterTestCase extends TestCase { public void setUp() throws Exception { } - // ------------------------------------------------------------------------ - /** Tear Down */ @Override public void tearDown() throws Exception { diff --git a/src/test/java/org/apache/commons/beanutils/converters/BigDecimalConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/BigDecimalConverterTestCase.java index 77584427..ec7a5118 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/BigDecimalConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/BigDecimalConverterTestCase.java @@ -42,14 +42,10 @@ public class BigDecimalConverterTestCase extends NumberConverterTestBase { } } - // ------------------------------------------------------------------------ - public static TestSuite suite() { return new TestSuite(BigDecimalConverterTestCase.class); } - // ------------------------------------------------------------------------ - private Converter converter; public BigDecimalConverterTestCase(final String name) { @@ -61,8 +57,6 @@ public class BigDecimalConverterTestCase extends NumberConverterTestBase { return BigDecimal.class; } - // ------------------------------------------------------------------------ - @Override protected NumberConverter makeConverter() { return new BigDecimalConverter(); @@ -82,8 +76,6 @@ public class BigDecimalConverterTestCase extends NumberConverterTestBase { numbers[3] = new BigDecimal("23"); } - // ------------------------------------------------------------------------ - @Override public void tearDown() throws Exception { converter = null; diff --git a/src/test/java/org/apache/commons/beanutils/converters/BigIntegerConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/BigIntegerConverterTestCase.java index 5352e0a8..dcbd7b4c 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/BigIntegerConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/BigIntegerConverterTestCase.java @@ -33,12 +33,8 @@ public class BigIntegerConverterTestCase extends NumberConverterTestBase { return new TestSuite(BigIntegerConverterTestCase.class); } - // ------------------------------------------------------------------------ - private Converter converter; - // ------------------------------------------------------------------------ - public BigIntegerConverterTestCase(final String name) { super(name); } @@ -53,8 +49,6 @@ public class BigIntegerConverterTestCase extends NumberConverterTestBase { return new BigIntegerConverter(); } - // ------------------------------------------------------------------------ - @Override protected NumberConverter makeConverter(final Object defaultValue) { return new BigIntegerConverter(defaultValue); @@ -74,8 +68,6 @@ public class BigIntegerConverterTestCase extends NumberConverterTestBase { converter = null; } - // ------------------------------------------------------------------------ - public void testSimpleConversion() throws Exception { final String[] message= { "from String", diff --git a/src/test/java/org/apache/commons/beanutils/converters/ByteConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/ByteConverterTestCase.java index 1327b139..73f58408 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/ByteConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/ByteConverterTestCase.java @@ -32,12 +32,8 @@ public class ByteConverterTestCase extends NumberConverterTestBase { return new TestSuite(ByteConverterTestCase.class); } - // ------------------------------------------------------------------------ - private Converter converter; - // ------------------------------------------------------------------------ - public ByteConverterTestCase(final String name) { super(name); } @@ -52,8 +48,6 @@ public class ByteConverterTestCase extends NumberConverterTestBase { return new ByteConverter(); } - // ------------------------------------------------------------------------ - @Override protected NumberConverter makeConverter(final Object defaultValue) { return new ByteConverter(defaultValue); @@ -72,8 +66,6 @@ public class ByteConverterTestCase extends NumberConverterTestBase { converter = null; } - // ------------------------------------------------------------------------ - /** * Test Invalid Amounts (too big/small) */ diff --git a/src/test/java/org/apache/commons/beanutils/converters/CharacterConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/CharacterConverterTestCase.java index 4c602b30..c373a4f4 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/CharacterConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/CharacterConverterTestCase.java @@ -36,8 +36,6 @@ public class CharacterConverterTestCase extends TestCase { return new TestSuite(CharacterConverterTestCase.class); } - // ------------------------------------------------------------------------ - /** * Construct a new Character Converter test case. * @param name Test Name @@ -56,8 +54,6 @@ public class CharacterConverterTestCase extends TestCase { public void tearDown() throws Exception { } - // ------------------------------------------------------------------------ - /** * Tests whether the primitive char class can be passed as target type. */ diff --git a/src/test/java/org/apache/commons/beanutils/converters/ClassConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/ClassConverterTestCase.java index cf512c84..44508755 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/ClassConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/ClassConverterTestCase.java @@ -36,8 +36,6 @@ public class ClassConverterTestCase extends TestCase { return new TestSuite(ClassConverterTestCase.class); } - // ------------------------------------------------------------------------ - /** * Construct a new Class Converter test case. * @param name Test Name @@ -56,8 +54,6 @@ public class ClassConverterTestCase extends TestCase { public void tearDown() throws Exception { } - // ------------------------------------------------------------------------ - /** * Test Array Conversion */ diff --git a/src/test/java/org/apache/commons/beanutils/converters/ClassReloaderTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/ClassReloaderTestCase.java index 14a6a9d7..d0d72e3f 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/ClassReloaderTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/ClassReloaderTestCase.java @@ -27,8 +27,6 @@ import junit.framework.TestSuite; public class ClassReloaderTestCase extends TestCase { - // ------------------------------------------------------------------------ - public static class DummyClass { } @@ -36,8 +34,6 @@ public class ClassReloaderTestCase extends TestCase { return new TestSuite(ClassReloaderTestCase.class); } - // ------------------------------------------------------------------------ - public ClassReloaderTestCase(final String name) { super(name); } diff --git a/src/test/java/org/apache/commons/beanutils/converters/DateConverterTestBase.java b/src/test/java/org/apache/commons/beanutils/converters/DateConverterTestBase.java index 510f37ee..71651f35 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/DateConverterTestBase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/DateConverterTestBase.java @@ -36,8 +36,6 @@ import junit.framework.TestCase; public abstract class DateConverterTestBase extends TestCase { - // ------------------------------------------------------------------------ - /** * Construct a new test case. * @param name Name of the test @@ -46,8 +44,6 @@ public abstract class DateConverterTestBase extends TestCase { super(name); } - // ------------------------------------------------------------------------ - /** * Return the expected type * @return The expected type @@ -99,8 +95,6 @@ public abstract class DateConverterTestBase extends TestCase { */ protected abstract DateTimeConverter makeConverter(); - // ------------------------------------------------------------------------ - /** * Create the Converter with a default value. * @param defaultValue The default value diff --git a/src/test/java/org/apache/commons/beanutils/converters/DoubleConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/DoubleConverterTestCase.java index ce1921f8..3efeac57 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/DoubleConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/DoubleConverterTestCase.java @@ -32,12 +32,8 @@ public class DoubleConverterTestCase extends NumberConverterTestBase { return new TestSuite(DoubleConverterTestCase.class); } - // ------------------------------------------------------------------------ - private Converter converter; - // ------------------------------------------------------------------------ - public DoubleConverterTestCase(final String name) { super(name); } @@ -52,8 +48,6 @@ public class DoubleConverterTestCase extends NumberConverterTestBase { return new DoubleConverter(); } - // ------------------------------------------------------------------------ - @Override protected NumberConverter makeConverter(final Object defaultValue) { return new DoubleConverter(defaultValue); @@ -73,8 +67,6 @@ public class DoubleConverterTestCase extends NumberConverterTestBase { converter = null; } - // ------------------------------------------------------------------------ - public void testSimpleConversion() throws Exception { final String[] message= { "from String", diff --git a/src/test/java/org/apache/commons/beanutils/converters/FileConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/FileConverterTestCase.java index ac4ec81a..247cc3ff 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/FileConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/FileConverterTestCase.java @@ -36,12 +36,8 @@ public class FileConverterTestCase extends TestCase { return new TestSuite(FileConverterTestCase.class); } - // ------------------------------------------------------------------------ - private Converter converter; - // ------------------------------------------------------------------------ - public FileConverterTestCase(final String name) { super(name); } @@ -54,8 +50,6 @@ public class FileConverterTestCase extends TestCase { return new FileConverter(); } - // ------------------------------------------------------------------------ - @Override public void setUp() throws Exception { converter = makeConverter(); @@ -66,8 +60,6 @@ public class FileConverterTestCase extends TestCase { converter = null; } - // ------------------------------------------------------------------------ - public void testSimpleConversion() throws Exception { final String[] message= { "from String", diff --git a/src/test/java/org/apache/commons/beanutils/converters/FloatConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/FloatConverterTestCase.java index 9d9ae315..6b00db68 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/FloatConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/FloatConverterTestCase.java @@ -32,12 +32,8 @@ public class FloatConverterTestCase extends NumberConverterTestBase { return new TestSuite(FloatConverterTestCase.class); } - // ------------------------------------------------------------------------ - private Converter converter; - // ------------------------------------------------------------------------ - public FloatConverterTestCase(final String name) { super(name); } @@ -52,8 +48,6 @@ public class FloatConverterTestCase extends NumberConverterTestBase { return new FloatConverter(); } - // ------------------------------------------------------------------------ - @Override protected NumberConverter makeConverter(final Object defaultValue) { return new FloatConverter(defaultValue); @@ -73,8 +67,6 @@ public class FloatConverterTestCase extends NumberConverterTestBase { converter = null; } - // ------------------------------------------------------------------------ - /** * Test Invalid Amounts (too big/small) */ diff --git a/src/test/java/org/apache/commons/beanutils/converters/IntegerConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/IntegerConverterTestCase.java index 25bb5726..a2e28cf9 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/IntegerConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/IntegerConverterTestCase.java @@ -33,12 +33,8 @@ public class IntegerConverterTestCase extends NumberConverterTestBase { return new TestSuite(IntegerConverterTestCase.class); } - // ------------------------------------------------------------------------ - private Converter converter; - // ------------------------------------------------------------------------ - public IntegerConverterTestCase(final String name) { super(name); } @@ -53,8 +49,6 @@ public class IntegerConverterTestCase extends NumberConverterTestBase { return new IntegerConverter(); } - // ------------------------------------------------------------------------ - @Override protected NumberConverter makeConverter(final Object defaultValue) { return new IntegerConverter(defaultValue); @@ -74,8 +68,6 @@ public class IntegerConverterTestCase extends NumberConverterTestBase { converter = null; } - // ------------------------------------------------------------------------ - /** * Test Invalid Amounts (too big/small) */ diff --git a/src/test/java/org/apache/commons/beanutils/converters/LongConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/LongConverterTestCase.java index c9745da8..a9659880 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/LongConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/LongConverterTestCase.java @@ -32,12 +32,8 @@ public class LongConverterTestCase extends NumberConverterTestBase { return new TestSuite(LongConverterTestCase.class); } - // ------------------------------------------------------------------------ - private Converter converter; - // ------------------------------------------------------------------------ - public LongConverterTestCase(final String name) { super(name); } @@ -52,8 +48,6 @@ public class LongConverterTestCase extends NumberConverterTestBase { return new LongConverter(); } - // ------------------------------------------------------------------------ - @Override protected NumberConverter makeConverter(final Object defaultValue) { return new LongConverter(defaultValue); @@ -73,8 +67,6 @@ public class LongConverterTestCase extends NumberConverterTestBase { converter = null; } - // ------------------------------------------------------------------------ - public void testSimpleConversion() throws Exception { final String[] message= { "from String", diff --git a/src/test/java/org/apache/commons/beanutils/converters/NumberConverterTestBase.java b/src/test/java/org/apache/commons/beanutils/converters/NumberConverterTestBase.java index ac67640b..392d1dea 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/NumberConverterTestBase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/NumberConverterTestBase.java @@ -37,20 +37,14 @@ public abstract class NumberConverterTestBase extends TestCase { /** Test Number values */ protected Number[] numbers = new Number[4]; - // ------------------------------------------------------------------------ - public NumberConverterTestBase(final String name) { super(name); } - // ------------------------------------------------------------------------ - protected abstract Class<?> getExpectedType(); protected abstract NumberConverter makeConverter(); protected abstract NumberConverter makeConverter(Object defaultValue); - // ------------------------------------------------------------------------ - /** * Convert Boolean --> Number (default conversion) */ diff --git a/src/test/java/org/apache/commons/beanutils/converters/ShortConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/ShortConverterTestCase.java index 1fbfa2c9..00c6a4ff 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/ShortConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/ShortConverterTestCase.java @@ -32,12 +32,8 @@ public class ShortConverterTestCase extends NumberConverterTestBase { return new TestSuite(ShortConverterTestCase.class); } - // ------------------------------------------------------------------------ - private Converter converter; - // ------------------------------------------------------------------------ - public ShortConverterTestCase(final String name) { super(name); } @@ -52,8 +48,6 @@ public class ShortConverterTestCase extends NumberConverterTestBase { return new ShortConverter(); } - // ------------------------------------------------------------------------ - @Override protected NumberConverter makeConverter(final Object defaultValue) { return new ShortConverter(defaultValue); @@ -73,8 +67,6 @@ public class ShortConverterTestCase extends NumberConverterTestBase { converter = null; } - // ------------------------------------------------------------------------ - /** * Test Invalid Amounts (too big/small) */ diff --git a/src/test/java/org/apache/commons/beanutils/converters/SqlDateConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/SqlDateConverterTestCase.java index 6a4c4cc7..c1300e99 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/SqlDateConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/SqlDateConverterTestCase.java @@ -37,8 +37,6 @@ public class SqlDateConverterTestCase extends DateConverterTestBase { return new TestSuite(SqlDateConverterTestCase.class); } - // ------------------------------------------------------------------------ - /** * Construct a new Date test case. * @param name Test Name @@ -47,8 +45,6 @@ public class SqlDateConverterTestCase extends DateConverterTestBase { super(name); } - // ------------------------------------------------------------------------ - /** * Return the expected type * @return The expected type diff --git a/src/test/java/org/apache/commons/beanutils/converters/SqlTimeConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/SqlTimeConverterTestCase.java index 4a6d5b56..4893ec03 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/SqlTimeConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/SqlTimeConverterTestCase.java @@ -40,8 +40,6 @@ public class SqlTimeConverterTestCase extends DateConverterTestBase { return new TestSuite(SqlTimeConverterTestCase.class); } - // ------------------------------------------------------------------------ - /** * Construct a new Date test case. * @param name Test Name @@ -50,8 +48,6 @@ public class SqlTimeConverterTestCase extends DateConverterTestBase { super(name); } - // ------------------------------------------------------------------------ - /** * Return the expected type * @return The expected type diff --git a/src/test/java/org/apache/commons/beanutils/converters/SqlTimestampConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/SqlTimestampConverterTestCase.java index 3ee87b0f..b1e7e778 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/SqlTimestampConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/SqlTimestampConverterTestCase.java @@ -39,8 +39,6 @@ public class SqlTimestampConverterTestCase extends DateConverterTestBase { return new TestSuite(SqlTimestampConverterTestCase.class); } - // ------------------------------------------------------------------------ - /** * Construct a new Date test case. * @param name Test Name @@ -49,8 +47,6 @@ public class SqlTimestampConverterTestCase extends DateConverterTestBase { super(name); } - // ------------------------------------------------------------------------ - /** * Return the expected type * @return The expected type diff --git a/src/test/java/org/apache/commons/beanutils/converters/URLConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/URLConverterTestCase.java index 01784e6c..7d57780b 100644 --- a/src/test/java/org/apache/commons/beanutils/converters/URLConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/converters/URLConverterTestCase.java @@ -36,12 +36,8 @@ public class URLConverterTestCase extends TestCase { return new TestSuite(URLConverterTestCase.class); } - // ------------------------------------------------------------------------ - private Converter converter; - // ------------------------------------------------------------------------ - public URLConverterTestCase(final String name) { super(name); } @@ -54,8 +50,6 @@ public class URLConverterTestCase extends TestCase { return new URLConverter(); } - // ------------------------------------------------------------------------ - @Override public void setUp() throws Exception { converter = makeConverter(); @@ -66,8 +60,6 @@ public class URLConverterTestCase extends TestCase { converter = null; } - // ------------------------------------------------------------------------ - public void testSimpleConversion() throws Exception { final String[] message= { "from String", diff --git a/src/test/java/org/apache/commons/beanutils/expression/DefaultResolverTestCase.java b/src/test/java/org/apache/commons/beanutils/expression/DefaultResolverTestCase.java index c4201894..d9e02011 100644 --- a/src/test/java/org/apache/commons/beanutils/expression/DefaultResolverTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/expression/DefaultResolverTestCase.java @@ -53,8 +53,6 @@ public class DefaultResolverTestCase extends TestCase { private final String[] removeProperties = {null, null, "e", "h", "kl", null, null, "s", null, "wx"}; - // ------------------------------------------------------------------------ - /** * Construct a DefaultResolver Test Case. * @param name The name of the test @@ -74,8 +72,6 @@ public class DefaultResolverTestCase extends TestCase { protected void setUp() { } - // ------------------------------------------------------------------------ - /** * Tear Down */ diff --git a/src/test/java/org/apache/commons/beanutils/locale/converters/BigDecimalLocaleConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/locale/converters/BigDecimalLocaleConverterTestCase.java index 49818d47..727b5461 100644 --- a/src/test/java/org/apache/commons/beanutils/locale/converters/BigDecimalLocaleConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/locale/converters/BigDecimalLocaleConverterTestCase.java @@ -51,8 +51,6 @@ public class BigDecimalLocaleConverterTestCase extends BaseLocaleConverterTestCa super.tearDown(); } - // ------------------------------------------------------------------------ - /** * Test Converter() constructor * diff --git a/src/test/java/org/apache/commons/beanutils/locale/converters/BigIntegerLocaleConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/locale/converters/BigIntegerLocaleConverterTestCase.java index e3af4fc5..bdda43e9 100644 --- a/src/test/java/org/apache/commons/beanutils/locale/converters/BigIntegerLocaleConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/locale/converters/BigIntegerLocaleConverterTestCase.java @@ -53,8 +53,6 @@ public class BigIntegerLocaleConverterTestCase extends BaseLocaleConverterTestCa super.tearDown(); } - // ------------------------------------------------------------------------ - /** * Test Converter() constructor * diff --git a/src/test/java/org/apache/commons/beanutils/locale/converters/ByteLocaleConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/locale/converters/ByteLocaleConverterTestCase.java index b8735edb..4f98a227 100644 --- a/src/test/java/org/apache/commons/beanutils/locale/converters/ByteLocaleConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/locale/converters/ByteLocaleConverterTestCase.java @@ -59,8 +59,6 @@ public class ByteLocaleConverterTestCase extends BaseLocaleConverterTestCase { super.tearDown(); } - // ------------------------------------------------------------------------ - /** * Test Converter() constructor * diff --git a/src/test/java/org/apache/commons/beanutils/locale/converters/DateLocaleConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/locale/converters/DateLocaleConverterTestCase.java index e97a6b7c..823d68ea 100644 --- a/src/test/java/org/apache/commons/beanutils/locale/converters/DateLocaleConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/locale/converters/DateLocaleConverterTestCase.java @@ -45,8 +45,6 @@ public class DateLocaleConverterTestCase extends BaseLocaleConverterTestCase { protected boolean validLocalDateSymbols; - // ------------------------------------------------------------------------ - public DateLocaleConverterTestCase(final String name) { super(name); } @@ -107,8 +105,6 @@ public class DateLocaleConverterTestCase extends BaseLocaleConverterTestCase { super.tearDown(); } - // ------------------------------------------------------------------------ - /** * Test Calendar */ diff --git a/src/test/java/org/apache/commons/beanutils/locale/converters/DoubleLocaleConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/locale/converters/DoubleLocaleConverterTestCase.java index 58b4f569..024bd70a 100644 --- a/src/test/java/org/apache/commons/beanutils/locale/converters/DoubleLocaleConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/locale/converters/DoubleLocaleConverterTestCase.java @@ -49,8 +49,6 @@ public class DoubleLocaleConverterTestCase extends BaseLocaleConverterTestCase { super.tearDown(); } - // ------------------------------------------------------------------------ - /** * Test Converter() constructor * diff --git a/src/test/java/org/apache/commons/beanutils/locale/converters/FloatLocaleConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/locale/converters/FloatLocaleConverterTestCase.java index d926a5cd..61fc5471 100644 --- a/src/test/java/org/apache/commons/beanutils/locale/converters/FloatLocaleConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/locale/converters/FloatLocaleConverterTestCase.java @@ -55,8 +55,6 @@ public class FloatLocaleConverterTestCase extends BaseLocaleConverterTestCase { super.tearDown(); } - // ------------------------------------------------------------------------ - /** * Test Converter() constructor * diff --git a/src/test/java/org/apache/commons/beanutils/locale/converters/IntegerLocaleConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/locale/converters/IntegerLocaleConverterTestCase.java index 658c74ad..23815ab2 100644 --- a/src/test/java/org/apache/commons/beanutils/locale/converters/IntegerLocaleConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/locale/converters/IntegerLocaleConverterTestCase.java @@ -49,8 +49,6 @@ public class IntegerLocaleConverterTestCase extends BaseLocaleConverterTestCase super.tearDown(); } - // ------------------------------------------------------------------------ - /** * Test Converter() constructor * diff --git a/src/test/java/org/apache/commons/beanutils/locale/converters/LongLocaleConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/locale/converters/LongLocaleConverterTestCase.java index 89c34c05..90bd6bc8 100644 --- a/src/test/java/org/apache/commons/beanutils/locale/converters/LongLocaleConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/locale/converters/LongLocaleConverterTestCase.java @@ -49,8 +49,6 @@ public class LongLocaleConverterTestCase extends BaseLocaleConverterTestCase { super.tearDown(); } - // ------------------------------------------------------------------------ - /** * Test Converter() constructor * diff --git a/src/test/java/org/apache/commons/beanutils/locale/converters/ShortLocaleConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/locale/converters/ShortLocaleConverterTestCase.java index 50fe8c2c..b37351f5 100644 --- a/src/test/java/org/apache/commons/beanutils/locale/converters/ShortLocaleConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/locale/converters/ShortLocaleConverterTestCase.java @@ -49,8 +49,6 @@ public class ShortLocaleConverterTestCase extends BaseLocaleConverterTestCase { super.tearDown(); } - // ------------------------------------------------------------------------ - /** * Test Converter() constructor * diff --git a/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java b/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java index 5904d7f0..8f8e96cd 100644 --- a/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java @@ -185,7 +185,6 @@ public class MemoryLeakTestCase { ClassLoader loader = newClassLoader(); Class<?> beanClass = loader.loadClass(className); Object bean = beanClass.getConstructor().newInstance(); - // ----------------------------------------------------------------------------- final WeakReference<ClassLoader> someRef = new WeakReference<>(loader); @@ -233,7 +232,6 @@ public class MemoryLeakTestCase { ClassLoader loader = newClassLoader(); Class<?> beanClass = loader.loadClass(className); Object bean = beanClass.getConstructor().newInstance(); - // ----------------------------------------------------------------------------- final WeakReference<ClassLoader> someRef = new WeakReference<>(loader); @@ -280,7 +278,6 @@ public class MemoryLeakTestCase { final ClassLoader loader = newClassLoader(); final Class<?> beanClass = loader.loadClass(className); final Object bean = beanClass.getConstructor().newInstance(); - // ----------------------------------------------------------------------------- // Sanity checks only assertNotNull("ClassLoader is null", loader); @@ -326,7 +323,6 @@ public class MemoryLeakTestCase { ClassLoader loader = newClassLoader(); Class<?> beanClass = loader.loadClass(className); Object bean = beanClass.getConstructor().newInstance(); - // ----------------------------------------------------------------------------- // Sanity checks only assertNotNull("ClassLoader is null", loader); @@ -378,7 +374,6 @@ public class MemoryLeakTestCase { ClassLoader loader = newClassLoader(); Class<?> beanClass = loader.loadClass(className); Object bean = beanClass.getConstructor().newInstance(); - // ----------------------------------------------------------------------------- final WeakReference<ClassLoader> someRef = new WeakReference<>(loader); @@ -425,7 +420,6 @@ public class MemoryLeakTestCase { ClassLoader loader = newClassLoader(); Class<?> beanClass = loader.loadClass(className); Object bean = beanClass.getConstructor().newInstance(); - // ----------------------------------------------------------------------------- final WeakReference<ClassLoader> someRef = new WeakReference<>(loader); @@ -472,7 +466,6 @@ public class MemoryLeakTestCase { ClassLoader loader = newClassLoader(); Class<?> beanClass = loader.loadClass(className); Object bean = beanClass.getConstructor().newInstance(); - // ----------------------------------------------------------------------------- final WeakReference<ClassLoader> someRef = new WeakReference<>(loader); @@ -526,7 +519,6 @@ public class MemoryLeakTestCase { Class<?> beanClass = loader.loadClass(className); Object bean = beanClass.getConstructor().newInstance(); WrapDynaBean wrapDynaBean = new WrapDynaBean(bean); - // ----------------------------------------------------------------------------- final WeakReference<ClassLoader> someRef = new WeakReference<>(loader);