This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git


The following commit(s) were added to refs/heads/master by this push:
     new 7ba374024 Add Checkstyle FallThrough
7ba374024 is described below

commit 7ba374024b0d365cc8f23f706af5b25b30db8233
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Dec 29 10:56:44 2024 -0500

    Add Checkstyle FallThrough
    
    Use the default Checkstyle reliefPattern
---
 src/conf/checkstyle/checkstyle.xml                                    | 1 +
 .../compress/compressors/lz4/BlockLZ4CompressorInputStream.java       | 4 ++--
 .../java/org/apache/commons/compress/harmony/unpack200/BcBands.java   | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/conf/checkstyle/checkstyle.xml 
b/src/conf/checkstyle/checkstyle.xml
index 7a6c1d553..88f69b048 100644
--- a/src/conf/checkstyle/checkstyle.xml
+++ b/src/conf/checkstyle/checkstyle.xml
@@ -57,6 +57,7 @@ limitations under the License.
     <!-- <module name="EqualsHashCode" /> -->
     <module name="ExplicitInitializationCheck" />
     <module name="FinalLocalVariable" />
+    <module name="FallThrough" />
     <module name="IllegalImport" />
     <module name="IllegalInstantiation" />
     <module name="ImportOrder">
diff --git 
a/src/main/java/org/apache/commons/compress/compressors/lz4/BlockLZ4CompressorInputStream.java
 
b/src/main/java/org/apache/commons/compress/compressors/lz4/BlockLZ4CompressorInputStream.java
index e4f7e59e1..a871fa371 100644
--- 
a/src/main/java/org/apache/commons/compress/compressors/lz4/BlockLZ4CompressorInputStream.java
+++ 
b/src/main/java/org/apache/commons/compress/compressors/lz4/BlockLZ4CompressorInputStream.java
@@ -101,7 +101,7 @@ public class BlockLZ4CompressorInputStream extends 
AbstractLZ77CompressorInputSt
             return -1;
         case NO_BLOCK: // NOSONAR - fallthrough intended
             readSizes();
-            /* FALLTHROUGH */
+            // falls-through
         case IN_LITERAL:
             final int litLen = readLiteral(b, off, len);
             if (!hasMoreDataInBlock()) {
@@ -113,7 +113,7 @@ public class BlockLZ4CompressorInputStream extends 
AbstractLZ77CompressorInputSt
                 state = State.EOF;
                 return -1;
             }
-            /* FALLTHROUGH */
+            // falls-through
         case IN_BACK_REFERENCE:
             final int backReferenceLen = readBackReference(b, off, len);
             if (!hasMoreDataInBlock()) {
diff --git 
a/src/main/java/org/apache/commons/compress/harmony/unpack200/BcBands.java 
b/src/main/java/org/apache/commons/compress/harmony/unpack200/BcBands.java
index abdef7446..e2375111a 100644
--- a/src/main/java/org/apache/commons/compress/harmony/unpack200/BcBands.java
+++ b/src/main/java/org/apache/commons/compress/harmony/unpack200/BcBands.java
@@ -254,7 +254,7 @@ public class BcBands extends BandSet {
                             break;
                         case 197: // multianewarray
                             bcByteCount++;
-                            // fallthrough intended
+                            // falls-through
                         case 233: // cldc
                         case 236: // cldc_w
                         case 187: // new

Reply via email to