This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch 1.X
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
The following commit(s) were added to refs/heads/1.X by this push:
new 15c7b2d4 Remove redundant type casts
15c7b2d4 is described below
commit 15c7b2d4df245f301a4272364943135a7ea555cb
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Thu Dec 26 14:36:36 2024 -0500
Remove redundant type casts
---
.../commons/beanutils/converters/BooleanArrayConverter.java | 2 +-
.../apache/commons/beanutils/converters/ByteArrayConverter.java | 2 +-
.../commons/beanutils/converters/CharacterArrayConverter.java | 2 +-
.../commons/beanutils/converters/DoubleArrayConverter.java | 2 +-
.../apache/commons/beanutils/converters/FloatArrayConverter.java | 2 +-
.../commons/beanutils/converters/IntegerArrayConverter.java | 2 +-
.../apache/commons/beanutils/converters/LongArrayConverter.java | 2 +-
.../apache/commons/beanutils/converters/ShortArrayConverter.java | 2 +-
.../commons/beanutils/converters/StringArrayConverter.java | 2 +-
.../commons/beanutils/locale/LocaleConvertUtilsTestCase.java | 9 ++++-----
10 files changed, 13 insertions(+), 14 deletions(-)
diff --git
a/src/main/java/org/apache/commons/beanutils/converters/BooleanArrayConverter.java
b/src/main/java/org/apache/commons/beanutils/converters/BooleanArrayConverter.java
index 71327c9e..7c809eaa 100644
---
a/src/main/java/org/apache/commons/beanutils/converters/BooleanArrayConverter.java
+++
b/src/main/java/org/apache/commons/beanutils/converters/BooleanArrayConverter.java
@@ -207,7 +207,7 @@ public final class BooleanArrayConverter extends
AbstractArrayConverter {
final List<String> list = parseElements(value.toString());
final boolean[] results = new boolean[list.size()];
for (int i = 0; i < results.length; i++) {
- final String stringValue = (String) list.get(i);
+ final String stringValue = list.get(i);
final Object result = booleanConverter.convert(Boolean.class,
stringValue);
results[i] = ((Boolean) result).booleanValue();
}
diff --git
a/src/main/java/org/apache/commons/beanutils/converters/ByteArrayConverter.java
b/src/main/java/org/apache/commons/beanutils/converters/ByteArrayConverter.java
index 57681684..c338fc2e 100644
---
a/src/main/java/org/apache/commons/beanutils/converters/ByteArrayConverter.java
+++
b/src/main/java/org/apache/commons/beanutils/converters/ByteArrayConverter.java
@@ -112,7 +112,7 @@ public final class ByteArrayConverter extends
AbstractArrayConverter {
final List<String> list = parseElements(value.toString());
final byte[] results = new byte[list.size()];
for (int i = 0; i < results.length; i++) {
- results[i] = Byte.parseByte((String) list.get(i));
+ results[i] = Byte.parseByte(list.get(i));
}
return results;
} catch (final Exception e) {
diff --git
a/src/main/java/org/apache/commons/beanutils/converters/CharacterArrayConverter.java
b/src/main/java/org/apache/commons/beanutils/converters/CharacterArrayConverter.java
index d209a3e6..df0ccb0e 100644
---
a/src/main/java/org/apache/commons/beanutils/converters/CharacterArrayConverter.java
+++
b/src/main/java/org/apache/commons/beanutils/converters/CharacterArrayConverter.java
@@ -112,7 +112,7 @@ public final class CharacterArrayConverter extends
AbstractArrayConverter {
final List<String> list = parseElements(value.toString());
final char[] results = new char[list.size()];
for (int i = 0; i < results.length; i++) {
- results[i] = ((String) list.get(i)).charAt(0);
+ results[i] = list.get(i).charAt(0);
}
return results;
} catch (final Exception e) {
diff --git
a/src/main/java/org/apache/commons/beanutils/converters/DoubleArrayConverter.java
b/src/main/java/org/apache/commons/beanutils/converters/DoubleArrayConverter.java
index 5cf55453..c7954139 100644
---
a/src/main/java/org/apache/commons/beanutils/converters/DoubleArrayConverter.java
+++
b/src/main/java/org/apache/commons/beanutils/converters/DoubleArrayConverter.java
@@ -112,7 +112,7 @@ public final class DoubleArrayConverter extends
AbstractArrayConverter {
final List<String> list = parseElements(value.toString());
final double[] results = new double[list.size()];
for (int i = 0; i < results.length; i++) {
- results[i] = Double.parseDouble((String) list.get(i));
+ results[i] = Double.parseDouble(list.get(i));
}
return results;
} catch (final Exception e) {
diff --git
a/src/main/java/org/apache/commons/beanutils/converters/FloatArrayConverter.java
b/src/main/java/org/apache/commons/beanutils/converters/FloatArrayConverter.java
index 6496d538..8ee6bbae 100644
---
a/src/main/java/org/apache/commons/beanutils/converters/FloatArrayConverter.java
+++
b/src/main/java/org/apache/commons/beanutils/converters/FloatArrayConverter.java
@@ -112,7 +112,7 @@ public final class FloatArrayConverter extends
AbstractArrayConverter {
final List<String> list = parseElements(value.toString());
final float[] results = new float[list.size()];
for (int i = 0; i < results.length; i++) {
- results[i] = Float.parseFloat((String) list.get(i));
+ results[i] = Float.parseFloat(list.get(i));
}
return results;
} catch (final Exception e) {
diff --git
a/src/main/java/org/apache/commons/beanutils/converters/IntegerArrayConverter.java
b/src/main/java/org/apache/commons/beanutils/converters/IntegerArrayConverter.java
index d9dc0b9b..bd288727 100644
---
a/src/main/java/org/apache/commons/beanutils/converters/IntegerArrayConverter.java
+++
b/src/main/java/org/apache/commons/beanutils/converters/IntegerArrayConverter.java
@@ -112,7 +112,7 @@ public final class IntegerArrayConverter extends
AbstractArrayConverter {
final List<String> list = parseElements(value.toString());
final int[] results = new int[list.size()];
for (int i = 0; i < results.length; i++) {
- results[i] = Integer.parseInt((String) list.get(i));
+ results[i] = Integer.parseInt(list.get(i));
}
return results;
} catch (final Exception e) {
diff --git
a/src/main/java/org/apache/commons/beanutils/converters/LongArrayConverter.java
b/src/main/java/org/apache/commons/beanutils/converters/LongArrayConverter.java
index 4ee07d3b..f6b7973c 100644
---
a/src/main/java/org/apache/commons/beanutils/converters/LongArrayConverter.java
+++
b/src/main/java/org/apache/commons/beanutils/converters/LongArrayConverter.java
@@ -112,7 +112,7 @@ public final class LongArrayConverter extends
AbstractArrayConverter {
final List<String> list = parseElements(value.toString());
final long[] results = new long[list.size()];
for (int i = 0; i < results.length; i++) {
- results[i] = Long.parseLong((String) list.get(i));
+ results[i] = Long.parseLong(list.get(i));
}
return results;
} catch (final Exception e) {
diff --git
a/src/main/java/org/apache/commons/beanutils/converters/ShortArrayConverter.java
b/src/main/java/org/apache/commons/beanutils/converters/ShortArrayConverter.java
index 3f5715be..62f25245 100644
---
a/src/main/java/org/apache/commons/beanutils/converters/ShortArrayConverter.java
+++
b/src/main/java/org/apache/commons/beanutils/converters/ShortArrayConverter.java
@@ -112,7 +112,7 @@ public final class ShortArrayConverter extends
AbstractArrayConverter {
final List<String> list = parseElements(value.toString());
final short[] results = new short[list.size()];
for (int i = 0; i < results.length; i++) {
- results[i] = Short.parseShort((String) list.get(i));
+ results[i] = Short.parseShort(list.get(i));
}
return results;
} catch (final Exception e) {
diff --git
a/src/main/java/org/apache/commons/beanutils/converters/StringArrayConverter.java
b/src/main/java/org/apache/commons/beanutils/converters/StringArrayConverter.java
index e589c0fa..2766322e 100644
---
a/src/main/java/org/apache/commons/beanutils/converters/StringArrayConverter.java
+++
b/src/main/java/org/apache/commons/beanutils/converters/StringArrayConverter.java
@@ -137,7 +137,7 @@ public final class StringArrayConverter extends
AbstractArrayConverter {
final List<String> list = parseElements(value.toString());
final String[] results = new String[list.size()];
for (int i = 0; i < results.length; i++) {
- results[i] = (String) list.get(i);
+ results[i] = list.get(i);
}
return results;
} catch (final Exception e) {
diff --git
a/src/test/java/org/apache/commons/beanutils/locale/LocaleConvertUtilsTestCase.java
b/src/test/java/org/apache/commons/beanutils/locale/LocaleConvertUtilsTestCase.java
index 173643cd..cc695ec4 100644
---
a/src/test/java/org/apache/commons/beanutils/locale/LocaleConvertUtilsTestCase.java
+++
b/src/test/java/org/apache/commons/beanutils/locale/LocaleConvertUtilsTestCase.java
@@ -20,7 +20,6 @@ package org.apache.commons.beanutils.locale;
import java.sql.Date;
import java.sql.Time;
import java.sql.Timestamp;
-import java.text.DecimalFormat;
import java.text.NumberFormat;
import java.util.Locale;
@@ -281,7 +280,7 @@ public class LocaleConvertUtilsTestCase extends TestCase {
LocaleConvertUtils.deregister();
- final NumberFormat nf = DecimalFormat.getNumberInstance();
+ final NumberFormat nf = NumberFormat.getNumberInstance();
final String result = nf.format(1.1);
// could be commas instead of stops in Europe.
@@ -337,9 +336,9 @@ public class LocaleConvertUtilsTestCase extends TestCase {
* converters have been generified.)
*/
public void testDefaultToStringConversionUnsupportedType() {
- final Integer value = 20131101;
- assertEquals("Wrong result", value.toString(),
- LocaleConvertUtils.convert(value.toString(), getClass()));
+ final int value = 20131101;
+ assertEquals("Wrong result", Integer.toString(value),
+ LocaleConvertUtils.convert(Integer.toString(value),
getClass()));
}
/**
