This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-email.git


The following commit(s) were added to refs/heads/master by this push:
     new 3bff9ba  Add missing tests
3bff9ba is described below

commit 3bff9ba5dc12e95fec9ce5ab9ad617a8cbf90744
Author: Gary D. Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Dec 21 17:00:41 2024 -0500

    Add missing tests
---
 .../apache/commons/mail2/core/EmailUtilsTest.java  | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git 
a/commons-email2-core/src/test/java/org/apache/commons/mail2/core/EmailUtilsTest.java
 
b/commons-email2-core/src/test/java/org/apache/commons/mail2/core/EmailUtilsTest.java
index c0465db..bbc56df 100644
--- 
a/commons-email2-core/src/test/java/org/apache/commons/mail2/core/EmailUtilsTest.java
+++ 
b/commons-email2-core/src/test/java/org/apache/commons/mail2/core/EmailUtilsTest.java
@@ -18,7 +18,12 @@
 package org.apache.commons.mail2.core;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import java.util.HashMap;
+import java.util.Map;
 
 import org.junit.jupiter.api.Test;
 
@@ -39,8 +44,25 @@ public class EmailUtilsTest {
         assertEquals("abc  defg", 
EmailUtils.replaceEndOfLineCharactersWithSpaces("abc\n\rdefg"));
     }
 
+    @Test
+    public void testIsEmptyMap() {
+        assertTrue(EmailUtils.isEmpty((Map<?, ?>) null));
+        final HashMap<String, String> map = new HashMap<>();
+        assertTrue(EmailUtils.isEmpty(map));
+        map.put("k", "v");
+        assertFalse(EmailUtils.isEmpty(map));
+    }
+
+    @Test
+    public void testIsEmptyString() {
+        assertTrue(EmailUtils.isEmpty((String) null));
+        assertTrue(EmailUtils.isEmpty(""));
+        assertFalse(EmailUtils.isEmpty("a"));
+    }
+
     @Test
     public void testUrlEncoding() {
+        assertNull(EmailUtils.encodeUrl(null));
         assertEquals("abcdefg", EmailUtils.encodeUrl("abcdefg"));
         assertEquals("0123456789", EmailUtils.encodeUrl("0123456789"));
         assertEquals("Test%20CID", EmailUtils.encodeUrl("Test CID"));

Reply via email to