(commons-dbcp) 02/02: Make test fixture class final

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git

commit 0ab04508d78f2a11f08a4f23b818267af0d8b24b
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Wed Dec 18 13:25:40 2024 -0500

    Make test fixture class final
---
 src/test/java/org/apache/commons/dbcp2/TestDelegatingConnection.java  | 4 ++--
 .../commons/dbcp2/managed/TestDataSourceXAConnectionFactory.java      | 2 +-
 .../org/apache/commons/dbcp2/managed/TesterBasicXAConnection.java     | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/dbcp2/TestDelegatingConnection.java 
b/src/test/java/org/apache/commons/dbcp2/TestDelegatingConnection.java
index 920b8ba3..f5bd61c0 100644
--- a/src/test/java/org/apache/commons/dbcp2/TestDelegatingConnection.java
+++ b/src/test/java/org/apache/commons/dbcp2/TestDelegatingConnection.java
@@ -44,7 +44,7 @@ public class TestDelegatingConnection {
      * Delegate that doesn't support read-only or auto-commit. It will merely 
take the input value of setReadOnly and setAutoCommit and discard it, to keep
      * false.
      */
-    static class NoReadOnlyOrAutoCommitConnection extends TesterConnection {
+    static final class NoReadOnlyOrAutoCommitConnection extends 
TesterConnection {
         private final boolean readOnly = false;
         private final boolean autoCommit = false;
 
@@ -76,7 +76,7 @@ public class TestDelegatingConnection {
     /**
      * Delegate that will throw RTE on toString Used to validate fix for 
DBCP-241
      */
-    static class RTEGeneratingConnection extends TesterConnection {
+    static final class RTEGeneratingConnection extends TesterConnection {
 
         public RTEGeneratingConnection() {
             super("", "");
diff --git 
a/src/test/java/org/apache/commons/dbcp2/managed/TestDataSourceXAConnectionFactory.java
 
b/src/test/java/org/apache/commons/dbcp2/managed/TestDataSourceXAConnectionFactory.java
index 87087658..fb8c030c 100644
--- 
a/src/test/java/org/apache/commons/dbcp2/managed/TestDataSourceXAConnectionFactory.java
+++ 
b/src/test/java/org/apache/commons/dbcp2/managed/TestDataSourceXAConnectionFactory.java
@@ -45,7 +45,7 @@ public class TestDataSourceXAConnectionFactory extends 
TestBasicDataSource {
      * Delegates everything to the BasicDataSource (ds field), except for
      * getXAConnection which creates a BasicXAConnection.
      */
-    public class XADataSourceHandle implements InvocationHandler {
+    public final class XADataSourceHandle implements InvocationHandler {
 
         protected XAConnection getXAConnection() throws SQLException {
             return new TesterBasicXAConnection(ds.getConnection(), 
closeCounter);
diff --git 
a/src/test/java/org/apache/commons/dbcp2/managed/TesterBasicXAConnection.java 
b/src/test/java/org/apache/commons/dbcp2/managed/TesterBasicXAConnection.java
index b5994ef5..c3f06da1 100644
--- 
a/src/test/java/org/apache/commons/dbcp2/managed/TesterBasicXAConnection.java
+++ 
b/src/test/java/org/apache/commons/dbcp2/managed/TesterBasicXAConnection.java
@@ -46,7 +46,7 @@ public class TesterBasicXAConnection implements XAConnection {
      * Delegates everything to a Connection, except for close() which just
      * notifies the parent XAConnection.
      */
-    public static class ConnectionHandle implements InvocationHandler {
+    public static final class ConnectionHandle implements InvocationHandler {
 
         public Connection conn;