This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git
commit 6b2517c416ad32764e756b1113aeeccc93b764ec Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Mon Dec 9 08:23:51 2024 -0500 Use forEach() --- src/main/java/org/apache/commons/lang3/Validate.java | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/Validate.java b/src/main/java/org/apache/commons/lang3/Validate.java index cf5aba48a..298285aeb 100644 --- a/src/main/java/org/apache/commons/lang3/Validate.java +++ b/src/main/java/org/apache/commons/lang3/Validate.java @@ -17,9 +17,9 @@ package org.apache.commons.lang3; import java.util.Collection; -import java.util.Iterator; import java.util.Map; import java.util.Objects; +import java.util.concurrent.atomic.AtomicInteger; import java.util.function.Supplier; import java.util.regex.Pattern; @@ -667,13 +667,12 @@ public class Validate { */ public static <T extends Iterable<?>> T noNullElements(final T iterable, final String message, final Object... values) { Objects.requireNonNull(iterable, "iterable"); - int i = 0; - for (final Iterator<?> it = iterable.iterator(); it.hasNext(); i++) { - if (it.next() == null) { - final Object[] values2 = ArrayUtils.addAll(values, Integer.valueOf(i)); - throw new IllegalArgumentException(getMessage(message, values2)); + AtomicInteger ai = new AtomicInteger(); + iterable.forEach(e -> { + if (e == null) { + throw new IllegalArgumentException(getMessage(message, ArrayUtils.addAll(values, ai.getAndIncrement()))); } - } + }); return iterable; }