This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git

commit b2de05610080da6b55a43e8562e2b733fc194ce6
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Nov 30 09:24:05 2024 -0500

    Use JUnit 5 to convert String to Charset
---
 .../commons/compress/compressors/gzip/GzipParametersTest.java    | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/compress/compressors/gzip/GzipParametersTest.java
 
b/src/test/java/org/apache/commons/compress/compressors/gzip/GzipParametersTest.java
index 3672321ac..1af61ffbb 100644
--- 
a/src/test/java/org/apache/commons/compress/compressors/gzip/GzipParametersTest.java
+++ 
b/src/test/java/org/apache/commons/compress/compressors/gzip/GzipParametersTest.java
@@ -24,6 +24,7 @@ import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
+import java.nio.charset.Charset;
 import java.util.zip.Deflater;
 
 import org.apache.commons.io.Charsets;
@@ -53,10 +54,10 @@ public class GzipParametersTest {
         "UTF-16BE  , helloworld, false"
     })
     //@formatter:on
-    public void testIllegalCommentOrFileName(final String charsetName, final 
String text) {
+    public void testIllegalCommentOrFileName(final Charset charset, final 
String text) {
         final GzipParameters gzipParameters = new GzipParameters();
         // null resets to default value
-        gzipParameters.setFileNameCharset(Charsets.toCharset(charsetName, 
null));
+        gzipParameters.setFileNameCharset(charset);
         assertThrows(IllegalArgumentException.class, () -> 
gzipParameters.setComment(text));
         assertNull(gzipParameters.getComment());
         assertThrows(IllegalArgumentException.class, () -> 
gzipParameters.setFilename(text));
@@ -76,10 +77,10 @@ public class GzipParametersTest {
         "UTF-8     , helloƩworld"
     })
     //@formatter:on
-    public void testLegalCommentOrFileName(final String charsetName, final 
String text) {
+    public void testLegalCommentOrFileName(final Charset charset, final String 
text) {
         final GzipParameters gzipParameters = new GzipParameters();
         // null resets to default value
-        gzipParameters.setFileNameCharset(Charsets.toCharset(charsetName, 
null));
+        gzipParameters.setFileNameCharset(charset);
         gzipParameters.setComment(text);
         assertEquals(text, gzipParameters.getComment());
         gzipParameters.setFilename(text);

Reply via email to