This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
commit 0ae9acca205524f0119671c1a1b2a983b1bfd511
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Nov 23 15:19:34 2024 -0500
Raise the bar for JaCoCo checks
---
pom.xml | 7 ++++---
src/changes/changes.xml | 1 +
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/pom.xml b/pom.xml
index d1fcf22b..1959f0de 100644
--- a/pom.xml
+++ b/pom.xml
@@ -196,12 +196,13 @@
<surefire.argline></surefire.argline>
<!-- JaCoCo: Don't make code coverage worse than: -->
<commons.jacoco.haltOnFailure>true</commons.jacoco.haltOnFailure>
+ <!-- Keep the jacoco property order below which matches console output -->
<commons.jacoco.classRatio>0.98</commons.jacoco.classRatio>
- <commons.jacoco.instructionRatio>0.68</commons.jacoco.instructionRatio>
- <commons.jacoco.methodRatio>0.87</commons.jacoco.methodRatio>
+ <commons.jacoco.instructionRatio>0.74</commons.jacoco.instructionRatio>
+ <commons.jacoco.methodRatio>0.89</commons.jacoco.methodRatio>
<commons.jacoco.branchRatio>0.66</commons.jacoco.branchRatio>
<commons.jacoco.lineRatio>0.62</commons.jacoco.lineRatio>
- <commons.jacoco.complexityRatio>0.76</commons.jacoco.complexityRatio>
+ <commons.jacoco.complexityRatio>0.79</commons.jacoco.complexityRatio>
</properties>
<build>
<defaultGoal>clean verify apache-rat:check japicmp:cmp checkstyle:check
spotbugs:check pmd:check pmd:cpd-check javadoc:javadoc</defaultGoal>
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 7e87d3d6..b562293c 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -79,6 +79,7 @@ The <action> type attribute can be add,update,fix,remove.
<action type="add" dev="ggregory" due-to="Johno Crawford, Gary
Gregory">Add support for ignoring non-fatal SQL state codes #421.</action>
<action type="add" dev="ggregory" due-to="Johno Crawford, Gary
Gregory">Add @FunctionalInterface to SwallowedExceptionListener.</action>
<action type="add" dev="ggregory" due-to="Gary Gregory">Add missing
Javadoc comments and descriptions.</action>
+ <action type="add" dev="ggregory" due-to="Gary Gregory">Add tests, raise
the bar for JaCoCo checks.</action>
<!-- UPDATE -->
<action type="update" dev="ggregory" due-to="Gary Gregory">Bump
org.apache.commons:commons-parent from 66 to 78 #360, #371, #395, #420, #426,
#436, #441, #449.</action>
<action type="update" dev="ggregory" due-to="Gary Gregory,
Dependabot">Bump commons-logging:commons-logging from 1.3.0 to 1.3.4 #368,
#399, #423.</action>
