This is an automated email from the ASF dual-hosted git repository. ebourg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/commons-digester.git
from 8ad795d9 Merge pull request #208 from apache/dependabot/github_actions/actions/checkout-4.2.2 new 7dc5537d Replaced C-style array declarations with Java-style declarations new 0972ed55 Do not catch and rethrow the same exception new 6799b2b0 Removed redundant class and method modifiers new 0fc2e001 Use Map.computeIfAbsent() new 88c01b5c Replaced Collections.sort() with List.sort() new 1ae7936b Use try-with-resources new 15f45bb9 Replaced lambdas with method references new e4399288 Removed unreachable code in the tests new d500294e Use JUnit 4 @Test(expected=...) to test exceptions new 2a27109d Removed redundant type arguments new d8a535f8 Fixed the relative path of the parent poms new 76f57299 Fixed Javadoc errors new 798edf33 Use for-each loops new 0e44a502 Removed redundant type casts new 688dbf4d Added missing @Test annotations new cc3d1d87 Removed unused local variables new 01643b62 Removed the unused assignments new a4454900 Use String.isEmpty() instead of String.size() < 1 new 8a2a54bf Fixed the plugin class reported in the debug log new a8927fb8 Removed unnecessary calls to toString() new 1fd8a4f0 Replaced the @Test(expected=...) annotations with assertThrows() calls new 751b655e Use assertThrows() to test the exceptions new 90383f01 Reduced the exceptions thrown by the test methods new ac8c46a1 Removed the unused throw clauses in the tests new ee7d57dc Migrated the tests to JUnit 5 new 48f6746a Fixed the checkstyle configuration new 3e795f8a Fixed the space issues reported by checkstyle new 7e0b8468 Removed the public modifier on the constructors of the private classes (checkstyle violation) new 08f752b3 Use Collection.removeIf() instead of Iterator.remove() in a loop new 23ca9f81 Use the Java 8 Comparator API new e2c10b89 Do not initialize twice ancesterMatched to false in ExtendedBaseRules.match() new f2642451 Reduced the length of ExtendedBaseRules.match (checkstyle violation) new c10c3040 Removed the standalone @inheritDoc tags new 58eaff73 Fixed some of the violations reported by PMD new 74b7b616 Added the missing CONTRIBUTING.md file new 0a6c0c14 Fixed a few typos new a7b571ab Removed the protected modifier from the members of private classes new 06211ba0 No longer use the primitive type constructors new 6d001231 Link the documentation to the Java 8 API new a64d6931 Use https URLs in the documentation new c05bb5aa Do not synchronize on a non final field new 04d3a213 Use List types instead of ArrayList new 50f29d1e Updated the link to the examples new a6e99d5a Removed an unreachable statement in CallMethodRule new 25b6b82d Replaced 'xml' with 'XML' in the documentation new 8370a80f Apache branding when Commons Digester is mentioned new 3d305256 Removed the references to the now standard XML libraries new 82cd8e14 Removed the references to Java 1.4 and Java 5 new 52bc0fd9 Fixed links to the Javadoc in the documentations new 8583ab5c Removed the references to the old regex libraries new 8cef7565 Turned ObjectCreationFactory into a functional interface new c79446c4 Merged the changelog entries related to the same item new 8643ec23 Set the @since version of DefaultThrowingErrorHandler to 3.3 The 53 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CONTRIBUTING.md | 114 ++++++++ PROPOSAL.html | 4 +- RELEASE-NOTES.txt | 4 +- commons-digester3-core/pom.xml | 39 ++- .../commons/digester3/AbstractMethodRule.java | 17 +- .../digester3/AbstractObjectCreationFactory.java | 6 - .../commons/digester3/AbstractRulesImpl.java | 17 +- .../commons/digester3/BeanPropertySetterRule.java | 15 - .../apache/commons/digester3/CallMethodRule.java | 28 +- .../apache/commons/digester3/CallParamRule.java | 12 - .../digester3/DefaultThrowingErrorHandler.java | 11 +- .../org/apache/commons/digester3/Digester.java | 157 ++++------- .../commons/digester3/ExtendedBaseRules.java | 144 +++------- .../commons/digester3/FactoryCreateRule.java | 14 +- .../apache/commons/digester3/NodeCreateRule.java | 29 +- .../apache/commons/digester3/ObjectCreateRule.java | 14 +- .../commons/digester3/ObjectCreationFactory.java | 10 +- .../apache/commons/digester3/ObjectParamRule.java | 12 +- .../commons/digester3/PathCallParamRule.java | 6 - .../commons/digester3/PatternRuleMatcher.java | 15 +- .../commons/digester3/RecordedInvocation.java | 9 +- .../org/apache/commons/digester3/RegexRules.java | 20 +- .../java/org/apache/commons/digester3/Rule.java | 2 +- .../java/org/apache/commons/digester3/RuleSet.java | 2 +- .../org/apache/commons/digester3/RuleSetBase.java | 3 - .../org/apache/commons/digester3/RulesBase.java | 25 +- .../commons/digester3/SetNestedPropertiesRule.java | 48 ++-- .../org/apache/commons/digester3/SetNextRule.java | 10 +- .../commons/digester3/SetPropertiesRule.java | 28 +- .../apache/commons/digester3/SetPropertyRule.java | 6 - .../org/apache/commons/digester3/SetRootRule.java | 10 +- .../org/apache/commons/digester3/SetTopRule.java | 10 +- .../commons/digester3/SimpleRegexMatcher.java | 7 +- .../org/apache/commons/digester3/Substitutor.java | 2 +- .../digester3/WithDefaultsRulesWrapper.java | 24 -- .../DefaultAnnotationHandlerFactory.java | 3 - .../annotations/FromAnnotationsRuleModule.java | 17 +- .../annotations/WithMemoryRulesBinder.java | 17 +- .../handlers/AbstractMethodHandler.java | 3 - .../handlers/BeanPropertySetterHandler.java | 3 - .../annotations/handlers/CallMethodHandler.java | 3 - .../annotations/handlers/CallParamHandler.java | 3 - .../annotations/handlers/FactoryCreateHandler.java | 3 - .../annotations/handlers/ObjectCreateHandler.java | 5 +- .../annotations/handlers/PathCallParamHandler.java | 3 - .../annotations/handlers/SetNextHandler.java | 3 - .../annotations/handlers/SetPropertiesHandler.java | 3 - .../annotations/handlers/SetRootHandler.java | 3 - .../annotations/handlers/SetTopHandler.java | 3 - .../digester3/annotations/package-info.java | 4 +- .../annotations/reflect/MethodArgument.java | 12 - .../annotations/reflect/package-info.java | 2 +- .../digester3/annotations/rules/FactoryCreate.java | 5 +- .../annotations/utils/AnnotationUtils.java | 2 +- .../digester3/annotations/utils/package-info.java | 2 +- .../binder/AbstractBackToLinkedRuleBuilder.java | 3 - .../AbstractNamespaceURIBasedRulesModule.java | 3 - .../digester3/binder/AbstractParamTypeBuilder.java | 4 +- .../digester3/binder/AbstractRulesModule.java | 3 - .../binder/BeanPropertySetterBuilder.java | 3 - .../digester3/binder/BinderClassLoader.java | 6 - .../commons/digester3/binder/ByRuleBuilder.java | 3 - .../digester3/binder/ByRuleProviderBuilder.java | 3 - .../digester3/binder/CallMethodBuilder.java | 7 +- .../commons/digester3/binder/CallParamBuilder.java | 3 - .../digester3/binder/DefaultRulesBinder.java | 20 +- .../commons/digester3/binder/DigesterLoader.java | 4 +- .../commons/digester3/binder/ErrorMessage.java | 7 +- .../digester3/binder/FactoryCreateBuilder.java | 3 - .../digester3/binder/FromBinderRuleSet.java | 32 +-- .../digester3/binder/NestedPropertiesBuilder.java | 9 +- .../digester3/binder/NodeCreateRuleProvider.java | 3 - .../digester3/binder/ObjectCreateBuilder.java | 5 +- .../digester3/binder/ObjectParamBuilder.java | 3 - .../digester3/binder/PathCallParamBuilder.java | 3 - .../digester3/binder/PluginCreateRuleBuilder.java | 13 +- .../binder/PluginDeclarationRuleBuilder.java | 3 - .../commons/digester3/binder/SetNextBuilder.java | 3 - .../digester3/binder/SetPropertiesBuilder.java | 3 - .../digester3/binder/SetPropertyBuilder.java | 3 - .../commons/digester3/binder/SetRootBuilder.java | 3 - .../commons/digester3/binder/SetTopBuilder.java | 3 - .../commons/digester3/plugins/Declaration.java | 12 +- .../digester3/plugins/PluginAssertionFailure.java | 4 +- .../commons/digester3/plugins/PluginContext.java | 36 +-- .../digester3/plugins/PluginCreateRule.java | 48 +--- .../digester3/plugins/PluginDeclarationRule.java | 8 +- .../commons/digester3/plugins/PluginManager.java | 4 +- .../commons/digester3/plugins/PluginRules.java | 17 +- .../commons/digester3/plugins/RuleFinder.java | 4 +- .../commons/digester3/plugins/RuleLoader.java | 8 +- .../plugins/strategies/FinderFromClass.java | 4 +- .../plugins/strategies/FinderFromDfltClass.java | 4 +- .../plugins/strategies/FinderFromDfltMethod.java | 2 +- .../plugins/strategies/FinderFromDfltResource.java | 2 +- .../plugins/strategies/FinderFromFile.java | 7 +- .../plugins/strategies/FinderFromMethod.java | 2 +- .../plugins/strategies/FinderFromResource.java | 11 +- .../plugins/strategies/FinderSetProperties.java | 8 +- .../plugins/strategies/LoaderFromClass.java | 7 +- .../plugins/strategies/LoaderFromStream.java | 3 - .../plugins/strategies/LoaderSetProperties.java | 5 +- .../substitution/CompoundSubstitutor.java | 6 - .../substitution/MultiVariableExpander.java | 8 +- .../digester3/substitution/VariableAttributes.java | 38 +-- .../substitution/VariableSubstitutor.java | 8 +- .../digester3/substitution/package-info.java | 2 +- .../digester3/xmlrules/AbstractXmlMethodRule.java | 5 +- .../digester3/xmlrules/AbstractXmlRule.java | 5 +- .../digester3/xmlrules/BeanPropertySetterRule.java | 5 +- .../commons/digester3/xmlrules/CallMethodRule.java | 8 +- .../commons/digester3/xmlrules/CallParamRule.java | 10 +- .../digester3/xmlrules/FactoryCreateRule.java | 5 +- .../digester3/xmlrules/FromXmlRulesModule.java | 3 - .../commons/digester3/xmlrules/IncludeRule.java | 9 +- .../xmlrules/NameSpaceURIRulesBinder.java | 17 +- .../commons/digester3/xmlrules/NodeCreateRule.java | 5 +- .../digester3/xmlrules/ObjectCreateRule.java | 5 +- .../digester3/xmlrules/ObjectParamRule.java | 5 +- .../commons/digester3/xmlrules/PatternRule.java | 10 +- .../commons/digester3/xmlrules/PatternStack.java | 3 +- .../digester3/xmlrules/PrefixedRulesBinder.java | 17 +- .../digester3/xmlrules/SetNamespaceURIRule.java | 8 +- .../xmlrules/SetNestedPropertiesAliasRule.java | 3 - .../xmlrules/SetNestedPropertiesIgnoreRule.java | 3 - .../xmlrules/SetNestedPropertiesRule.java | 8 +- .../commons/digester3/xmlrules/SetNextRule.java | 5 +- .../digester3/xmlrules/SetPropertiesAliasRule.java | 3 - .../xmlrules/SetPropertiesIgnoreRule.java | 3 - .../digester3/xmlrules/SetPropertiesRule.java | 8 +- .../digester3/xmlrules/SetPropertyRule.java | 5 +- .../commons/digester3/xmlrules/SetRootRule.java | 5 +- .../commons/digester3/xmlrules/SetTopRule.java | 5 +- .../digester3/xmlrules/WithMemoryRulesBinder.java | 17 +- .../commons/digester3/xmlrules/XmlRulesModule.java | 7 +- .../src/main/resources/overview.html | 2 +- .../commons/digester3/AsyncReaderTestCase.java | 12 +- .../digester3/BeanPropertySetterRuleTestCase.java | 84 ++---- .../commons/digester3/CallMethodRuleTestCase.java | 143 ++++------ .../commons/digester3/DTDValidationTestCase.java | 12 +- .../commons/digester3/Digester133TestCase.java | 4 +- .../commons/digester3/Digester153TestCase.java | 22 +- .../commons/digester3/Digester162TestCase.java | 8 +- .../commons/digester3/Digester171TestCase.java | 11 +- .../apache/commons/digester3/DigesterTestCase.java | 306 +++++++-------------- .../org/apache/commons/digester3/Employee.java | 2 +- .../apache/commons/digester3/ErrorHandlerTest.java | 102 ++----- .../digester3/ExtendedBaseRulesTestCase.java | 215 +++++++-------- .../commons/digester3/LocationTrackerTestCase.java | 8 +- .../digester3/NamespaceSnapshotTestCase.java | 8 +- .../commons/digester3/NodeCreateRuleTestCase.java | 200 +++++--------- .../commons/digester3/ObjectParamRuleTestCase.java | 23 +- .../OverlappingCallMethodRuleTestCase.java | 30 +- .../commons/digester3/RegexRulesTestCase.java | 103 +++---- .../org/apache/commons/digester3/RuleTestCase.java | 236 +++++++--------- .../commons/digester3/RulesBaseTestCase.java | 82 +++--- .../digester3/SetNestedPropertiesRuleTestCase.java | 130 ++++----- .../digester3/SetPropertiesRuleTestCase.java | 81 ++---- .../commons/digester3/SetPropertyRuleTestCase.java | 82 ++---- .../org/apache/commons/digester3/TestBean.java | 8 +- .../commons/digester3/TestEntityResolution.java | 2 +- .../commons/digester3/TestFactoryCreate.java | 127 +++------ .../org/apache/commons/digester3/TestRule.java | 5 +- .../org/apache/commons/digester3/TestRuleSet.java | 3 - .../org/apache/commons/digester3/URLTestCase.java | 12 +- .../WithDefaultsRulesWrapperTestCase.java | 46 ++-- .../apache/commons/digester3/XIncludeTestCase.java | 13 +- .../commons/digester3/XMLSchemaTestCase.java | 35 +-- .../annotations/AbstractAnnotatedPojoTestCase.java | 2 +- .../addressbook/AddressBookTestCase.java | 2 +- .../annotations/catalog/CatalogTestCase.java | 2 +- .../annotations/employee/EmployeeTestCase.java | 2 +- .../annotations/failingtests/FailingTestCase.java | 8 +- .../annotations/person/PersonTestCase.java | 2 +- .../digester3/annotations/rss/RssTestCase.java | 2 +- .../servletbean/ServletBeanTestCase.java | 2 +- .../binder/BinderClassLoaderTestCase.java | 30 +- .../digester3/binder/Digester163TestCase.java | 10 +- .../digester3/binder/DigesterLoaderTestCase.java | 10 +- .../commons/digester3/plugins/DumperRule.java | 3 - .../plugins/TestConfigurablePluginAttributes.java | 85 +++--- .../commons/digester3/plugins/TestDeclaration.java | 21 +- .../digester3/plugins/TestDefaultPlugin.java | 36 +-- .../commons/digester3/plugins/TestDelegate.java | 24 +- .../commons/digester3/plugins/TestInline.java | 30 +- .../commons/digester3/plugins/TestLocalRules.java | 40 +-- .../commons/digester3/plugins/TestRecursion.java | 13 +- .../commons/digester3/plugins/TestRuleInfo.java | 37 +-- .../commons/digester3/plugins/TestXmlRuleInfo.java | 37 +-- .../apache/commons/digester3/plugins/Utils.java | 1 - .../substitution/CompoundSubstitutorTestCase.java | 44 +-- .../substitution/VariableExpansionTestCase.java | 23 +- .../xmlrules/BeanPropertySetterRuleTestCase.java | 4 +- .../xmlrules/DigesterPatternStackTest.java | 15 +- .../xmlrules/DigesterRulesSourceTestImpl.java | 3 - .../digester3/xmlrules/FromXmlRuleSetTest.java | 115 ++++---- .../commons/digester3/xmlrules/IncludeTest.java | 18 +- .../commons/digester3/xmlrules/ObjectTestImpl.java | 2 +- .../xmlrules/SetNamespaceURITestCase.java | 4 +- .../xmlrules/ThrowExceptionCreationFactory.java | 1 - commons-digester3-dist/pom.xml | 2 +- .../annotations/atom/pom.xml | 2 +- commons-digester3-examples/api/addressbook/pom.xml | 2 +- .../api/addressbook/readme.txt | 4 +- .../digester3/examples/api/addressbook/Main.java | 14 +- commons-digester3-examples/api/catalog/pom.xml | 2 +- commons-digester3-examples/api/catalog/readme.txt | 6 +- .../examples/api/catalog/AudioVisual.java | 4 +- .../examples/api/catalog/BookFactory.java | 6 +- .../digester3/examples/api/catalog/Main.java | 20 +- commons-digester3-examples/api/dbinsert/pom.xml | 2 +- .../digester3/examples/api/dbinsert/Main.java | 6 +- .../examples/api/dbinsert/RowInserterRule.java | 10 +- .../api/document-markup/pom.xml | 2 +- .../api/document-markup/readme.txt | 16 +- .../examples/api/documentmarkup/Main.java | 10 +- .../api/documentmarkup/MarkupDigester.java | 8 +- .../api/documentmarkup/SetTextSegmentRule.java | 2 +- commons-digester3-examples/api/readme.txt | 8 +- commons-digester3-examples/edsl/atom/pom.xml | 2 +- .../plugins/pipeline/pom.xml | 2 +- .../examples/plugins/pipeline/CaseTransform.java | 2 +- .../examples/plugins/pipeline/Pipeline.java | 2 +- commons-digester3-examples/pom.xml | 2 +- commons-digester3-examples/readme.txt | 4 +- commons-digester3-examples/rss/pom.xml | 2 +- .../org/apache/commons/digester3/rss/Channel.java | 9 +- .../apache/commons/digester3/rss/RSSDigester.java | 12 +- .../xmlrules/addressbook/pom.xml | 2 +- .../xmlrules/addressbook/readme.txt | 4 +- .../examples/xmlrules/addressbook/Main.java | 4 +- commons-digester3-examples/xmlrules/readme.txt | 4 +- pom.xml | 8 +- src/changes/changes.xml | 23 +- src/site/resources/dtds/digester-rules.dtd | 4 +- src/site/site.xml | 30 +- src/site/xdoc/download_digester.xml | 2 +- src/site/xdoc/guide/annotations.xml | 6 +- src/site/xdoc/guide/core.xml | 107 +++---- src/site/xdoc/guide/plugins.xml | 26 +- src/site/xdoc/guide/substitution.xml | 8 +- src/site/xdoc/index.xml | 10 +- 242 files changed, 1721 insertions(+), 3046 deletions(-) create mode 100644 CONTRIBUTING.md