This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git
commit 5a9d81b0a40cbf52083b722f900af541850d8c47 Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Wed Sep 25 18:35:31 2024 -0400 Use try-with-resources --- .../apache/commons/lang3/text/StrBuilderTest.java | 63 +++++++++++----------- 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/src/test/java/org/apache/commons/lang3/text/StrBuilderTest.java b/src/test/java/org/apache/commons/lang3/text/StrBuilderTest.java index 198cefd10..e771622c1 100644 --- a/src/test/java/org/apache/commons/lang3/text/StrBuilderTest.java +++ b/src/test/java/org/apache/commons/lang3/text/StrBuilderTest.java @@ -146,38 +146,39 @@ public class StrBuilderTest extends AbstractLangTest { @Test public void testAsReader() throws Exception { final StrBuilder sb = new StrBuilder("some text"); - Reader reader = sb.asReader(); - assertTrue(reader.ready()); - final char[] buf = new char[40]; - assertEquals(9, reader.read(buf)); - assertEquals("some text", new String(buf, 0, 9)); - - assertEquals(-1, reader.read()); - assertFalse(reader.ready()); - assertEquals(0, reader.skip(2)); - assertEquals(0, reader.skip(-1)); - - assertTrue(reader.markSupported()); - reader = sb.asReader(); - assertEquals('s', reader.read()); - reader.mark(-1); + try (Reader reader = sb.asReader()) { + assertTrue(reader.ready()); + final char[] buf = new char[40]; + assertEquals(9, reader.read(buf)); + assertEquals("some text", new String(buf, 0, 9)); + + assertEquals(-1, reader.read()); + assertFalse(reader.ready()); + assertEquals(0, reader.skip(2)); + assertEquals(0, reader.skip(-1)); + + assertTrue(reader.markSupported()); + } char[] array = new char[3]; - assertEquals(3, reader.read(array, 0, 3)); - assertEquals('o', array[0]); - assertEquals('m', array[1]); - assertEquals('e', array[2]); - reader.reset(); - assertEquals(1, reader.read(array, 1, 1)); - assertEquals('o', array[0]); - assertEquals('o', array[1]); - assertEquals('e', array[2]); - assertEquals(2, reader.skip(2)); - assertEquals(' ', reader.read()); - - assertTrue(reader.ready()); - reader.close(); - assertTrue(reader.ready()); - + try (Reader reader = sb.asReader()) { + assertEquals('s', reader.read()); + reader.mark(-1); + assertEquals(3, reader.read(array, 0, 3)); + assertEquals('o', array[0]); + assertEquals('m', array[1]); + assertEquals('e', array[2]); + reader.reset(); + assertEquals(1, reader.read(array, 1, 1)); + assertEquals('o', array[0]); + assertEquals('o', array[1]); + assertEquals('e', array[2]); + assertEquals(2, reader.skip(2)); + assertEquals(' ', reader.read()); + + assertTrue(reader.ready()); + reader.close(); + assertTrue(reader.ready()); + } try (Reader r = sb.asReader()) { final char[] arr = new char[3]; assertThrows(IndexOutOfBoundsException.class, () -> r.read(arr, -1, 0));