(commons-dbcp) 03/03: Use final

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git

commit 088e4a7197811bd310d513b71ccf3cf83ba09a7c
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Mon Aug 19 13:32:58 2024 -0400

    Use final
    
    Remove trailing whitespace
---
 src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java   | 2 +-
 src/main/java/org/apache/commons/dbcp2/Utils.java                       | 2 +-
 src/test/java/org/apache/commons/dbcp2/TesterDriver.java                | 2 +-
 .../org/apache/commons/dbcp2/cpdsadapter/TestDriverAdapterCPDS.java     | 2 +-
 .../org/apache/commons/dbcp2/datasources/TestPerUserPoolDataSource.java | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java 
b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
index c2f12d2e..c182d174 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
@@ -628,7 +628,7 @@ public class PoolableConnectionFactory implements 
PooledObjectFactory<PoolableCo
      * @throws IllegalArgumentException if any SQL state codes overlap with 
those in {@link #disconnectionSqlCodes}.
      * @since 2.13.0
      */
-    public void setDisconnectionIgnoreSqlCodes(Collection<String> 
disconnectionIgnoreSqlCodes) {
+    public void setDisconnectionIgnoreSqlCodes(final Collection<String> 
disconnectionIgnoreSqlCodes) {
         Utils.checkSqlCodes(disconnectionIgnoreSqlCodes, 
this.disconnectionSqlCodes);
         this.disconnectionIgnoreSqlCodes = disconnectionIgnoreSqlCodes;
     }
diff --git a/src/main/java/org/apache/commons/dbcp2/Utils.java 
b/src/main/java/org/apache/commons/dbcp2/Utils.java
index f67f2b60..7e3e7c7a 100644
--- a/src/main/java/org/apache/commons/dbcp2/Utils.java
+++ b/src/main/java/org/apache/commons/dbcp2/Utils.java
@@ -249,7 +249,7 @@ public final class Utils {
      * @return true if the SQL state is a fatal connection error, false 
otherwise.
      * @since 2.13.0
      */
-    static boolean isDisconnectionSqlCode(String sqlState) {
+    static boolean isDisconnectionSqlCode(final String sqlState) {
         return DISCONNECTION_SQL_CODES.contains(sqlState);
     }
 
diff --git a/src/test/java/org/apache/commons/dbcp2/TesterDriver.java 
b/src/test/java/org/apache/commons/dbcp2/TesterDriver.java
index 5f3c71fa..38e3d5cf 100644
--- a/src/test/java/org/apache/commons/dbcp2/TesterDriver.java
+++ b/src/test/java/org/apache/commons/dbcp2/TesterDriver.java
@@ -40,7 +40,7 @@ import java.util.logging.Logger;
  * </table>
  */
 public class TesterDriver implements Driver {
-    
+
     static TesterDriver INSTANCE = new TesterDriver();
 
     private static final Properties validUserPasswords = new Properties();
diff --git 
a/src/test/java/org/apache/commons/dbcp2/cpdsadapter/TestDriverAdapterCPDS.java 
b/src/test/java/org/apache/commons/dbcp2/cpdsadapter/TestDriverAdapterCPDS.java
index 73746669..784eff84 100644
--- 
a/src/test/java/org/apache/commons/dbcp2/cpdsadapter/TestDriverAdapterCPDS.java
+++ 
b/src/test/java/org/apache/commons/dbcp2/cpdsadapter/TestDriverAdapterCPDS.java
@@ -295,7 +295,7 @@ public class TestDriverAdapterCPDS {
         assertThrows(SQLException.class, () -> pcds.getPooledConnection("u1", 
"zlsafjk"), "Able to retrieve connection with incorrect password");
 
         // Use good password
-        SQLException e = assertThrows(SQLException.class, () -> 
pcds.getPooledConnection("u1", "x"), "Able to retrieve connection with 
incorrect password");
+        final SQLException e = assertThrows(SQLException.class, () -> 
pcds.getPooledConnection("u1", "x"), "Able to retrieve connection with 
incorrect password");
         assertTrue(e.getMessage().startsWith("x is not the correct password"));
         // else the exception was expected
 
diff --git 
a/src/test/java/org/apache/commons/dbcp2/datasources/TestPerUserPoolDataSource.java
 
b/src/test/java/org/apache/commons/dbcp2/datasources/TestPerUserPoolDataSource.java
index d74edc9f..4d3080ed 100644
--- 
a/src/test/java/org/apache/commons/dbcp2/datasources/TestPerUserPoolDataSource.java
+++ 
b/src/test/java/org/apache/commons/dbcp2/datasources/TestPerUserPoolDataSource.java
@@ -90,7 +90,7 @@ public class TestPerUserPoolDataSource extends 
TestConnectionPool {
         ((PerUserPoolDataSource) ds).close();
     }
 
-    /** 
+    /**
      * See DBCP-8
      */
     @Test