This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git
commit 64c73d02e0b3815a0c0cc9212124697584d454b9 Author: Gary Gregory <[email protected]> AuthorDate: Thu Jul 25 08:53:31 2024 -0400 Use fewer intermediary strings in DefaultExceptionContext.getFormattedExceptionMessage(String) --- src/changes/changes.xml | 1 + .../apache/commons/lang3/exception/DefaultExceptionContext.java | 7 +++---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 5fd88d6a2..b86596a2c 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -50,6 +50,7 @@ The <action> type attribute can be add,update,fix,remove. <action type="fix" dev="ggregory" due-to="Gary Gregory">Reimplement StopWatch internals to use java.time.</action> <action issue="LANG-1745" type="fix" dev="ggregory" due-to="Wang Hailong, Gary Gregory">RandomStringUtils.random() with a negative character index should throw IllegalArgumentException.</action> <action issue="LANG-1741" type="fix" dev="ggregory" due-to="Wang Hailong, Gary Gregory">LocaleUtils.toLocale(String) cannot parse four segments.</action> + <action type="fix" dev="ggregory" due-to="Gary Gregory">Use fewer intermediary strings in DefaultExceptionContext.getFormattedExceptionMessage(String).</action> <!-- ADD --> <action type="add" dev="ggregory" due-to="Gary Gregory">Add StopWatch.getSplitDuration() and deprecate getSplitTime().</action> <action type="add" dev="ggregory" due-to="Gary Gregory">Add StopWatch.getStartInstant() and deprecate getStartTime().</action> diff --git a/src/main/java/org/apache/commons/lang3/exception/DefaultExceptionContext.java b/src/main/java/org/apache/commons/lang3/exception/DefaultExceptionContext.java index 4f6cfb9ea..07fd4a0af 100644 --- a/src/main/java/org/apache/commons/lang3/exception/DefaultExceptionContext.java +++ b/src/main/java/org/apache/commons/lang3/exception/DefaultExceptionContext.java @@ -115,13 +115,12 @@ public class DefaultExceptionContext implements ExceptionContext, Serializable { buffer.append(pair.getKey()); buffer.append("="); final Object value = pair.getValue(); - String valueStr; try { - valueStr = Objects.toString(value); + buffer.append(Objects.toString(value)); } catch (final Exception e) { - valueStr = "Exception thrown on toString(): " + ExceptionUtils.getStackTrace(e); + buffer.append("Exception thrown on toString(): "); + buffer.append(ExceptionUtils.getStackTrace(e)); } - buffer.append(valueStr); buffer.append("]\n"); } buffer.append("---------------------------------");
