This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-jci.git
commit 61c3c57e66261c54122dee8fdefa816eee74656d Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Tue Jul 9 14:32:13 2024 -0400 Add @Override - Use diamonds - Use addAll() --- .../apache/commons/jci2/core/stores/MemoryResourceStore.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/core/src/main/java/org/apache/commons/jci2/core/stores/MemoryResourceStore.java b/core/src/main/java/org/apache/commons/jci2/core/stores/MemoryResourceStore.java index ee403e7..522fb30 100644 --- a/core/src/main/java/org/apache/commons/jci2/core/stores/MemoryResourceStore.java +++ b/core/src/main/java/org/apache/commons/jci2/core/stores/MemoryResourceStore.java @@ -34,18 +34,21 @@ public final class MemoryResourceStore implements ResourceStore { private final Log log = LogFactory.getLog(MemoryResourceStore.class); - private final Map<String, byte[]> store = new HashMap<String, byte[]>(); + private final Map<String, byte[]> store = new HashMap<>(); + @Override public byte[] read( final String pResourceName ) { log.debug("reading resource " + pResourceName); return store.get(pResourceName); } + @Override public void write( final String pResourceName, final byte[] pData ) { log.debug("writing resource " + pResourceName + "(" + pData.length + ")"); store.put(pResourceName, pData); } + @Override public void remove( final String pResourceName ) { log.debug("removing resource " + pResourceName); store.remove(pResourceName); @@ -59,11 +62,9 @@ public final class MemoryResourceStore implements ResourceStore { if (store == null) { return new String[0]; } - final List<String> names = new ArrayList<String>(); + final List<String> names = new ArrayList<>(); - for (final String name : store.keySet()) { - names.add(name); - } + names.addAll(store.keySet()); return names.toArray(new String[0]); }