(commons-net) branch master updated: Deprecate MLSxEntryParser default constructor in favor of MLSxEntryParser.getInstance()

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git


The following commit(s) were added to refs/heads/master by this push:
     new 06bcca73 Deprecate MLSxEntryParser default constructor in favor of 
MLSxEntryParser.getInstance()
06bcca73 is described below

commit 06bcca73ff55a4b3f62319701cc2933dbde3a40a
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Wed Jun 19 08:34:14 2024 -0400

    Deprecate MLSxEntryParser default constructor in favor of
    MLSxEntryParser.getInstance()
---
 src/changes/changes.xml                                             | 2 ++
 src/conf/findbugs-exclude-filter.xml                                | 6 ++++++
 .../java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java     | 6 +++++-
 3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index b6e68b4b..a61f934b 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -76,6 +76,8 @@ The <action> type attribute can be add,update,fix,remove.
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD 
AvoidBranchingStatementAsLastInLoop in 
org.apache.commons.net.bsd.RCommandClient.</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD 
UselessOverridingMethod in org.apache.commons.net.telnet.TelnetClient.</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD 
UnnecessaryModifier.</action>
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">Deprecate 
MLSxEntryParser default constructor in favor of 
MLSxEntryParser.getInstance().</action>
+
       <!-- ADD -->
       <!-- UPDATE -->
       <action type="update" dev="ggregory" due-to="Gary Gregory, 
Dependabot">Bump org.apache.commons:commons-parent from 70 to 71 #261.</action> 
diff --git a/src/conf/findbugs-exclude-filter.xml 
b/src/conf/findbugs-exclude-filter.xml
index 19a7b11c..7f8157fa 100644
--- a/src/conf/findbugs-exclude-filter.xml
+++ b/src/conf/findbugs-exclude-filter.xml
@@ -72,6 +72,12 @@
     <Bug code="UrF" />
   </Match>
 
+  <!-- Deprecated code -->
+  <Match>
+    <Class name="org.apache.commons.net.ftp.parser.MLSxEntryParser" />
+    <Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR" />
+  </Match>
+
   <!-- Used externally -->
   <Match>
     <Class name="org.apache.commons.net.pop3.POP3MessageInfo" />
diff --git 
a/src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java 
b/src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java
index 2d24d3be..3c17d2c3 100644
--- a/src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java
+++ b/src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java
@@ -133,9 +133,13 @@ public class MLSxEntryParser extends 
FTPFileEntryParserImpl {
     }
 
     /**
-     * Create the parser for MSLT and MSLD listing entries This class is 
immutable, so one can use {@link #getInstance()} instead.
+     * Creates the parser for MSLT and MSLD listing entries This class is 
immutable, so one can use {@link #getInstance()} instead.
+     *
+     * @deprecated Use {@link #getInstance()}.
      */
+    @Deprecated
     public MLSxEntryParser() {
+        // empty
     }
 
     // perm-fact = "Perm" "=" *pvals