This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit 58c36f92826c4a094fdd09348cf9075e721d2dc0
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Jun 16 11:41:19 2024 -0400
Fix PMD CollapsibleIfStatements in TelnetInputStream
---
src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
b/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
index 7656528e..372e66a5 100644
--- a/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
+++ b/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
@@ -196,10 +196,9 @@ final class TelnetInputStream extends BufferedInputStream
implements Runnable {
do {
try {
- if ((ch = read(mayBlock)) < 0) { // must be EOF
- if (ch != WOULD_BLOCK) {
- return ch;
- }
+ if ((ch = read(mayBlock)) < 0 && ch !=
WOULD_BLOCK) {
+ // must be EOF
+ return ch;
}
} catch (final InterruptedIOException e) {
synchronized (queue) {
