This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit af3266c4ddea8a3077da3502d4d2776ac7e1c9a9 Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Sun Jun 16 08:59:00 2024 -0400 Make private constant static --- src/main/java/org/apache/commons/net/telnet/TelnetOutputStream.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/apache/commons/net/telnet/TelnetOutputStream.java b/src/main/java/org/apache/commons/net/telnet/TelnetOutputStream.java index 12389d7c..f90e9e47 100644 --- a/src/main/java/org/apache/commons/net/telnet/TelnetOutputStream.java +++ b/src/main/java/org/apache/commons/net/telnet/TelnetOutputStream.java @@ -31,9 +31,9 @@ import java.io.OutputStream; * </p> */ final class TelnetOutputStream extends OutputStream { + private static final boolean CONVERT_TO_CRLF = true; private final TelnetClient client; // TODO there does not appear to be any way to change this value - should it be a ctor parameter? - private final boolean convertCRtoCRLF = true; private boolean lastWasCR; TelnetOutputStream(final TelnetClient client) { @@ -95,7 +95,7 @@ final class TelnetOutputStream extends OutputStream { if (client.requestedWont(TelnetOption.BINARY)) // i.e. ASCII { if (lastWasCR) { - if (convertCRtoCRLF) { + if (CONVERT_TO_CRLF) { client.sendByte('\n'); if (ch == '\n') // i.e. was CRLF anyway {